Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run clang-tidy warning checks reported as errors #37698

Closed
wants to merge 4 commits into from
Closed

Only run clang-tidy warning checks reported as errors #37698

wants to merge 4 commits into from

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Nov 17, 2022 •
edited
Loading

Treat clang-tidy warnings as errors by default.
#36885 on #36910 and #37482 and #37700

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman
Copy link
Member Author

jmagman commented Nov 17, 2022

google-readability-avoid-underscore-in-googletest-name at #37700

This was referenced Nov 17, 2022
Open
Open
@flutter-dashboard flutter-dashboard bot added the embedder Related to the embedder API label Nov 17, 2022
@jmagman jmagman mentioned this pull request Nov 17, 2022
Merged
8 tasks
@jmagman
Copy link
Member Author

jmagman commented Nov 17, 2022

This was just a scratchpad PR to find outstanding clang-tidy issues in CI.
#37700 has merged, closing in favor of #36885

@jmagman jmagman closed this Nov 17, 2022
@jmagman jmagman deleted the clang-tidy-star branch November 17, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
embedder Related to the embedder API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmagman