Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Memory leak when using PlatformView [IOS] #24714 #7919

Merged
merged 1 commit into from Feb 22, 2019

Conversation

Projects
None yet
4 participants
@ashawn
Copy link
Contributor

commented Feb 22, 2019

This is my investigation, thanks!
https://juejin.im/post/5c6e6dd5f265da2dcf62821f

@googlebot

This comment has been minimized.

Copy link

commented Feb 22, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Feb 22, 2019

@googlebot

This comment has been minimized.

Copy link

commented Feb 22, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ashawn

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2019

I signed it!

@googlebot

This comment has been minimized.

Copy link

commented Feb 22, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot

This comment has been minimized.

Copy link

commented Feb 22, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@amirh

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2019

Thanks!

@amirh

amirh approved these changes Feb 22, 2019

Copy link
Contributor

left a comment

LGTM

@amirh

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2019

@amirh

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2019

Will land on green

@amirh amirh merged commit 93f339f into flutter:master Feb 22, 2019

8 checks passed

WIP Ready for review
Details
build_and_test_host Task Summary
Details
build_and_test_host
Details
build_android Task Summary
Details
build_android
Details
cla/google All necessary CLAs are signed
format_and_dart_test Task Summary
Details
format_and_dart_test
Details

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2019

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2019

@chinmaygarde

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

Good catch. Thanks. I wonder if we should provide a custom GL proc resolver with instrumented variants of the OpenGL methods where we can do sanity checks like this. There may be more instances of such leaks. CC @jason-simmons

engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Feb 22, 2019

Roll engine 33bb91c..f80928a (4 commits) (#28353)
flutter/engine@33bb91c...f80928a

git log 33bb91c..f80928a --no-merges --oneline
f80928a Roll src/third_party/skia fdd15284affe..ee1c8a733e5b (15 commits) (flutter/engine#7924)
93f339f fix Memory leak when using PlatformView [IOS] #24714 (flutter/engine#7919)
2d33e77 Roll src/third_party/skia 969659dbb313..fdd15284affe (2 commits) (flutter/engine#7922)
6d4edf2 Roll src/third_party/skia 9431161ca973..969659dbb313 (3 commits) (flutter/engine#7921)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop
the roller if necessary.

KevinG2011 pushed a commit to pepper-ios/flutter that referenced this pull request May 9, 2019

Roll engine 33bb91c..f80928a (4 commits) (flutter#28353)
flutter/engine@33bb91c...f80928a

git log 33bb91c..f80928a --no-merges --oneline
f80928a Roll src/third_party/skia fdd15284affe..ee1c8a733e5b (15 commits) (flutter/engine#7924)
93f339f fix Memory leak when using PlatformView [IOS] flutter#24714 (flutter/engine#7919)
2d33e77 Roll src/third_party/skia 969659dbb313..fdd15284affe (2 commits) (flutter/engine#7922)
6d4edf2 Roll src/third_party/skia 9431161ca973..969659dbb313 (3 commits) (flutter/engine#7921)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop
the roller if necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.