Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the shell namespace to flutter. #8520

Merged
merged 2 commits into from Apr 10, 2019

Conversation

Projects
None yet
5 participants
@chinmaygarde
Copy link
Member

commented Apr 9, 2019

This patch contains no functional changes. Only the previous shell namespace is now flutter.

@cbracken
Copy link
Member

left a comment

lgtm_hanko

@cbracken

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Looks like the glfw embedder needs some love.

PR
@chinmaygarde

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

Fixed.

@chinmaygarde chinmaygarde merged commit 56052c7 into flutter:master Apr 10, 2019

15 checks passed

WIP Ready for review
Details
build_and_test_host Task Summary
Details
build_and_test_host
Details
build_and_test_host_profile Task Summary
Details
build_and_test_host_profile
Details
build_and_test_host_release Task Summary
Details
build_and_test_host_release
Details
build_android Task Summary
Details
build_android
Details
build_windows Task Summary
Details
build_windows
Details
cla/google All necessary CLAs are signed
format_and_dart_test Task Summary
Details
format_and_dart_test
Details
luci-engine
Details

@chinmaygarde chinmaygarde deleted the chinmaygarde:nomoshell branch Apr 10, 2019

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 10, 2019

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 10, 2019

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 10, 2019

engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Apr 10, 2019

Roll engine eec74e5c9231..905c571db50d (9 commits) (#30833)
flutter/engine@eec74e5...905c571

git log eec74e5c92313f01a28dfbeb78d96e81231edab7..905c571db50d5eb3b10eaa4d3c43c99321032223 --no-merges --oneline
905c571db Add windows host_debug_unopt build (flutter/engine#8515)
39e1d00f3 Remove redundant specification of the |flutter| namespace in the engine. (flutter/engine#8523)
56052c70a Rename the shell namespace to flutter. (flutter/engine#8520)
ca1d163d4 Support message loops whose tasks are executed concurrently. (flutter/engine#8419)
8ae84ec3d Roll src/third_party/skia de8362c6f212..10bf7020aa15 (5 commits) (flutter/engine#8522)
2dbd981d3 Roll src/third_party/dart 06ed3f598c..1490a90bc1 (8 commits)
527913268 Android Embedding PR27: Fix SurfaceView flicker in Fragment transactions (flutter/engine#8504)
86ab45cd5 Remove the unused EnableBlink flag. (flutter/engine#8518)
d5880a609 Roll src/third_party/skia b5d8c634f95b..de8362c6f212 (14 commits) (flutter/engine#8519)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.
@zanderso

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

This is a breaking change. Do you have compensating updates to Fuchsia's flutter_runner prepared?

liyuqian added a commit that referenced this pull request Apr 17, 2019

Rename flow namespace to flutter (#8615)
This follows our namespace change from shell to flutter: #8520.

KevinG2011 pushed a commit to pepper-ios/flutter that referenced this pull request May 9, 2019

Roll engine eec74e5c9231..905c571db50d (9 commits) (flutter#30833)
flutter/engine@eec74e5...905c571

git log eec74e5c92313f01a28dfbeb78d96e81231edab7..905c571db50d5eb3b10eaa4d3c43c99321032223 --no-merges --oneline
905c571db Add windows host_debug_unopt build (flutter/engine#8515)
39e1d00f3 Remove redundant specification of the |flutter| namespace in the engine. (flutter/engine#8523)
56052c70a Rename the shell namespace to flutter. (flutter/engine#8520)
ca1d163d4 Support message loops whose tasks are executed concurrently. (flutter/engine#8419)
8ae84ec3d Roll src/third_party/skia de8362c6f212..10bf7020aa15 (5 commits) (flutter/engine#8522)
2dbd981d3 Roll src/third_party/dart 06ed3f598c..1490a90bc1 (8 commits)
527913268 Android Embedding PR27: Fix SurfaceView flicker in Fragment transactions (flutter/engine#8504)
86ab45cd5 Remove the unused EnableBlink flag. (flutter/engine#8518)
d5880a609 Roll src/third_party/skia b5d8c634f95b..de8362c6f212 (14 commits) (flutter/engine#8519)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.