Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland const Rect/RRect #8695

Merged
merged 2 commits into from Apr 23, 2019
Merged

Reland const Rect/RRect #8695

merged 2 commits into from Apr 23, 2019

Conversation

@dnfield
Copy link
Member

@dnfield dnfield commented Apr 23, 2019

This relands #8565, including the fix for the comma in toString, and fixes the implementation of _scaleRadii (which now passes the test it was failing before). The diff between that and this is in 66a8672

Tests were added in #8692 from existing tests in flutter/flutter.

Copy link
Member

@cbracken cbracken left a comment

LGTM stamp from a Japanese personal seal

@dnfield dnfield merged commit 3e47b4b into flutter:master Apr 23, 2019
15 of 17 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Apr 23, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this issue Apr 23, 2019
@mdempsky
Copy link
Member

@mdempsky mdempsky commented Apr 24, 2019

The Cirrus build_and_test_host check has been failing since this CL landed: https://github.com/flutter/engine/commits/master

@dnfield
Copy link
Member Author

@dnfield dnfield commented Apr 24, 2019

Yes, it requires updates to the framework. We're working on that, but need to sort out a dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants