Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland const Rect/RRect #8695

Merged
merged 2 commits into from Apr 23, 2019

Conversation

Projects
None yet
4 participants
@dnfield
Copy link
Member

commented Apr 23, 2019

This relands #8565, including the fix for the comma in toString, and fixes the implementation of _scaleRadii (which now passes the test it was failing before). The diff between that and this is in 66a8672

Tests were added in #8692 from existing tests in flutter/flutter.

dnfield added some commits Apr 23, 2019

@googlebot googlebot added the cla: yes label Apr 23, 2019

@cbracken
Copy link
Member

left a comment

LGTM stamp from a Japanese personal seal

@dnfield dnfield merged commit 3e47b4b into flutter:master Apr 23, 2019

15 of 17 checks passed

build_and_test_host Task Summary
Details
build_and_test_host
Details
WIP Ready for review
Details
build_and_test_host_profile Task Summary
Details
build_and_test_host_profile
Details
build_and_test_host_release Task Summary
Details
build_and_test_host_release
Details
build_android Task Summary
Details
build_android
Details
build_windows_debug Task Summary
Details
build_windows_debug
Details
build_windows_debug_unopt Task Summary
Details
build_windows_debug_unopt
Details
cla/google All necessary CLAs are signed
format_and_dart_test Task Summary
Details
format_and_dart_test
Details
luci-engine
Details

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 23, 2019

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 23, 2019

@mdempsky

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

The Cirrus build_and_test_host check has been failing since this CL landed: https://github.com/flutter/engine/commits/master

@dnfield

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

Yes, it requires updates to the framework. We're working on that, but need to sort out a dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.