Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap with StreamBuilder should place caret at Type. #3270

Closed
feinstein opened this issue Mar 9, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@feinstein
Copy link

commented Mar 9, 2019

The shortcut wrap with StreamBuilder generates a StreamBuilder<Object>. It would be nice to have the caret automatically at <Object> so we could fill in the type.

@pq

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2019

Thanks for the input @feinstein. This looks like an assist that's coming from the Dart Analysis Server. @bwilkerson, @scheglov: I'm guessing this would just be a matter of updating the assist to use a linked edit? (If it's not already?)

@pq pq added this to the Backlog milestone Mar 10, 2019

@scheglov scheglov self-assigned this Mar 14, 2019

@scheglov

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

@scheglov scheglov closed this Mar 14, 2019

@feinstein

This comment has been minimized.

Copy link
Author

commented Mar 14, 2019

That was quick :)

dart-bot pushed a commit to dart-lang/sdk that referenced this issue Mar 14, 2019

Issue 3270. Put StreamBuilder's type argument into linked edit.
R=brianwilkerson@google.com

Bug: flutter/flutter-intellij#3270
Change-Id: I8e4d10029c7eab1f9edeaeed97ac4d54a74d81cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96865
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.