From dabfc9af0dedc77c9eb626182890c7a04a2296ca Mon Sep 17 00:00:00 2001 From: Helin Shiah Date: Tue, 30 Sep 2025 11:19:52 -0700 Subject: [PATCH 1/2] Move log level setup to initializer --- src/io/flutter/FlutterInitializer.java | 5 +++++ src/io/flutter/logging/PluginLogger.java | 7 +------ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/io/flutter/FlutterInitializer.java b/src/io/flutter/FlutterInitializer.java index 1d7a2c628..ab0481eda 100644 --- a/src/io/flutter/FlutterInitializer.java +++ b/src/io/flutter/FlutterInitializer.java @@ -39,6 +39,7 @@ import io.flutter.devtools.RemainingDevToolsViewFactory; import io.flutter.editor.FlutterSaveActionsManager; import io.flutter.logging.FlutterConsoleLogManager; +import io.flutter.logging.PluginLogger; import io.flutter.module.FlutterModuleBuilder; import io.flutter.pub.PubRoot; import io.flutter.pub.PubRoots; @@ -142,6 +143,10 @@ public void executeProjectStartup(@NotNull Project project) { edtInitialization(finalHasFlutterModule, project); }) .submit(AppExecutorUtil.getAppExecutorService()); + + // This sets the correct log level and listens for future changes. + PluginLogger.updateLogLevel(); + FlutterSettings.getInstance().addListener(PluginLogger::updateLogLevel); } /*** diff --git a/src/io/flutter/logging/PluginLogger.java b/src/io/flutter/logging/PluginLogger.java index c192445b1..116cf9768 100644 --- a/src/io/flutter/logging/PluginLogger.java +++ b/src/io/flutter/logging/PluginLogger.java @@ -42,14 +42,9 @@ public class PluginLogger { static { rootLogger.addHandler(fileHandler); - // This check prevents trying to access settings in test context. - if (ApplicationManager.getApplication() != null) { - updateLogLevel(); - FlutterSettings.getInstance().addListener(PluginLogger::updateLogLevel); - } } - private static void updateLogLevel() { + public static void updateLogLevel() { final Logger rootLoggerInstance = Logger.getInstance("io.flutter"); rootLoggerInstance.setLevel(FlutterSettings.getInstance().isVerboseLogging() ? LogLevel.ALL : LogLevel.INFO); } From e82770f57a0e835eab88e241f64aa74633832946 Mon Sep 17 00:00:00 2001 From: Helin Shiah Date: Tue, 30 Sep 2025 11:21:15 -0700 Subject: [PATCH 2/2] Move log setup to beginning --- src/io/flutter/FlutterInitializer.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/io/flutter/FlutterInitializer.java b/src/io/flutter/FlutterInitializer.java index ab0481eda..0e9302e4b 100644 --- a/src/io/flutter/FlutterInitializer.java +++ b/src/io/flutter/FlutterInitializer.java @@ -83,6 +83,10 @@ public class FlutterInitializer extends FlutterProjectActivity { @Override public void executeProjectStartup(@NotNull Project project) { + // This sets the correct log level and listens for future changes. + PluginLogger.updateLogLevel(); + FlutterSettings.getInstance().addListener(PluginLogger::updateLogLevel); + log().info("Executing Flutter plugin startup for project: " + project.getName()); // Disable the 'Migrate Project to Gradle' notification. FlutterUtils.disableGradleProjectMigrationNotification(project); @@ -143,10 +147,6 @@ public void executeProjectStartup(@NotNull Project project) { edtInitialization(finalHasFlutterModule, project); }) .submit(AppExecutorUtil.getAppExecutorService()); - - // This sets the correct log level and listens for future changes. - PluginLogger.updateLogLevel(); - FlutterSettings.getInstance().addListener(PluginLogger::updateLogLevel); } /***