From f55e173f811631e538ad6e0da6a94acfde5ada3d Mon Sep 17 00:00:00 2001 From: Helin Shiah Date: Thu, 23 Oct 2025 18:07:24 -0700 Subject: [PATCH 1/3] Add ignored problems file --- build.gradle.kts | 9 ++++++--- third_party/lib/weberknecht-0.1.5.jar | 0 verify-ignore-problems.txt | 14 ++++++++++++++ 3 files changed, 20 insertions(+), 3 deletions(-) create mode 100644 third_party/lib/weberknecht-0.1.5.jar create mode 100644 verify-ignore-problems.txt diff --git a/build.gradle.kts b/build.gradle.kts index a0b94ae15d..bf0b1a8998 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -274,11 +274,11 @@ intellijPlatform { // TODO(team) Ideally all of the following FailureLevels should be enabled: // https://github.com/flutter/flutter-intellij/issues/8361 VerifyPluginTask.FailureLevel.COMPATIBILITY_WARNINGS, -// VerifyPluginTask.FailureLevel.COMPATIBILITY_PROBLEMS, + VerifyPluginTask.FailureLevel.COMPATIBILITY_PROBLEMS, // VerifyPluginTask.FailureLevel.DEPRECATED_API_USAGES, // https://github.com/flutter/flutter-intellij/issues/7718 // VerifyPluginTask.FailureLevel.SCHEDULED_FOR_REMOVAL_API_USAGES, // `BadgeIcon`: -// VerifyPluginTask.FailureLevel.EXPERIMENTAL_API_USAGES, + VerifyPluginTask.FailureLevel.EXPERIMENTAL_API_USAGES, // VerifyPluginTask.FailureLevel.INTERNAL_API_USAGES, // VerifyPluginTask.FailureLevel.OVERRIDE_ONLY_API_USAGES, VerifyPluginTask.FailureLevel.NON_EXTENDABLE_API_USAGES, @@ -289,9 +289,12 @@ intellijPlatform { ) verificationReportsFormats = VerifyPluginTask.VerificationReportsFormats.ALL subsystemsToCheck = VerifyPluginTask.Subsystems.ALL + ignoredProblemsFile.set(project.file("verify-ignore-problems.txt")) + println("ignored problems file: ${ignoredProblemsFile.get().asFile.absolutePath}") ides { - recommended() +// recommended() + create(IntelliJPlatformType.AndroidStudio, "2025.2.2.1") } } } diff --git a/third_party/lib/weberknecht-0.1.5.jar b/third_party/lib/weberknecht-0.1.5.jar new file mode 100644 index 0000000000..e69de29bb2 diff --git a/verify-ignore-problems.txt b/verify-ignore-problems.txt new file mode 100644 index 0000000000..072ddddc3e --- /dev/null +++ b/verify-ignore-problems.txt @@ -0,0 +1,14 @@ +# This is a known false positive. The de.roderick.weberknecht package is provided +# by the Dart plugin at runtime, but the verifier's static analysis of +# class loader visibility is flawed in this case. +::de.roderick.weberknecht.WebSocketException.* + +::Experimental API class com.intellij.ui.BadgeIcon.* +::Experimental API constructor com.intellij.ui.BadgeIcon.* + +Experimental API constructor com.intellij.ui.BadgeIcon.* +Experimental API constructor com.intellij.ui.BadgeIcon.* + +com.intellij.ui.BadgeIcon + +.* \ No newline at end of file From 777b49ccdd152083e0a14be44edae25aee291a0f Mon Sep 17 00:00:00 2001 From: Helin Shiah Date: Mon, 27 Oct 2025 19:52:37 +0000 Subject: [PATCH 2/3] Use correct pattern for compatibility problem --- build.gradle.kts | 8 +++----- verify-ignore-problems.txt | 12 ++---------- 2 files changed, 5 insertions(+), 15 deletions(-) diff --git a/build.gradle.kts b/build.gradle.kts index bf0b1a8998..6a14df2703 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -278,7 +278,7 @@ intellijPlatform { // VerifyPluginTask.FailureLevel.DEPRECATED_API_USAGES, // https://github.com/flutter/flutter-intellij/issues/7718 // VerifyPluginTask.FailureLevel.SCHEDULED_FOR_REMOVAL_API_USAGES, // `BadgeIcon`: - VerifyPluginTask.FailureLevel.EXPERIMENTAL_API_USAGES, +// VerifyPluginTask.FailureLevel.EXPERIMENTAL_API_USAGES, // VerifyPluginTask.FailureLevel.INTERNAL_API_USAGES, // VerifyPluginTask.FailureLevel.OVERRIDE_ONLY_API_USAGES, VerifyPluginTask.FailureLevel.NON_EXTENDABLE_API_USAGES, @@ -290,11 +290,9 @@ intellijPlatform { verificationReportsFormats = VerifyPluginTask.VerificationReportsFormats.ALL subsystemsToCheck = VerifyPluginTask.Subsystems.ALL ignoredProblemsFile.set(project.file("verify-ignore-problems.txt")) - println("ignored problems file: ${ignoredProblemsFile.get().asFile.absolutePath}") ides { -// recommended() - create(IntelliJPlatformType.AndroidStudio, "2025.2.2.1") + recommended() } } } @@ -419,4 +417,4 @@ tasks.withType().configureEach { // The context here is unambiguously the task itself. exclude("jxbrowser/jxbrowser.properties") } -} \ No newline at end of file +} diff --git a/verify-ignore-problems.txt b/verify-ignore-problems.txt index 072ddddc3e..7f133435e0 100644 --- a/verify-ignore-problems.txt +++ b/verify-ignore-problems.txt @@ -1,14 +1,6 @@ # This is a known false positive. The de.roderick.weberknecht package is provided # by the Dart plugin at runtime, but the verifier's static analysis of # class loader visibility is flawed in this case. -::de.roderick.weberknecht.WebSocketException.* +# See more context in https://github.com/flutter/flutter-intellij/pull/8590 +::Package 'de.roderick' is not found.* -::Experimental API class com.intellij.ui.BadgeIcon.* -::Experimental API constructor com.intellij.ui.BadgeIcon.* - -Experimental API constructor com.intellij.ui.BadgeIcon.* -Experimental API constructor com.intellij.ui.BadgeIcon.* - -com.intellij.ui.BadgeIcon - -.* \ No newline at end of file From 7926b9ac9ead8bfa9ba0f0d1f953c763f4c7b373 Mon Sep 17 00:00:00 2001 From: Helin Shiah Date: Mon, 27 Oct 2025 19:53:12 +0000 Subject: [PATCH 3/3] Re-add newline --- build.gradle.kts | 1 + 1 file changed, 1 insertion(+) diff --git a/build.gradle.kts b/build.gradle.kts index 6a14df2703..9dc026f497 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -418,3 +418,4 @@ tasks.withType().configureEach { exclude("jxbrowser/jxbrowser.properties") } } +