From 252da730557d80039c4bac236350eef9ab11ff71 Mon Sep 17 00:00:00 2001 From: Bartek Pacia Date: Tue, 5 Dec 2023 00:31:55 +0100 Subject: [PATCH] annotate usages of `SemanticsUpdateBuilderNew` with `ignore: deprecated_member_use` --- packages/flutter/lib/src/semantics/binding.dart | 4 ++++ packages/flutter/lib/src/semantics/semantics.dart | 3 +++ packages/flutter/test/semantics/semantics_update_test.dart | 3 +++ packages/flutter_test/test/view_test.dart | 1 + 4 files changed, 11 insertions(+) diff --git a/packages/flutter/lib/src/semantics/binding.dart b/packages/flutter/lib/src/semantics/binding.dart index fcfe9fc8284d33..5f264f12b788b2 100644 --- a/packages/flutter/lib/src/semantics/binding.dart +++ b/packages/flutter/lib/src/semantics/binding.dart @@ -2,6 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// ignore: deprecated_member_use import 'dart:ui' as ui show AccessibilityFeatures, SemanticsActionEvent, SemanticsUpdateBuilderNew; import 'package:flutter/foundation.dart'; @@ -9,6 +10,7 @@ import 'package:flutter/services.dart'; import 'debug.dart'; +// ignore: deprecated_member_use export 'dart:ui' show AccessibilityFeatures, SemanticsActionEvent, SemanticsUpdateBuilderNew; /// The glue between the semantics layer and the Flutter engine. @@ -160,7 +162,9 @@ mixin SemanticsBinding on BindingBase { /// /// This method is used by the [SemanticsOwner] to create builder for all its /// semantics updates. + // ignore: deprecated_member_use ui.SemanticsUpdateBuilderNew createSemanticsUpdateBuilder() { + // ignore: deprecated_member_use return ui.SemanticsUpdateBuilderNew(); } diff --git a/packages/flutter/lib/src/semantics/semantics.dart b/packages/flutter/lib/src/semantics/semantics.dart index 6f9adb26901511..7a0b29b4e126ff 100644 --- a/packages/flutter/lib/src/semantics/semantics.dart +++ b/packages/flutter/lib/src/semantics/semantics.dart @@ -3,6 +3,7 @@ // found in the LICENSE file. import 'dart:math' as math; +// ignore: deprecated_member_use import 'dart:ui' show Offset, Rect, SemanticsAction, SemanticsFlag, SemanticsUpdate, SemanticsUpdateBuilderNew, StringAttribute, TextDirection; import 'package:collection/collection.dart'; @@ -2749,6 +2750,7 @@ class SemanticsNode with DiagnosticableTreeMixin { static final Int32List _kEmptyCustomSemanticsActionsList = Int32List(0); static final Float64List _kIdentityTransform = _initIdentityTransform(); + // ignore: deprecated_member_use void _addToUpdate(SemanticsUpdateBuilderNew builder, Set customSemanticsActionIdsUpdate) { assert(_dirty); final SemanticsData data = getSemanticsData(); @@ -3442,6 +3444,7 @@ class SemanticsOwner extends ChangeNotifier { } } visitedNodes.sort((SemanticsNode a, SemanticsNode b) => a.depth - b.depth); + // ignore: deprecated_member_use final SemanticsUpdateBuilderNew builder = SemanticsBinding.instance.createSemanticsUpdateBuilder(); for (final SemanticsNode node in visitedNodes) { assert(node.parent?._dirty != true); // could be null (no parent) or false (not dirty) diff --git a/packages/flutter/test/semantics/semantics_update_test.dart b/packages/flutter/test/semantics/semantics_update_test.dart index caa213b77c4aad..57bf081e03585b 100644 --- a/packages/flutter/test/semantics/semantics_update_test.dart +++ b/packages/flutter/test/semantics/semantics_update_test.dart @@ -172,12 +172,15 @@ void main() { class SemanticsUpdateTestBinding extends AutomatedTestWidgetsFlutterBinding { @override + // ignore: deprecated_member_use ui.SemanticsUpdateBuilderNew createSemanticsUpdateBuilder() { return SemanticsUpdateBuilderSpy(); } } +// ignore: deprecated_member_use class SemanticsUpdateBuilderSpy extends Fake implements ui.SemanticsUpdateBuilderNew { + // ignore: deprecated_member_use final SemanticsUpdateBuilderNew _builder = ui.SemanticsUpdateBuilderNew(); static Map observations = {}; diff --git a/packages/flutter_test/test/view_test.dart b/packages/flutter_test/test/view_test.dart index 36bc0704707dcd..4d29996acdece8 100644 --- a/packages/flutter_test/test/view_test.dart +++ b/packages/flutter_test/test/view_test.dart @@ -313,6 +313,7 @@ void main() { }); testWidgets('updateSemantics is passed through to backing FlutterView', (WidgetTester tester) async { + // ignore: deprecated_member_use final SemanticsUpdate expectedUpdate = SemanticsUpdateBuilderNew().build(); final _FakeFlutterView backingView = _FakeFlutterView(); final TestFlutterView view = TestFlutterView(