From 5a5b58a99326e2ba4c4e754430dd4e47f638221a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Sharma?= <737941+loic-sharma@users.noreply.github.com> Date: Tue, 27 Jun 2023 14:07:14 -0700 Subject: [PATCH] Automatically migrate ClipboardData.text to non-null (#129567) https://github.com/flutter/flutter/pull/122446 was a breaking change in Flutter 3.10 that made the `ClipboardData` constructor's `text` argument a required non-nullable argument. This leverages `dart fix`'s new automatic migration to, well, automatically migrate affected users. Manual migration docs: https://docs.flutter.dev/release/breaking-changes/clipboard-data-required Follow-up to https://github.com/flutter/flutter/pull/122446 Part of https://github.com/flutter/flutter/issues/121976 --- packages/flutter/lib/fix_data/fix_services.yaml | 14 ++++++++++++++ packages/flutter/test_fixes/services/services.dart | 4 ++++ .../test_fixes/services/services.dart.expect | 4 ++++ 3 files changed, 22 insertions(+) diff --git a/packages/flutter/lib/fix_data/fix_services.yaml b/packages/flutter/lib/fix_data/fix_services.yaml index b409e6c7564a..35c8a238d191 100644 --- a/packages/flutter/lib/fix_data/fix_services.yaml +++ b/packages/flutter/lib/fix_data/fix_services.yaml @@ -18,6 +18,20 @@ # * Fixes in this file are from the Services library. * version: 1 transforms: + # Changes made in https://github.com/flutter/flutter/pull/122446 + - title: "Migrate to empty 'text' string" + date: 2023-06-26 + element: + uris: [ 'services.dart' ] + constructor: '' + inClass: 'ClipboardData' + changes: + - kind: 'changeParameterType' + name: 'text' + nullability: 'non_null' + argumentValue: + expression: "''" + # Changes made in https://github.com/flutter/flutter/pull/60320 - title: "Migrate to 'viewId'" date: 2020-07-05 diff --git a/packages/flutter/test_fixes/services/services.dart b/packages/flutter/test_fixes/services/services.dart index 6e171fc8f57e..bbb5250f96f5 100644 --- a/packages/flutter/test_fixes/services/services.dart +++ b/packages/flutter/test_fixes/services/services.dart @@ -5,6 +5,10 @@ import 'package:flutter/services.dart'; void main() { + // Changes made in https://github.com/flutter/flutter/pull/122446 + final clipboardData1 = ClipboardData(); + final clipboardData2 = ClipboardData(text: null); + // Changes made in https://github.com/flutter/flutter/pull/60320 final SurfaceAndroidViewController surfaceController = SurfaceAndroidViewController( viewId: 10, diff --git a/packages/flutter/test_fixes/services/services.dart.expect b/packages/flutter/test_fixes/services/services.dart.expect index 7a69dc54c7f5..469d50056c81 100644 --- a/packages/flutter/test_fixes/services/services.dart.expect +++ b/packages/flutter/test_fixes/services/services.dart.expect @@ -5,6 +5,10 @@ import 'package:flutter/services.dart'; void main() { + // Changes made in https://github.com/flutter/flutter/pull/122446 + final clipboardData1 = ClipboardData(text: ''); + final clipboardData2 = ClipboardData(text: ''); + // Changes made in https://github.com/flutter/flutter/pull/60320 final SurfaceAndroidViewController surfaceController = SurfaceAndroidViewController( viewId: 10,