From eb742ea8fe2aa6200dc0b9a9a43054fe80b9a343 Mon Sep 17 00:00:00 2001 From: Kaushik Iska Date: Thu, 1 Jul 2021 20:34:48 -0400 Subject: [PATCH] Specify rasterFinishWallTime (#85731) This is to transition `rasterFinishWallTime` to a required field in `dart:ui`. --- packages/flutter/test/scheduler/scheduler_test.dart | 1 + packages/flutter_test/test/frame_timing_summarizer_test.dart | 3 +++ 2 files changed, 4 insertions(+) diff --git a/packages/flutter/test/scheduler/scheduler_test.dart b/packages/flutter/test/scheduler/scheduler_test.dart index a5913cfa98ca..ec1b90545313 100644 --- a/packages/flutter/test/scheduler/scheduler_test.dart +++ b/packages/flutter/test/scheduler/scheduler_test.dart @@ -143,6 +143,7 @@ void main() { buildFinish: 15000, rasterStart: 16000, rasterFinish: 20000, + rasterFinishWallTime: 20010, frameNumber: 1991 )]); diff --git a/packages/flutter_test/test/frame_timing_summarizer_test.dart b/packages/flutter_test/test/frame_timing_summarizer_test.dart index ff3ee8fb4cd5..d58548a37f04 100644 --- a/packages/flutter_test/test/frame_timing_summarizer_test.dart +++ b/packages/flutter_test/test/frame_timing_summarizer_test.dart @@ -29,6 +29,9 @@ void main() { buildFinish: buildTimes[i], rasterStart: 500, rasterFinish: rasterTimes[i], + // Wall time should not be used in any profiling metrics. + // It is primarily to correlate with external tools' measurement. + rasterFinishWallTime: 0, ), ];