Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 1P plugin platform view selection #108106

Closed
2 tasks done
stuartmorgan opened this issue Jul 21, 2022 · 8 comments · Fixed by flutter/plugins#6864
Closed
2 tasks done

Update 1P plugin platform view selection #108106

stuartmorgan opened this issue Jul 21, 2022 · 8 comments · Fixed by flutter/plugins#6864
Assignees
Labels
p: maps Google Maps plugin p: webview The WebView plugin P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. platform-android Android applications specifically

Comments

@stuartmorgan
Copy link
Contributor

stuartmorgan commented Jul 21, 2022

Currently both webview_flutter and google_maps_flutter have APIs and README documentation about selecting the Android platform view mode, but as of Flutter 3.0 those options don't actually do anything, so the docs are wrong. We should update them:

  • Maps:
  • Webview:
    • Either:
      • Add a new way to select HC (we don't want to just "fix" the old selection because we want anyone opting out of TLHC for webview to be making a new explicit decision to do it, rather than downgrade what would have been a common option for people to want pre-3.0), or
      • Fully deprecate the switch, and document that it's a no-op. (We don't currently have a compelling case for people to use HC for webview that I know of other than the fallback issue described in initSurfaceAndroidView uses Virtual Display as fallback mode #107313, which we should just fix.)
    • Update the README to describe the Flutter 3.0+ behavior
@stuartmorgan stuartmorgan added platform-android Android applications specifically plugin p: maps Google Maps plugin p: webview The WebView plugin P1 High-priority issues at the top of the work list labels Jul 21, 2022
@stuartmorgan stuartmorgan self-assigned this Jul 21, 2022
@bparrishMines
Copy link
Contributor

bparrishMines commented Jul 21, 2022

The switch in WebView should be fixed once flutter/engine#34800 makes it to stable.

Edit: And by switch, I mean the need to switch to HC.

@xster
Copy link
Member

xster commented Jul 21, 2022

For archival purposes, can you just describe what the behavior is at this moment?

@stuartmorgan
Copy link
Contributor Author

For archival purposes, can you just describe what the behavior is at this moment?

Currently, for Flutter 3.0+:

  • Maps has received no changes yet, so no matter which mode you think you are selecting, you actually get TLHC (or, for Android versions below SDK 23, the automatic fallback to VD)
  • The same is mostly true of webview; the exception is the very recent fix for transparency, which will cause webview to use HC if the background is transparent (and the pre-2.0 mode the client had selected was HC, but that's the default for webview 4.x).

@xster
Copy link
Member

xster commented Jul 21, 2022

Understood, thank you

@stuartmorgan
Copy link
Contributor Author

Per #104889 (comment) we should keep (and fix) a Hybrid Composition mode option.

@feinstein
Copy link
Contributor

Do the PlatformView docs at the Flutter website also need to be updated? I see Hybrid Composition being mentioned there, but not TLHC.

@stuartmorgan
Copy link
Contributor Author

That's #112208

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2023
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p: maps Google Maps plugin p: webview The WebView plugin P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. platform-android Android applications specifically
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants