[CP] Null exception fix

[justinmc]

issue_link

#111095

Commit Hash

d728539

Target

stable

pr_link

#113553

Impacted Users

Android apps with text editing

Impact Description

A null exception is thrown for users of text editing on Android.

Workaround

1. Patch the Flutter framework directly with this one line fix: https://github.com/flutter/flutter/pull/107683/files#diff-f5f93c879cef9a102adbf148583de9f3d9a05f9678fdcad7bde106f62200bb34

or

2. Upgrade to master or any release that includes the fix PR (Remove exclamation marks #107683).

Risk

medium

Test Coverage

yes

Validation Steps

If this test passes, then the fix works:

flutter/packages/flutter/test/widgets/editable_text_test.dart

Line 425 in f02cfd4

testWidgets('onAppPrivateCommand does not throw', (WidgetTester tester) async {

[itsjustkevin]

@HansMuller could you review this cherry pick please?

[aprzedecki]

Would be great to include it in 3.4.0 release.

[itsjustkevin]

@LongCatIsLooong could you take a look at this cherry-pick request?

[absar]

Can it be prioritized, it's regressing allover

[HansMuller]

LGTM

[justinmc]

Can this be closed now that the PR is merged or is the process to wait? #113553

[CaseyHillers]

Can this be closed now that the PR is merged or is the process to wait? #113553

We wait until it has officially shipped to users. I expect us to remain on schedule, and ship this tomorrow (11/02) at 10 AM PST. Afterwards, I'll close the CP requests that were merged.

The reason we do this is occasionally a breakage is revealed in CI, and we have to revert a CP.

[CaseyHillers]

This was released in 3.3.7

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.