Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] Calculate per-glyph (instead of per typeface) bounds when adding glyphs to atlas. #116366

Closed
chinmaygarde opened this issue Dec 1, 2022 · 2 comments
Closed

[Impeller] Calculate per-glyph (instead of per typeface) bounds when adding glyphs to atlas. #116366

chinmaygarde opened this issue Dec 1, 2022 · 2 comments
Assignees
@bdero
Labels
e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels.

Comments

@chinmaygarde
Copy link
Member

The current strategy wastes a whole bunch of space in the atlas. Rework atlas generation to take per glyph metrics.

Related to flutter/engine#37998 which exacerbates this wastage but this issue was always present.
@chinmaygarde chinmaygarde added e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. labels Dec 1, 2022
@chinmaygarde chinmaygarde mentioned this issue Dec 1, 2022
Merged
@chinmaygarde
Copy link
Member Author

Fixed in flutter/engine#37998 by @bdero

@github-actions
Copy link

github-actions bot commented Mar 5, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bdero bdero

Labels
e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels.
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chinmaygarde @bdero