Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We don't recognize Hebrew #11907

Closed
Hixie opened this issue Sep 1, 2017 · 5 comments
Closed

We don't recognize Hebrew #11907

Hixie opened this issue Sep 1, 2017 · 5 comments
Assignees
Labels
a: internationalization Supporting other languages or locales. (aka i18n) framework flutter/packages/flutter repository. See also f: labels. waiting for PR to land (fixed) A fix is in flight

Comments

@Hixie
Copy link
Contributor

Hixie commented Sep 1, 2017

When you pick the Hebrew locale on Android we don't switch to Hebrew.

@Hixie Hixie added framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) labels Sep 1, 2017
@Hixie Hixie added this to the 3: Current Milestone milestone Sep 1, 2017
@Hixie Hixie added this to Localisation in Internationalization Sep 8, 2017
@HansMuller
Copy link
Contributor

Android (Java really) uses the old locale code for hebrew "iw", see http://bugs.java.com/bugdatabase/view_bug.do?bug_id=4140555

The material translations should work for both.

@Hixie
Copy link
Contributor Author

Hixie commented Sep 12, 2017

We should automatically convert iw to he (Hebrew), ji to yi (Yiddish), and in to id (Indonesian). They were all replaced in 1989. Not sure exactly where to put this conversion. Maybe in Locale itself? Have languageCode (and operator==) return (or use) the value with this mapping applied, and have a new property originalLanguageCode that returns the one that was provided to the constructor?

@Hixie
Copy link
Contributor Author

Hixie commented Sep 12, 2017

The code that does this would be implementing https://www.ietf.org/rfc/rfc1766.txt, which is why I think it belongs at that low level.

@HansMuller
Copy link
Contributor

We do recognize Hebrew on Android as of #12021 however I'll leave this issue open until we've moved the fix to the Locale object itself.

@github-actions
Copy link

github-actions bot commented Sep 4, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: internationalization Supporting other languages or locales. (aka i18n) framework flutter/packages/flutter repository. See also f: labels. waiting for PR to land (fixed) A fix is in flight
Projects
Development

No branches or pull requests

2 participants