Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add support for Crashlytics #14765

Closed
dotdoom opened this issue Feb 18, 2018 · 35 comments
Closed

Please add support for Crashlytics #14765

dotdoom opened this issue Feb 18, 2018 · 35 comments

Comments

@dotdoom
Copy link

@dotdoom dotdoom commented Feb 18, 2018

In #9592 there's a request for adding Crashlytics, but it was blocked by an absence of crash reporting support in Flutter. Now that there are ways to intercept errors, it should be possible to add Crashlytics / Firebase error reporting.

@xster
Copy link
Member

@xster xster commented Feb 23, 2018

cc @collinjackson might have updates.

I'd like to use it for the gallery as well #4070

@hocinehamdi
Copy link

@hocinehamdi hocinehamdi commented Feb 27, 2018

It will be perfect to have first class dart crash reporting tool

@pulyaevskiy
Copy link
Contributor

@pulyaevskiy pulyaevskiy commented Mar 3, 2018

Very much interested in this as well. It would be great to have crash reports in Firebase console for both Dart and native side errors.

@PareshMayani
Copy link

@PareshMayani PareshMayani commented Mar 6, 2018

Indeed it's much needed thing! Looking forward for either crashlytics or Firebase integration

@ekbiker
Copy link

@ekbiker ekbiker commented Apr 4, 2018

This would be awesome.

@wahibhaq
Copy link

@wahibhaq wahibhaq commented Apr 27, 2018

I had to use Crashlytics and ended up on this page. It would be really nice to have it for flutter 🙏

@jpgilchrist
Copy link

@jpgilchrist jpgilchrist commented May 9, 2018

Given the latest updates in Google I/O, this seems like a pretty obvious thing to include. firebase_analytics plugin already provides the google analytics portion. However, the crashlytics isn't available, which is a major part of the firebase offerings.

@rodydavis
Copy link
Contributor

@rodydavis rodydavis commented May 10, 2018

Definitely would love this plugin!

@eseidelGoogle
Copy link
Contributor

@eseidelGoogle eseidelGoogle commented May 15, 2018

Looks like this is now our top most requested issue. :D

@yjbanov looked at this briefly last year and determined it would require some changes to Crashlytics itself to add Dart support. We'll reach out to the crashlytics team again and see how things have changed in the intervening months. This seems like a very reasonable request and should definitely be doable. Just a question of when. :)

@eseidelGoogle
Copy link
Contributor

@eseidelGoogle eseidelGoogle commented Jun 6, 2018

I spoke with @collinjackson a while back and it sounded like they or @kroikie or @bparrishMines were interested in taking this on. I believe mostly this requires some coordination with the crashlytics team. FWIW this is still our top-most requested bug. :)

@Hixie Hixie added this to the Stretch Goals milestone Jun 19, 2018
@ChristBKK
Copy link

@ChristBKK ChristBKK commented Jul 13, 2018

+1 for this one

@gonzalonm
Copy link

@gonzalonm gonzalonm commented Jul 26, 2018

Any news on this? I would really appreciate to have Crashlytics integration on Flutter!

@vithanichandresh
Copy link

@vithanichandresh vithanichandresh commented Jul 31, 2018

+1

1 similar comment
@jjbeto
Copy link

@jjbeto jjbeto commented Aug 9, 2018

+1

@jaumard
Copy link
Contributor

@jaumard jaumard commented Aug 16, 2018

Any news on this ? Did the plugin start ? I want to take a look see if I can help. Would be nice to use Crashlytics (and other reporting tool of Fabric) with Flutter as we're using a lot of functionality of Fabric into our native app already.

@karantanwar
Copy link

@karantanwar karantanwar commented Aug 17, 2018

it would be great to have this plugin

@jaumard
Copy link
Contributor

@jaumard jaumard commented Aug 21, 2018

Hello everyone, I've just implemented a plugin for Crashlytics integration for iOS and Android. Reports look like this:
capture d ecran 2018-08-21 a 10 11 13

It's not perfect but at least it's a start :) it can also allow you to set custom logs and informations (general and user info) from Dart.

Let me know what you think of it guys.

One limitation is that as the report is with Crashlytics SDK, it reports manual exceptions as Non Fatal, one way to bypass that would be to make the app crash, I've opened an issue on my repo to collect thoughts about this.

Here is the repo https://github.com/kiwi-bop/flutter_crashlytics and the pub packages https://pub.dartlang.org/packages/flutter_crashlytics

@nstrelow
Copy link

@nstrelow nstrelow commented Oct 9, 2018

It would be awesome to get official support for Crashlytics!

@neiljaywarner
Copy link

@neiljaywarner neiljaywarner commented Jan 29, 2019

@Hixie @eseidelGoogle @kroikie Can we please get a recipe on flutter.io that does not require a sentry.io account?

Ideally with a link to a section somehow detailing pros and cons compared to the first-class support that is a work in progress.

It looks like crashlytics support is "good enough" right now but improving, but i can't figure out yet how to clarify that, and the need is increasing. thank you

@Hixie
Copy link
Member

@Hixie Hixie commented Jan 29, 2019

@neiljaywarner are you asking for sample code that doesn't involve sentry.io?

@neiljaywarner
Copy link

@neiljaywarner neiljaywarner commented Jan 29, 2019

Yes please
The path of least friction to crashlytics as of feb2019 would help a lot of people I think

@Hixie Hixie removed this from the February 2019 milestone Feb 6, 2019
@Hixie Hixie added this to the Overdue milestone Feb 6, 2019
@kroikie kroikie removed this from the Overdue milestone Feb 6, 2019
@kroikie kroikie added this to the March 2019 milestone Feb 6, 2019
@hummatli
Copy link

@hummatli hummatli commented Feb 25, 2019

I like the idea! Google must do this!

@Hixie Hixie removed this from the March 2019 milestone Mar 6, 2019
@Hixie Hixie added this to the Overdue milestone Mar 6, 2019
@GreenAppers
Copy link

@GreenAppers GreenAppers commented Mar 7, 2019

Debugging my app's SIGSEGV in libflutter.so, I've been working to extend flutter_crashlytics to include CrashlyticsNdk and thereby actually catch SIGSEGV and report it.

However I have not been able to successfully symbolicate the crashes.

The problem seems to be that "flutter build" produces no artifacts with debugging symbols. The files under build/app/intermediates/transforms/stripDebugSymbol and build/app/intermediates/transforms/mergeJniLibs are nearly same size, and it seems that none of them contain debugging symbols.

We need to modify "flutter build" to produce some libflutter.so with debugging symbols. Then configure build.gradle like:

crashlytics {
enableNdk true
androidNdkOut "../../build/app/intermediates/transforms/mergeJniLibs/release/0/lib"
androidNdkLibsOut "../../build/app/intermediates/transforms/stripDebugSymbol/release/0/lib"
}

And upload with ./gradlew crashlyticsUploadSymbolsRelease.

Many, if not all, flutter_crashlytics users need this. As I've learned, writing a pure Dart app will not protect you from native crashes. Without CrashlyticsNdk we can't learn of users' SIGSEGV, and without changes to "flutter build" we can't symbolicate them.

@eseidelGoogle
Copy link
Contributor

@eseidelGoogle eseidelGoogle commented Mar 7, 2019

https://github.com/flutter/flutter/wiki/Crashes includes instructions on how to get flutter.jar and flutter.framework files with symbols in them. Let me know if that doesn't help?

@GreenAppers
Copy link

@GreenAppers GreenAppers commented Mar 8, 2019

Thanks for this and the quick response. This is exactly what I needed.

It would be nice to find an easier solution to getting these uploaded to Crashlytics.

@GreenAppers
Copy link

@GreenAppers GreenAppers commented Mar 8, 2019

I would appreciate any comments on PR towards symbolicating native crashes in Flutter apps with Crashlytics: https://github.com/kiwi-bop/flutter_crashlytics/pull/64/files

Before:

image

After:

image

Until I can fix the bug I don't know if these frames are correct. They seem plausible because this crash is preceded by video artifacts in canvas.

@kroikie kroikie removed this from the Overdue milestone Mar 11, 2019
@kroikie kroikie added this to the April 2019 milestone Mar 11, 2019
@MisterJimson
Copy link

@MisterJimson MisterJimson commented Mar 20, 2019

Should this be closed? The pub link on the readme goes nowhere. Is the package published?

https://github.com/flutter/plugins/tree/master/packages/firebase_crashlytics

@jaumard
Copy link
Contributor

@jaumard jaumard commented Mar 20, 2019

Also notice that is a partial support, as it does not more than flutter_crashlytics and have same limitations... the main who is that crash are reported as non fatal :/

@kroikie
Copy link

@kroikie kroikie commented Mar 20, 2019

@MisterJimson The pub link should be working now.

@jaumard You are correct that the crashes are reported as non fatal. Future versions will address this, thanks for the feedback.

@kroikie
Copy link

@kroikie kroikie commented Mar 20, 2019

Filed an issue for fatal support

@kroikie
Copy link

@kroikie kroikie commented Oct 13, 2019

@dotdoom

This issue has been moved to FirebaseExtended/flutterfire#903. Any further collaboration will be done there.

@github-actions
Copy link

@github-actions github-actions bot commented Aug 27, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet