Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebView's text selection dialog is not responding to touch events #24585

Open
amirh opened this issue Nov 20, 2018 · 17 comments
Open

WebView's text selection dialog is not responding to touch events #24585

amirh opened this issue Nov 20, 2018 · 17 comments

Comments

@amirh
Copy link
Contributor

@amirh amirh commented Nov 20, 2018

Internal: b/141519527

If you select text inside the webview and try to tap one of the copy/share/etc buttons it doesn't respond.

@nsharma098

This comment has been minimized.

Copy link

@nsharma098 nsharma098 commented Dec 27, 2018

Is their any progress in this issue?

@DCrow

This comment has been minimized.

Copy link

@DCrow DCrow commented Dec 28, 2018

This should be fixed when flutters engine lands

@amirh

This comment has been minimized.

Copy link
Contributor Author

@amirh amirh commented Dec 28, 2018

@DCrow I'm not aware of any related fix in the engine (note that this is on Android), are you sure about it?
(this is unrelated to #24207)

@DCrow

This comment has been minimized.

Copy link

@DCrow DCrow commented Dec 28, 2018

@amirh Sry, mistook this for iOs...

@lzxb

This comment has been minimized.

Copy link

@lzxb lzxb commented Jul 19, 2019

I also need it.

@XHL-study

This comment has been minimized.

Copy link

@XHL-study XHL-study commented Jul 19, 2019

me too

@masewo

This comment has been minimized.

Copy link

@masewo masewo commented Jul 20, 2019

Please upvote this issue if you need this 👍

@mtallenca

This comment has been minimized.

Copy link

@mtallenca mtallenca commented Jul 22, 2019

I have a solution for this bug but it's a total hack. Flutter is capturing the touches and forwarding them to the webview. Unfortunately on Android, the selection dialog is a top level window not in the webview, so when the webview gets the tap, the selection dialog is dismissed. My current solution grabs the location of the selection dialog, then intercept touches when the selection dialog is visible and calls the appropriate menu handler when a tap should have been redirected to the selection dialog.

The solution we had no longer works in flutter 1.9+. There were some underlying changes with the implementation fo PlatformViews. We have pivoted to building a solution that is using the html and csslib packages to parse the html/css and build a flutter widget tree. So far results looks promising - but far from release ready.

@joelbrostrom

This comment has been minimized.

Copy link

@joelbrostrom joelbrostrom commented Aug 9, 2019

This might seam like a minor issue, but "look up"-apps relies on their customer to copy/paste items/names/phone numbers/order numbers etc.

Try asking a user to type Microsoft Windows Vista Ultimate UPGRADE Limited Numbered Signature Edition #32NR07 on a mobile keyboard when comparison shopping. 😅

@wingohtcom

This comment has been minimized.

Copy link

@wingohtcom wingohtcom commented Aug 19, 2019

@mtallenca could you post the sample project? looks like it's not going to be fixed anytime soon

@sibe7691

This comment has been minimized.

Copy link

@sibe7691 sibe7691 commented Aug 19, 2019

@mtallenca +1

@sldboy

This comment has been minimized.

Copy link

@sldboy sldboy commented Aug 21, 2019

me too,The keyboard can pop , but do not input text, on Android oppo, honor phone.

@Moyck

This comment has been minimized.

Copy link

@Moyck Moyck commented Sep 6, 2019

I want to long press to save the webpage image, but I don't know how to do.

@ydwan

This comment has been minimized.

Copy link

@ydwan ydwan commented Oct 28, 2019

I also need it.

@ydwan

This comment has been minimized.

Copy link

@ydwan ydwan commented Oct 28, 2019

@ydwan

This comment has been minimized.

Copy link

@ydwan ydwan commented Oct 28, 2019

I think the context menu view level is lower than WebView.
When clicking "select all", it seems to penetrate the WebView at the bottom.

@joelbrostrom

This comment has been minimized.

Copy link

@joelbrostrom joelbrostrom commented Nov 27, 2019

Quote by @mklim in #38375 regarding this issue:

... You can follow progress on the copy/paste issue at #24585. The current milestone for landing a fix is December 31, but like all milestones, that's a goal and may change at any point. Unfortunately there's also a decent chance that the fix for it will need to land in the flutter engine and then roll to the framework and the other channels, which will take a decent amount of time on its own as well. Sorry that you're blocked on it.

@amirh amirh modified the milestones: December 2019, March 2020 Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.