Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize fml::ThreadLocal for unique_ptr-like usage #31292

Closed
mdempsky opened this issue Apr 18, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@mdempsky
Copy link
Member

commented Apr 18, 2019

Within the flutter engine, I see four uses of fml::ThreadLocal, all of which use it to basically implement a thread_local unique_ptr. If there was a fml::ThreadLocalUniquePtr class, it would eliminate the reinterpret_casts.

[I think this is a small cleanup effort and I'm happy to do it myself; just filing an issue first for discussion per https://github.com/flutter/flutter/wiki/Tree-hygiene.]

mdempsky added a commit to mdempsky/flutter_engine that referenced this issue Apr 19, 2019

mdempsky added a commit to mdempsky/flutter_engine that referenced this issue Apr 19, 2019

mdempsky added a commit to mdempsky/flutter_engine that referenced this issue Apr 19, 2019

mdempsky added a commit to mdempsky/flutter_engine that referenced this issue Apr 19, 2019

chinmaygarde added a commit to flutter/engine that referenced this issue Apr 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.