Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking Change] remove the `FadeInImage.placeholderSemanticLabel` property #33480

Closed
tvolkert opened this issue May 29, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@tvolkert
Copy link
Contributor

commented May 29, 2019

This property was added in #28799 for the sake of completeness (the bug
it fixed was the lack of any semantic label support in FadeInImage), but a
placeholder is a transient visual artifact, not something that affects the
underlying semantic meaning of the image. Thus, I think it's ill-advised to
have a separate semantic label while the image is loading.

@tvolkert tvolkert added the framework label May 29, 2019

@tvolkert tvolkert added this to the May 2019 milestone May 29, 2019

@tvolkert tvolkert self-assigned this May 29, 2019

@tvolkert tvolkert referenced this issue May 29, 2019

Merged

Update FadeInImage to use new Image APIs #33370

8 of 9 tasks complete

@tvolkert tvolkert changed the title Remove the `FadeInImage.placeholderSemanticLabel` property [Breaking Change] remove the `FadeInImage.placeholderSemanticLabel` property Jun 2, 2019

@tvolkert

This comment has been minimized.

Copy link
Contributor Author

commented Jun 2, 2019

This is done now.

@tvolkert tvolkert closed this Jun 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.