Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking Change] remove the FadeInImage.placeholderSemanticLabel property #33480

Closed
tvolkert opened this issue May 29, 2019 · 2 comments
Closed

[Breaking Change] remove the FadeInImage.placeholderSemanticLabel property #33480

tvolkert opened this issue May 29, 2019 · 2 comments

Comments

@tvolkert
Copy link
Contributor

@tvolkert tvolkert commented May 29, 2019

This property was added in #28799 for the sake of completeness (the bug
it fixed was the lack of any semantic label support in FadeInImage), but a
placeholder is a transient visual artifact, not something that affects the
underlying semantic meaning of the image. Thus, I think it's ill-advised to
have a separate semantic label while the image is loading.

@tvolkert tvolkert added this to the May 2019 milestone May 29, 2019
@tvolkert tvolkert self-assigned this May 29, 2019
@tvolkert tvolkert changed the title Remove the FadeInImage.placeholderSemanticLabel property [Breaking Change] remove the FadeInImage.placeholderSemanticLabel property Jun 2, 2019
@tvolkert
Copy link
Contributor Author

@tvolkert tvolkert commented Jun 2, 2019

This is done now.

@tvolkert tvolkert closed this Jun 2, 2019
@github-actions
Copy link

@github-actions github-actions bot commented Aug 29, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant