-
Notifications
You must be signed in to change notification settings - Fork 27.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Engine should eagerly call onBeginFrame after running Dart's main() #3488
Comments
There shouldn't be any reason to do this. This might cause a minor perf regression until we fix flutter#3488.
Is this bug still relevant? Running
consistently prints ~2ms. |
Weird. Why 2ms? I would have expected 0ms or an even spread from 0 to 16ms. |
I see a variety of numbers testing both release and debug on a Nexus 6. In conclusion, this bug is still relevant. :-) |
On my device, it always starts with 2 window.onMetricsChanged calls where window.physicalSize is still 0x0. Does that event also trigger a redraw? |
By itself, that does not trigger a redraw, but it's common for code that's listening to that event to schedule a redraw. |
Is this issue still relevant? |
Engine doesn't seem to call this after Dart's main(). Can only get a print if I use runApp() at some point as well (but the duration is no longer useful then). |
Today, frame scheduling begins eagerly as soon as the rasterizer is setup. |
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
There's no reason for us to wait. On average, waiting means we wait 8ms of startup time doing nothing.
The text was updated successfully, but these errors were encountered: