Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report more detail about hot reload/restart failures to analytics #42549

Open
zanderso opened this issue Oct 11, 2019 · 0 comments
Open

Report more detail about hot reload/restart failures to analytics #42549

zanderso opened this issue Oct 11, 2019 · 0 comments

Comments

@zanderso
Copy link
Contributor

@zanderso zanderso commented Oct 11, 2019

The tool sometimes fails to send analytics when there is an exception during hot reload, like here:

printTrace('Hot reload failed: $error\n$stackTrace');

Also, the tool could send more information on a rejection notice from the VM. Currently these messages are dropped here:

printError('${notice['message']}');

These messages come from a few different places in the VM, and a rejection notice could in theory contain several messages, so a component of this issue may be asking for a summary message from the VM, or reporting only the first message in the notice to analytics.

Search term in the VM code: 'ReasonForCancelling' like

https://github.com/dart-lang/sdk/blob/90ff37e0115c301cb742f894f64f4e3c78879df7/runtime/vm/isolate_reload.cc#L266

and

https://github.com/dart-lang/sdk/blob/90ff37e0115c301cb742f894f64f4e3c78879df7/runtime/vm/object_reload.cc#L562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.