Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firebase_database] Add web support to plugin #48542

Closed
ditman opened this issue Jan 10, 2020 · 48 comments · Fixed by firebase/flutterfire#6952
Closed

[firebase_database] Add web support to plugin #48542

ditman opened this issue Jan 10, 2020 · 48 comments · Fixed by firebase/flutterfire#6952
Labels
c: new feature Nothing broken; request for a new capability customer: crowd Affects or could affect many people, though not necessarily a specific customer. p: firebase_database The Firebase Database plugin P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-web Web applications specifically r: fixed Issue is closed as already fixed in a newer version

Comments

@ditman
Copy link
Member

ditman commented Jan 10, 2020

We should add web support to firebase_database.

@ditman ditman added c: new feature Nothing broken; request for a new capability plugin platform-web Web applications specifically p: firebase_database The Firebase Database plugin labels Jan 10, 2020
@ditman ditman added this to the Near-term Goals milestone Jan 10, 2020
@ditman ditman added this to Not Started in Flutter Web Plugins via automation Jan 10, 2020
@ayushs136
Copy link

can you please elaborate the issue?

@ditman
Copy link
Member Author

ditman commented Jan 13, 2020

@ayushs136 check the "Flutter Web Plugins" project for more details.

@awazgyawali
Copy link
Contributor

awazgyawali commented Jan 19, 2020

I have started the process to introduce the support. Is there any guideline or blog post to outline the exact steps that I need to follow @ditman

@ditman
Copy link
Member Author

ditman commented Jan 21, 2020

@awazgyawali Thanks!!

I don't think there's anything written right now, but the rough steps are:

  • Extract the common interface used by the plugin to a common package.
    • This also contains the "Method Channel" implementation used by the mobile versions of the plugin.
  • Refactor the mobile plugin to use the Method Channel implementation that you created in the step above.
  • Add Web support by implementing the same interface in the first step.

You can refer to:

@ditman ditman moved this from Not Started to Adding Platform Interface in Flutter Web Plugins Feb 14, 2020
@ditman
Copy link
Member Author

ditman commented Feb 14, 2020

@awazgyawali a new article about how to write plugins with federation has been published by @hterkelsen just now!

You can read it here:

Let us know if you need some help to continue with the federation work you've started!

@awazgyawali
Copy link
Contributor

Hi @ditman. Thanks for updating this thread with the article. A month back I started the work and have done about 60% of the task but I was not able to make simple decisions as there was no guidelines to continue. As there is a blog now, ill come back to the work I left and try to finish it. I will let you know if I have any questions to make.

@ditman
Copy link
Member Author

ditman commented Feb 14, 2020

@awazgyawali thanks!! Also please do check out the other plugins that have been already migrated to web. cloud_firestore had many changes in the last month that might serve as inspiration!

@namchuai
Copy link

It would be nice if you guys can share the progress of the work :). Thank you for your effort!

@VladyslavBondarenko VladyslavBondarenko added the customer: crowd Affects or could affect many people, though not necessarily a specific customer. label Mar 19, 2020
@kormemis
Copy link

is there any updates about web plugin for firebase_database ?

@YohanWadia
Copy link

Hi guys. I just want to add to some other requests about Firebase RealTime for the Web.... That it would be nice to know the progress... or some kinda way to track the on going updates that you guys are working on. thanks for all the great work!

@awazgyawali
Copy link
Contributor

Hi @ditman Can you check this comment. firebase/flutterfire#1835 (comment)

@ditman
Copy link
Member Author

ditman commented May 18, 2020

@awazgyawali apologies, I missed that notification! Thanks for the effort, I've commented in the PR with next steps. Ping me if I didn't make sense.

@kf6gpe kf6gpe added the P1 High-priority issues at the top of the work list label May 29, 2020
@kf6gpe kf6gpe modified the milestone: Near-term Goals Jun 1, 2020
@yjbanov yjbanov added P2 Important issues not at the top of the work list and removed P1 High-priority issues at the top of the work list labels Jun 16, 2020
@atreeon
Copy link

atreeon commented Jun 24, 2020

Hi, what sort of timeframe are you expecting to complete this by? A month, end of the year, next year? Thanks!

@ditman
Copy link
Member Author

ditman commented Apr 21, 2021

My priorities shifted slightly to other plugins and the web engine for the last few months, and haven't had time to look into firebase_database. However, it's not forgotten!

See, for example: firebase/flutterfire#2852 (comment)

It'll happen!

@YohanWadia
Copy link

@ditman @Salakar ... thanks for hearing our plea! ;-)
I really request you guys to consider pushing it higher on the Flutter+Firebase priorities only because there are too many developers/engineers whose projects are stuck due to this... Believe me, thats more than the quantity of guys who are following up. I am not alone when I voice my concern of the Realtime Database being relegated to almost a last spot in making our FlutterFire plugins truly multiplatform(including web).
Seriously, Thanks again, We appreciate all you guys are packing into this - but please consider the RealTime DataBase as an equal that needs more hands on deck, incase you guys are over burdened. thanks again! And will await any good news of the build succeeding!

@deepak786
Copy link

waiting for web support.....

@geekydiamond
Copy link

Hey guys, trying to plan our business priorities for the next year, and many are predicated on moving some key apps to the web. Currently this plugin is the only blocker to that plan, so it's making it very hard to know whether we should invest in a React offering, move to another Firebase plugin, or wait in hope. Any rough guidance on dates would be very much appreciated.

@jameslester2004
Copy link

Agree with the comment above. This is our only blocker from releasing a web app. I really appreciate all the work that people put into these plugins, but its a little disheartening this has been dropped. I would be happy to donate to get it moving. I sense there is a lot of demand and others willing to do the same. Thanks

@YohanWadia
Copy link

@jameslester2004 ... the real disheartening part is that the professionals who guide our development believe in a fallacy that, "The Realtime Firebase Db is of least importance" . Whats also disheartening is that we dont have a single shred of information of whats the real status. Im quite taken aback by the way it has been handled. Especially from the choice of it being relegated to the least bit of importance... to ... a delayed time line.... to... pausing it due to null safety for other packages... etc etc.
And now its just a void. All the other packages had constant updates and they kept everyone in the loop. I really hope they can just get this over and done with cause honestly most of my clients have lost interest.

@awazgyawali
Copy link
Contributor

I was the author of this PR, which was trying to bring the web support on the plugin.

Bad luck to us that the PR came in the times when the flutterfire plugin was going on a very massive refactoring process. Core team didn't have the time to merge or even review the PR.

However as per this comment, seems the team is now open to receive PR's on this topic.

I'll try to find some time and start getting into it again. Also, If anybody is interested to contribute, please let me know. Let get this one done!!!!!

@elielson-anjos
Copy link

Hey, I'm in desperate need of this for web, unfortunately I do not have the skills to contribute to the project. Any ETA?

@geekydiamond
Copy link

I was the author of this PR, which was trying to bring the web support on the plugin.

Bad luck to us that the PR came in the times when the flutterfire plugin was going on a very massive refactoring process. Core team didn't have the time to merge or even review the PR.

However as per this comment, seems the team is now open to receive PR's on this topic.

I'll try to find some time and start getting into it again. Also, If anybody is interested to contribute, please let me know. Let get this one done!!!!!

If you take the lead, I'm happy to (try to) help where I can...

@kormemis
Copy link

kormemis commented Jul 20, 2021

I will pay 1000 $ worth bitcoin who will publish firebase realtime database web PR without any bug till the end of August !! consider this

@deepak786
Copy link

I have created a separated package firebase_database_platform_interface and submitted the pull request firebase/flutterfire#6668

@jameslester2004
Copy link

How did it go @deepak786 ? Really appreciate you taking the time to do this.

@deepak786
Copy link

deepak786 commented Aug 13, 2021

@jameslester2004 according to the comment firebase/flutterfire#1835 (comment), the team is looking for the PR which will improve the integration test first.

Then they will proceed further to have separated intercom_flutter_platform_interface.

I have submitted the pull request which will separate the intercom_flutter_platform_interface.

But I will try to improve the integration tests.

@deepak786
Copy link

deepak786 commented Aug 23, 2021

Another PR firebase/flutterfire#6868 submitted to improve the integration tests.

  1. PR test(firebase_database): refactored and added some query integration tests firebase/flutterfire#6868 (to improve the integration tests)
  2. PR refactor(firebase_database): firebase_database_platform_interface firebase/flutterfire#6668 (to create a separate platform interface)

I hope the above PRs will be reviewed soon.

After these PRs are merged, I will start working on the web platform package.

@jameslester2004
Copy link

Great job Deepak. Really appreciate your efforts!

@deepak786
Copy link

Yay, both the PRs are merged.

Now I can proceed with the web implementation.

if anyone wants to buy me a coffee, please don't hesitate.

Buy Me A Coffee

@MrBirb
Copy link
Contributor

MrBirb commented Sep 12, 2021

@TahaTesser Should this be closed and let the flutterfire team handle this?

Flutter Web Plugins automation moved this from Not Started to Done Sep 14, 2021
@deepak786
Copy link

PR firebase/flutterfire#6952 is merged also. The web support to the real-time database will be released soon.

@ditman
Copy link
Member Author

ditman commented Sep 14, 2021

Thanks for the super hard work @deepak786! You've helped a ton of fellow flutter users with this wonderful contribution!!

@YohanWadia
Copy link

@deepak786 Thanks a million. You're a legend! ;-)

@kormemis
Copy link

Yay, both the PRs are merged.

Now I can proceed with the web implementation.

if anyone wants to buy me a coffee, please don't hesitate.

Buy Me A Coffee

hello I need your mail address, cannot reach you, could you please share your e-mail or how can I reach you
thanks.

@deepak786
Copy link

@kormemis you can reach me at er.deepakgoyal786@gmail.com

@TahaTesser TahaTesser added the r: fixed Issue is closed as already fixed in a newer version label Sep 17, 2021
@github-actions
Copy link

github-actions bot commented Oct 1, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2021
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: new feature Nothing broken; request for a new capability customer: crowd Affects or could affect many people, though not necessarily a specific customer. p: firebase_database The Firebase Database plugin P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. platform-web Web applications specifically r: fixed Issue is closed as already fixed in a newer version
Projects
Development

Successfully merging a pull request may close this issue.