Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter #59120

Hixie · 2020-06-10T01:52:15Z

They are replaced by the single class FilteringTextInputFormatter.

Also, Remove deprecated_member_use_from_same_package. Since I ignore this lint rather than adding a bunch of //ignores, I also go and clean up other places we ignored this lint.

fyi @Piinks for the deprecation stuff
fyi @xster since you added these classes

Hixie · 2020-06-10T01:52:30Z

Might be easier to review by reviewing the two commits separately.

Piinks

This is awesome! The analyzer has some thoughts though.

Piinks · 2020-06-10T17:44:27Z

packages/flutter/lib/src/material/pickers/pickers.dart

@@ -13,3 +13,9 @@ export 'date_picker_deprecated.dart';
 export 'date_picker_dialog.dart' show showDatePicker;
 export 'date_range_picker_dialog.dart' show showDateRangePicker;
 export 'input_date_picker.dart' show InputDatePickerFormField;
+
+// TODO(ianh): Not exporting everything is unusual and we should


@darrenaustin may already have a plan for this.

Piinks · 2020-06-10T18:17:31Z

packages/flutter/lib/src/services/text_formatter.dart

+/// Old name for [FilteringTextInputFormatter.deny].
+@Deprecated(
+  'Use FilteringTextInputFormatter.deny instead. '
+  'This feature was deprecated after 1.19.0-4.0.pre'


Suggested change

'This feature was deprecated after 1.19.0-4.0.pre'

'This feature was deprecated after 1.19.0-4.0.pre.'

I think the deprecations here are just missing a period to make the analyzer happy. :)

Piinks · 2020-06-10T18:20:21Z

It looks like customer tests may have to be updated as well.

Hixie · 2020-06-10T18:32:03Z

I need to talk to the gallery folks, yeah.

Hixie · 2020-06-12T20:02:17Z

Update: PR should have all the tests fixed now, and I spoke to the Gallery folks, they'll update after this lands (I made the specific deprecations that were failing on the Gallery not be failures for now; I'll deprecate them later once there's no breaking changes to worry about).

Hixie · 2020-06-13T23:17:47Z

@Piinks PTAL

Hixie · 2020-06-16T23:11:42Z

Fixes #59099

Hixie · 2020-06-17T00:18:52Z

Merge conflicts fixed. Should be ready to land assuming no problems are found in review.

goderbauer

LGTM

goderbauer · 2020-06-17T02:13:44Z

packages/flutter/lib/src/services/text_formatter.dart

+  /// in separate passes.
+  ///
+  /// See also [String.splitMapJoin], which is used to implement this
+  /// behavior in both cases.


Nice comprehensive doc comment!

goderbauer · 2020-06-17T02:16:11Z

packages/flutter/lib/src/services/text_formatter.dart

  static final BlacklistingTextInputFormatter singleLineFormatter
      = BlacklistingTextInputFormatter(RegExp(r'\n'));
 }

+/// Old name for [FilteringTextInputFormatter.allow].
+// TODO(ianh): Deprecate these once the samples are migrated.


Which samples is this referring to?

Maybe add a link?

gallery in samples. they've said they'll fix it when i land this.

https://github.com/flutter/gallery/blob/74d9d92883c6ca10742c44df309f065289cf2f55/lib/demos/material/text_field_demo.dart#L225

goderbauer · 2020-06-17T02:24:04Z

Looks like cirrus is unhappy, though.

…matter They are replaced by the single class FilteringTextInputFormatter.

Since I ignored this lint rather than adding a bunch of //ignores in the earlier commit, I also go and clean up other places we ignored this lint.

christopherfujino · 2020-06-19T17:51:14Z

Reverting this TBR by @Hixie as it caused LUCI post-submit to fail with:

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8877105797085540816/+/steps/run_test.dart_for_framework_tests_shard/0/stdout

The following StateError was thrown running a test:
Bad state: No element

When the exception was thrown, this was the stack:
#0      Iterable.single (dart:core/iterable.dart:558:25)
#1      WidgetController._getElementPoint (package:flutter_test/src/controller.dart:646:47)
#2      WidgetController.getCenter (package:flutter_test/src/controller.dart:618:12)
#3      WidgetController.tap (package:flutter_test/src/controller.dart:256:18)
#4      main.<anonymous closure> (file:///b/s/w/ir/k/flutter/packages/flutter/test/material/text_field_test.dart:3285:18)
#15     FakeAsync.flushMicrotasks (package:fake_async/fake_async.dart:192:32)
#16     AutomatedTestWidgetsFlutterBinding.runTest.<anonymous closure> (package:flutter_test/src/binding.dart:1135:17)
#17     AutomatedTestWidgetsFlutterBinding.runTest.<anonymous closure> (package:flutter_test/src/binding.dart:1123:35)
(elided 25 frames from dart:async and package:stack_trace)

The test description was:
  Pasted values are formatted

…InputFormatter (#59120)" This reverts commit 8665e13.

…InputFormatter (#59120)" (#59870) This reverts commit 8665e13.

…tingTextInputFormatter (#59120)" (#59870)" This reverts commit 0d7ff7a.

…tInputFormatter (#59120)" (#59876) This relands #59120, which was reverted in #59870.

…matter (flutter#59120)

…InputFormatter (flutter#59120)" (flutter#59870) This reverts commit 8665e13.

…tInputFormatter (flutter#59120)" (flutter#59876) This relands flutter#59120, which was reverted in flutter#59870.

…matter (flutter#59120)

…InputFormatter (flutter#59120)" (flutter#59870) This reverts commit 8665e13.

…tInputFormatter (flutter#59120)" (flutter#59876) This relands flutter#59120, which was reverted in flutter#59870.

braulio94 · 2020-09-15T14:19:59Z

Since this is deprecated, what should we use instead?

braulio94 · 2020-09-15T14:22:15Z

Since this is deprecated, what should we use instead?

Got it, eg:

FilteringTextInputFormatter.digitsOnly

googlebot added the cla: yes label Jun 10, 2020

miquelbeltran mentioned this pull request Jun 10, 2020

Rename classes/methods #23705

Closed

Piinks reviewed Jun 10, 2020

View reviewed changes

Hixie force-pushed the filters branch 6 times, most recently from 681e600 to 9591ed4 Compare June 12, 2020 20:01

Hixie mentioned this pull request Jun 15, 2020

Remove master branch and references to the word such as master, slave, blacklist and whitelist. #59445

Closed

Hixie force-pushed the filters branch from 9591ed4 to 299dc63 Compare June 17, 2020 00:18

goderbauer approved these changes Jun 17, 2020

View reviewed changes

Hixie force-pushed the filters branch from 299dc63 to 461de25 Compare June 18, 2020 19:45

Hixie added 4 commits June 18, 2020 13:37

Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFor…

4dfc137

…matter They are replaced by the single class FilteringTextInputFormatter.

Remove deprecated_member_use_from_same_package

b1e98d7

Since I ignored this lint rather than adding a bunch of //ignores in the earlier commit, I also go and clean up other places we ignored this lint.

Update syntax for deprecation notices

cbc402a

Fix merge problems

d001fe1

Hixie force-pushed the filters branch from 461de25 to d001fe1 Compare June 18, 2020 20:37

Hixie added the waiting for tree to go green label Jun 19, 2020

fluttergithubbot merged commit 8665e13 into flutter:master Jun 19, 2020

Hixie deleted the filters branch June 19, 2020 06:36

christopherfujino added a commit that referenced this pull request Jun 19, 2020

Revert "Deprecate WhitelistingTextInputFormatter and BlacklistingText…

6f0eb46

…InputFormatter (#59120)" This reverts commit 8665e13.

christopherfujino mentioned this pull request Jun 19, 2020

Revert "Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter" #59870

Merged

christopherfujino added a commit that referenced this pull request Jun 19, 2020

Revert "Deprecate WhitelistingTextInputFormatter and BlacklistingText…

0d7ff7a

…InputFormatter (#59120)" (#59870) This reverts commit 8665e13.

christopherfujino added a commit that referenced this pull request Jun 19, 2020

Revert "Revert "Deprecate WhitelistingTextInputFormatter and Blacklis…

4684343

…tingTextInputFormatter (#59120)" (#59870)" This reverts commit 0d7ff7a.

christopherfujino mentioned this pull request Jun 19, 2020

Re-land "Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter" #59876

Merged

christopherfujino added a commit that referenced this pull request Jun 19, 2020

Re-land "Deprecate WhitelistingTextInputFormatter and BlacklistingTex…

5cfb16b

…tInputFormatter (#59120)" (#59876) This relands #59120, which was reverted in #59870.

jason-simmons mentioned this pull request Jun 19, 2020

Fix the paste button label in the new version of the filtered text pasting test #59865

Merged

zljj0818 pushed a commit to zljj0818/flutter that referenced this pull request Jun 22, 2020

Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFor…

209d8ce

…matter (flutter#59120)

zljj0818 pushed a commit to zljj0818/flutter that referenced this pull request Jun 22, 2020

Revert "Deprecate WhitelistingTextInputFormatter and BlacklistingText…

b34406d

…InputFormatter (flutter#59120)" (flutter#59870) This reverts commit 8665e13.

zljj0818 pushed a commit to zljj0818/flutter that referenced this pull request Jun 22, 2020

Re-land "Deprecate WhitelistingTextInputFormatter and BlacklistingTex…

4c6971b

…tInputFormatter (flutter#59120)" (flutter#59876) This relands flutter#59120, which was reverted in flutter#59870.

mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020

Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFor…

4450354

…matter (flutter#59120)

mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020

Revert "Deprecate WhitelistingTextInputFormatter and BlacklistingText…

27b6e75

…InputFormatter (flutter#59120)" (flutter#59870) This reverts commit 8665e13.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter #59120

Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter #59120

Hixie commented Jun 10, 2020

Hixie commented Jun 10, 2020

Piinks left a comment

Piinks Jun 10, 2020

Piinks Jun 10, 2020

Hixie Jun 10, 2020

Piinks commented Jun 10, 2020

Hixie commented Jun 10, 2020

Hixie commented Jun 12, 2020

Hixie commented Jun 13, 2020

Hixie commented Jun 16, 2020

Hixie commented Jun 17, 2020

goderbauer left a comment

goderbauer Jun 17, 2020

goderbauer Jun 17, 2020

goderbauer Jun 17, 2020

Hixie Jun 18, 2020

goderbauer Jun 18, 2020

goderbauer commented Jun 17, 2020

christopherfujino commented Jun 19, 2020

braulio94 commented Sep 15, 2020

braulio94 commented Sep 15, 2020

	'This feature was deprecated after 1.19.0-4.0.pre'
	'This feature was deprecated after 1.19.0-4.0.pre.'

Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter #59120

Deprecate WhitelistingTextInputFormatter and BlacklistingTextInputFormatter #59120

Conversation

Hixie commented Jun 10, 2020

Hixie commented Jun 10, 2020

Piinks left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Piinks commented Jun 10, 2020

Hixie commented Jun 10, 2020

Hixie commented Jun 12, 2020

Hixie commented Jun 13, 2020

Hixie commented Jun 16, 2020

Hixie commented Jun 17, 2020

goderbauer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

goderbauer commented Jun 17, 2020

christopherfujino commented Jun 19, 2020

braulio94 commented Sep 15, 2020

braulio94 commented Sep 15, 2020