Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input does not hide the hintText when a value is entered #8653

Closed
lukef opened this issue Mar 8, 2017 · 8 comments
Closed

Input does not hide the hintText when a value is entered #8653

lukef opened this issue Mar 8, 2017 · 8 comments
Assignees
Labels
a: text input Entering text in a text field or keyboard related problems c: regression It was better in the past than it is now customer: posse (eap) framework flutter/packages/flutter repository. See also f: labels.
Projects

Comments

@lukef
Copy link
Contributor

lukef commented Mar 8, 2017

The Input and InputField widgets retain their hintText widget even after a text value has been entered.

See example below:

screen-shot-2017-03-08-at-12 20 32-am

@eseidelGoogle eseidelGoogle added framework flutter/packages/flutter repository. See also f: labels. a: text input Entering text in a text field or keyboard related problems customer: posse (eap) labels Mar 8, 2017
@eseidelGoogle
Copy link
Contributor

@HansMuller so you have any context here?

@lukef
Copy link
Contributor Author

lukef commented Mar 9, 2017

This functionality works fine on TextField but not on Input or InputField. I also made sure it is inside a Material.

@HansMuller HansMuller added the c: regression It was better in the past than it is now label Mar 9, 2017
@HansMuller
Copy link
Contributor

I don't know when this regressed. We really need a test for this behavior for all of the input widgets.

@eseidelGoogle
Copy link
Contributor

Going to bump this to M1 given the regression status and the fact that it's blocking Hoppy. @HansMuller are you the right person to stab at this? Or maybe @jason-simmons or @Hixie?

@jason-simmons
Copy link
Member

Took a look at this and was able to show an Input/InputField clearing the hint text once its value becomes nonempty.

Note that unlike TextField, Input/InputField requires an onChanged handler that does a setState() which updates the field's value.

@eseidelGoogle eseidelGoogle added this to Customer Blockers in M2 Mar 20, 2017
@abarth abarth self-assigned this Mar 21, 2017
@eseidelGoogle eseidelGoogle moved this from Customer Blockers to In Progress in M2 Mar 22, 2017
@eseidelGoogle
Copy link
Contributor

@abarth I see you self-assigned, but I'm not sure what the next work here is. Do we have an update for Posse? I'm meeting with them this afternoon. :)

@abarth
Copy link
Contributor

abarth commented Apr 2, 2017

@eseidelGoogle Sorry, I should have responded earlier. I saw the bug and was planning to fix it when I rationalized the input widgets.

This should be fixed as of ae89948

@abarth abarth closed this as completed Apr 2, 2017
@eseidelGoogle eseidelGoogle moved this from In Progress to Done in M2 Apr 4, 2017
@github-actions
Copy link

github-actions bot commented Sep 5, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: text input Entering text in a text field or keyboard related problems c: regression It was better in the past than it is now customer: posse (eap) framework flutter/packages/flutter repository. See also f: labels.
Projects
No open projects
M2
Done
Development

No branches or pull requests

6 participants