Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify thread merging semantics #87112

Open
iskakaushik opened this issue Jul 27, 2021 · 0 comments
Open

Simplify thread merging semantics #87112

iskakaushik opened this issue Jul 27, 2021 · 0 comments
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@iskakaushik
Copy link
Contributor

When dynamic thread merging was first implemented, the design considerations were limited to:

  1. Usage on iOS.
  2. Merging can only happen on the platform thread.
  3. Merge / Un-merge will only resubmit the frame.

The evolution has lead to:

  1. Usage across all platforms.
  2. Merging is happening across both platform and raster threads.
  3. Frames can be skipped or resubmitted.
  4. Raster thread merger can be enabled or disabled.

This has lead to some issues, and I think we should revisit this component. We should also improve the testability.

See: flutter/engine#27695

cc: @chinmaygarde , @zanderso
@iskakaushik iskakaushik added the engine flutter/engine repository. See also e: labels. label Jul 27, 2021
@iskakaushik iskakaushik mentioned this issue Jul 27, 2021
Merged
@chinmaygarde chinmaygarde added the P2 Important issues not at the top of the work list label Aug 2, 2021
@flutter-triage-bot flutter-triage-bot bot added team-engine Owned by Engine team triaged-engine Triaged by Engine team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chinmaygarde @Hixie @iskakaushik @darshankawar