Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter Engine (sky_shell) fails a number of Dart standalone tests #9115

Closed
a-siva opened this issue Mar 31, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@a-siva
Copy link
Contributor

commented Mar 31, 2017

Steps to Reproduce

tools/test.py -j4 --checked -rflutter --flutter=<path_to_flutter>/engine/src/out/host_debug_unopt/sky_shell standalone

Logs

regress_28854_1_test: Crash
io/raw_datagram_socket_test: Crash
regress_28854_2_test: Crash 
verbose_gc_to_bmu_test: RuntimeError
io/process_check_arguments_test: RuntimeError
io/process_working_directory_test: RuntimeError
io/regress_7679_test: RuntimeError
io/process_broken_pipe_test: RuntimeError
io/process_run_output_test: RuntimeError
io/ansi_supported_test: RuntimeError
io/process_run_test: RuntimeError
io/process_sync_test: RuntimeError
io/test_extension_test: RuntimeError
io/test_extension_fail_test: RuntimeError
oom_error_stacktrace_test: RuntimeError
io/raw_socket_cross_process_test: RuntimeError
io/stdio_nonblocking_test: RuntimeError
io/process_exit_test: RuntimeError
io/uri_platform_test: RuntimeError
io/dart_std_io_pipe_test: RuntimeError
io/platform_test: RuntimeError
io/process_stderr_test: RuntimeError
io/process_segfault_test: RuntimeError
io/addlatexhash_test: RuntimeError
io/http_server_response_test: Skip # Flaky 
io/process_stdout_test: RuntimeError
io/http_cross_process_test: RuntimeError
io/snapshot_fail_test: RuntimeError
io/process_set_exit_code_test: RuntimeError
io/process_stdin_transform_unsubscribe_test: RuntimeError
io/stdin_sync_test: RuntimeError
io/raw_server_socket_cancel_test: RuntimeError
io/socket_cross_process_test: RuntimeError
io/stdio_nonblocking_test: RuntimeError
io/process_exit_test: RuntimeError
io/uri_platform_test: RuntimeError
io/dart_std_io_pipe_test: RuntimeError
io/platform_test: RuntimeError
io/process_stderr_test: RuntimeError
io/process_segfault_test: RuntimeError
io/addlatexhash_test: RuntimeError
io/http_server_response_test: RuntimeError
io/process_stdout_test: RuntimeError
io/http_cross_process_test: RuntimeError
io/snapshot_fail_test: RuntimeError
io/process_set_exit_code_test: RuntimeError
io/process_stdin_transform_unsubscribe_test: RuntimeError
io/stdin_sync_test: RuntimeError
io/raw_server_socket_cancel_test: RuntimeError
io/socket_cross_process_test: RuntimeError
io/arguments_test: RuntimeError
io/code_collection_test: RuntimeError
io/http_client_stays_alive_test: RuntimeError
io/file_read_special_device_test: RuntimeError
out_of_memory_test: RuntimeError
dart_developer_env_test: RuntimeError

io/process_pid_test: Skip # Timeout
io/socket_info_ipv4_test: Skip # Timeout
io/file_test: Skip # Timeout
io/named_pipe_script_test: Skip # Timeout
io/print_sync_test: Skip # Timeout
io/file_uri_test: Skip # Timeout
io/file_lock_test: Skip # Timeout
io/socket_info_ipv6_test: Skip # Timeout
io/stdio_implicit_close_test: Skip # Timeout
io/process_environment_test: Skip # Timeout
io/secure_socket_renegotiate_test: Skip # Timeout
io/process_kill_test: Skip # Timeout
io/directory_uri_test: Skip # Timeout
io/raw_socket_test: Skip # Timeout
io/http_connection_close_test: Skip # Timeout
io/https_unauthorized_test: Skip # Timeout
io/file_system_watcher_test: Skip # Timeout
io/secure_unauthorized_test: Skip # Timeout
io/secure_socket_bad_data_test: Skip # Timeout
io/link_uri_test: Skip # Timeout
io/file_stream_test: Skip # Timeout
io/regress_7191_test: Skip # Timeout
io/http_server_close_response_after_error_test: Skip # Timeout
io/signals_test: Skip # Timeout
io/process_non_ascii_test: Skip # Timeout
io/https_client_certificate_test: Skip # Timeout
io/socket_finalizer_test: Skip # Timeout
io/process_shell_test: Skip # Timeout
io/file_blocking_lock_test: Skip # Timeout
io/socket_invalid_arguments_test: Skip # Timeout
io/process_detached_test: Skip # Timeout
io/platform_resolved_executable_test/00: Skip # Timeout
io/platform_resolved_executable_test/01: Skip # Timeout
io/platform_resolved_executable_test/02: Skip # Timeout
io/platform_resolved_executable_test/03: Skip # Timeout
io/platform_resolved_executable_test/04: Skip # Timeout
io/platform_resolved_executable_test/05: Skip # Timeout
http_launch_test: Skip # Timeout

a-siva added a commit to dart-lang/sdk that referenced this issue Apr 3, 2017

Adjust status files to account for running the Dart test cases throug…
…h flutter engine on linux.

Accounted for language, co19, lib, corelib, isolate and standalone tests.

Filed issues to track all failing tests

  flutter/flutter#9109
  flutter/flutter#9110
  flutter/flutter#9111
  flutter/flutter#9113
  flutter/flutter#9114
  flutter/flutter#9115

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2784293003 .

@eseidelGoogle eseidelGoogle added this to the No milestone necessary milestone Apr 12, 2017

@Hixie Hixie added the team: flakes label Oct 3, 2017

@zoechi

This comment has been minimized.

Copy link
Contributor

commented Dec 28, 2018

Is this issue still relevant?

@a-siva

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2019

This is probably not relevant anymore and can be closed.
The initial idea was to see if we could run all the VM unit tests on a version of the engine to ensure
that any engine specific implementation of the feature would get tested out (eg: isolates, dart:io etc.).

The sky_shell executable has since been deprecated, had an offline conversation with @chinmaygarde and he indicated that efforts are on to get test coverage metrics for the engine and beef up the unit testing that is already being done in the engine builds to cover the gaps that show up in the test coverage reports.

@a-siva a-siva closed this Jan 24, 2019

dart-bot pushed a commit to dart-lang/sdk that referenced this issue Jan 25, 2019

[ Test ] Remove support for flutter runtime from the test framework
Support for the flutter runtime (sky_shell) was added to the Dart
test framework in the hope that one could run the flutter engine
through the Dart test suite. We never got around to running these
tests on the build bots, the sky_shell executable has been deprecated
and there are plans in the flutter engine team to have their own
unit test frame work.

See Issue flutter/flutter#9115 for more
details.

Change-Id: I6ee9e8c919721dccecf4202ab0778939aeb79174
Reviewed-on: https://dart-review.googlesource.com/c/91103
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.