Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onOpened callback to PopupMenuButton #103753

Merged
merged 1 commit into from Aug 14, 2022
Merged

Add onOpened callback to PopupMenuButton #103753

merged 1 commit into from Aug 14, 2022
+84 −1

Conversation

limonadev
Copy link
Contributor

@limonadev limonadev commented May 13, 2022 •
edited

This PR adds a new callback onOpened to PopupMenuButton, called when the menu appears (normally after tapping the button).

List which issues are fixed by this PR. You must list at least one issue.
Fixes #21773

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 13, 2022
@google-cla
Copy link

google-cla bot commented May 13, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

gspencergoog
gspencergoog approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

packages/flutter/lib/src/material/popup_menu.dart Outdated Show resolved Hide resolved
@limonadev
Copy link
Contributor Author

@gspencergoog is there anything left for this PR to be approved/merged? Thanks!

@gspencergoog
Copy link
Contributor

Yes, there needs to be a second approval.

Also, you might want to sync to the current HEAD and push again: it looks like the bots got a little confused and need to be prodded again.

@goderbauer, since you gave a drive-by, would you want to be the second review on this?

goderbauer
goderbauer approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 6, 2022
@gspencergoog
Copy link
Contributor

@limonadev Actually, it looks like you'll need to sync to the HEAD revision on master and push again. Something didn't get picked up properly in the continuous integration bots, and it just needs to be restarted. Pushing again will do that.

@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 6, 2022

  • The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 6, 2022
@limonadev
Copy link
Contributor Author

@gspencergoog done! 😄

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 14, 2022
@auto-submit auto-submit bot merged commit 4dd7065 into flutter:master Aug 14, 2022
This was referenced Aug 15, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
4dd706524 Add onOpened callback to PopupMenuButton (flutter/flutter#1…
799bc44 
…03753)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
4dd7065 Add onOpened callback to PopupMenuButton (flutter/flutter#103753
dd918b3 
)
This was referenced Aug 15, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
4dd706524 Add onOpened callback to PopupMenuButton (flutter/flutter#1…
5b4e0fe 
…03753)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
4dd7065 Add onOpened callback to PopupMenuButton (flutter/flutter#103753
fd5a101 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
4dd706524 Add onOpened callback to PopupMenuButton (flutter/flutter#1…
a8d6853 
…03753)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
4dd7065 Add onOpened callback to PopupMenuButton (flutter/flutter#103753
fb0191e 
)
This was referenced Aug 15, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
4dd706524 Add onOpened callback to PopupMenuButton (flutter/flutter#1…
d3d2ec0 
…03753)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
4dd7065 Add onOpened callback to PopupMenuButton (flutter/flutter#103753
b66cfb5 
)
This was referenced Aug 15, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
4dd706524 Add onOpened callback to PopupMenuButton (flutter/flutter#1…
605e6a1 
…03753)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
4dd7065 Add onOpened callback to PopupMenuButton (flutter/flutter#103753
6a2098b 
)
stuartmorgan pushed a commit to flutter/plugins that referenced this pull request Aug 16, 2022
@engine-flutter-autoroll
Roll Flutter from a0f1c67 to c873c21 (27 revisions) (#6275)
ba27a65 
* 7d1323c Updating expiring cirrus key. (flutter/flutter#109461)

* a85902a Roll Flutter Engine from de118a55ade0 to c354e0e04cea (2 revisions) (flutter/flutter#109462)

* 28de3d4 Roll Flutter Engine from c354e0e04cea to d1b18b5d6811 (1 revision) (flutter/flutter#109466)

* a624cb7 Keep `dirty` manipulations private to `Element` base class (flutter/flutter#109401)

* dce82f7 Remove deprecated Ruby File.exists? in helper script (flutter/flutter#109428)

* 7887ca5 Revert "Keep `dirty` manipulations private to `Element` base class (#109401)" (flutter/flutter#109481)

* 237a298 Roll Flutter Engine from d1b18b5d6811 to a2f3bd58ce73 (1 revision) (flutter/flutter#109472)

* fe2fc8d Single tap on the previous selection should toggle the toolbar on iOS… (flutter/flutter#108913)

* 696c6fb Roll Flutter Engine from a2f3bd58ce73 to fb19700742c3 (6 revisions) (flutter/flutter#109482)

* 17bc0ce Roll Flutter Engine from fb19700742c3 to 2180e62f6c7e (1 revision) (flutter/flutter#109483)

* 4265015 Roll Flutter Engine from 2180e62f6c7e to cd1a1cb757f5 (1 revision) (flutter/flutter#109488)

* c142dd3 Roll Flutter Engine from cd1a1cb757f5 to 5cc5c5f04f0a (1 revision) (flutter/flutter#109490)

* 8a55c36 Roll Flutter Engine from 5cc5c5f04f0a to 18dca3de7496 (2 revisions) (flutter/flutter#109493)

* d50c5b1 Roll Flutter Engine from 18dca3de7496 to 83771593cb55 (1 revision) (flutter/flutter#109505)

* 97901da Cleaner test.dart output. (flutter/flutter#109206)

* fb3c8ea Roll Flutter Engine from 83771593cb55 to f49a617535af (1 revision) (flutter/flutter#109509)

* 5fcd9c2 Update README.md (flutter/flutter#109506)

* 4dd7065 Add onOpened callback to PopupMenuButton (flutter/flutter#103753)

* ed3238e Roll Flutter Engine from f49a617535af to cc9f4c63b7e5 (1 revision) (flutter/flutter#109518)

* 8b1ca3f Roll Flutter Engine from cc9f4c63b7e5 to 4656c2f46cad (1 revision) (flutter/flutter#109524)

* 20ffb32 Roll Flutter Engine from 4656c2f46cad to 16fb19e72f88 (1 revision) (flutter/flutter#109526)

* 087750f Roll Flutter Engine from 16fb19e72f88 to 9c3c233e2639 (1 revision) (flutter/flutter#109532)

* 4aba124 Roll Flutter Engine from 9c3c233e2639 to f0c3829e90ce (1 revision) (flutter/flutter#109536)

* 2bce108 Roll Plugins from 9fb7654 to 094f1c3 (7 revisions) (flutter/flutter#109543)

* 97d9a2f Roll Flutter Engine from f0c3829e90ce to 8c019cdd446f (2 revisions) (flutter/flutter#109548)

* 458d618 Roll Flutter Engine from 8c019cdd446f to 198b0051a5a2 (1 revision) (flutter/flutter#109552)

* c873c21 Roll Flutter Engine from 198b0051a5a2 to 33fccf564973 (1 revision) (flutter/flutter#109557)
camsim99 pushed a commit to camsim99/plugins that referenced this pull request Aug 23, 2022
@engine-flutter-autoroll @camsim99
Roll Flutter from a0f1c67 to c873c21 (27 revisions) (flutter#6275)
11a49bb 
* 7d1323c Updating expiring cirrus key. (flutter/flutter#109461)

* a85902a Roll Flutter Engine from de118a55ade0 to c354e0e04cea (2 revisions) (flutter/flutter#109462)

* 28de3d4 Roll Flutter Engine from c354e0e04cea to d1b18b5d6811 (1 revision) (flutter/flutter#109466)

* a624cb7 Keep `dirty` manipulations private to `Element` base class (flutter/flutter#109401)

* dce82f7 Remove deprecated Ruby File.exists? in helper script (flutter/flutter#109428)

* 7887ca5 Revert "Keep `dirty` manipulations private to `Element` base class (#109401)" (flutter/flutter#109481)

* 237a298 Roll Flutter Engine from d1b18b5d6811 to a2f3bd58ce73 (1 revision) (flutter/flutter#109472)

* fe2fc8d Single tap on the previous selection should toggle the toolbar on iOS… (flutter/flutter#108913)

* 696c6fb Roll Flutter Engine from a2f3bd58ce73 to fb19700742c3 (6 revisions) (flutter/flutter#109482)

* 17bc0ce Roll Flutter Engine from fb19700742c3 to 2180e62f6c7e (1 revision) (flutter/flutter#109483)

* 4265015 Roll Flutter Engine from 2180e62f6c7e to cd1a1cb757f5 (1 revision) (flutter/flutter#109488)

* c142dd3 Roll Flutter Engine from cd1a1cb757f5 to 5cc5c5f04f0a (1 revision) (flutter/flutter#109490)

* 8a55c36 Roll Flutter Engine from 5cc5c5f04f0a to 18dca3de7496 (2 revisions) (flutter/flutter#109493)

* d50c5b1 Roll Flutter Engine from 18dca3de7496 to 83771593cb55 (1 revision) (flutter/flutter#109505)

* 97901da Cleaner test.dart output. (flutter/flutter#109206)

* fb3c8ea Roll Flutter Engine from 83771593cb55 to f49a617535af (1 revision) (flutter/flutter#109509)

* 5fcd9c2 Update README.md (flutter/flutter#109506)

* 4dd7065 Add onOpened callback to PopupMenuButton (flutter/flutter#103753)

* ed3238e Roll Flutter Engine from f49a617535af to cc9f4c63b7e5 (1 revision) (flutter/flutter#109518)

* 8b1ca3f Roll Flutter Engine from cc9f4c63b7e5 to 4656c2f46cad (1 revision) (flutter/flutter#109524)

* 20ffb32 Roll Flutter Engine from 4656c2f46cad to 16fb19e72f88 (1 revision) (flutter/flutter#109526)

* 087750f Roll Flutter Engine from 16fb19e72f88 to 9c3c233e2639 (1 revision) (flutter/flutter#109532)

* 4aba124 Roll Flutter Engine from 9c3c233e2639 to f0c3829e90ce (1 revision) (flutter/flutter#109536)

* 2bce108 Roll Plugins from 9fb7654 to 094f1c3 (7 revisions) (flutter/flutter#109543)

* 97d9a2f Roll Flutter Engine from f0c3829e90ce to 8c019cdd446f (2 revisions) (flutter/flutter#109548)

* 458d618 Roll Flutter Engine from 8c019cdd446f to 198b0051a5a2 (1 revision) (flutter/flutter#109552)

* c873c21 Roll Flutter Engine from 198b0051a5a2 to 33fccf564973 (1 revision) (flutter/flutter#109557)
moisefeelin pushed a commit to feelinproject/plugins that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll @moisefeelin
Roll Flutter from a0f1c67 to c873c21 (27 revisions) (flutter#6275)
399d6db 
* 7d1323c Updating expiring cirrus key. (flutter/flutter#109461)

* a85902a Roll Flutter Engine from de118a55ade0 to c354e0e04cea (2 revisions) (flutter/flutter#109462)

* 28de3d4 Roll Flutter Engine from c354e0e04cea to d1b18b5d6811 (1 revision) (flutter/flutter#109466)

* a624cb7 Keep `dirty` manipulations private to `Element` base class (flutter/flutter#109401)

* dce82f7 Remove deprecated Ruby File.exists? in helper script (flutter/flutter#109428)

* 7887ca5 Revert "Keep `dirty` manipulations private to `Element` base class (#109401)" (flutter/flutter#109481)

* 237a298 Roll Flutter Engine from d1b18b5d6811 to a2f3bd58ce73 (1 revision) (flutter/flutter#109472)

* fe2fc8d Single tap on the previous selection should toggle the toolbar on iOS… (flutter/flutter#108913)

* 696c6fb Roll Flutter Engine from a2f3bd58ce73 to fb19700742c3 (6 revisions) (flutter/flutter#109482)

* 17bc0ce Roll Flutter Engine from fb19700742c3 to 2180e62f6c7e (1 revision) (flutter/flutter#109483)

* 4265015 Roll Flutter Engine from 2180e62f6c7e to cd1a1cb757f5 (1 revision) (flutter/flutter#109488)

* c142dd3 Roll Flutter Engine from cd1a1cb757f5 to 5cc5c5f04f0a (1 revision) (flutter/flutter#109490)

* 8a55c36 Roll Flutter Engine from 5cc5c5f04f0a to 18dca3de7496 (2 revisions) (flutter/flutter#109493)

* d50c5b1 Roll Flutter Engine from 18dca3de7496 to 83771593cb55 (1 revision) (flutter/flutter#109505)

* 97901da Cleaner test.dart output. (flutter/flutter#109206)

* fb3c8ea Roll Flutter Engine from 83771593cb55 to f49a617535af (1 revision) (flutter/flutter#109509)

* 5fcd9c2 Update README.md (flutter/flutter#109506)

* 4dd7065 Add onOpened callback to PopupMenuButton (flutter/flutter#103753)

* ed3238e Roll Flutter Engine from f49a617535af to cc9f4c63b7e5 (1 revision) (flutter/flutter#109518)

* 8b1ca3f Roll Flutter Engine from cc9f4c63b7e5 to 4656c2f46cad (1 revision) (flutter/flutter#109524)

* 20ffb32 Roll Flutter Engine from 4656c2f46cad to 16fb19e72f88 (1 revision) (flutter/flutter#109526)

* 087750f Roll Flutter Engine from 16fb19e72f88 to 9c3c233e2639 (1 revision) (flutter/flutter#109532)

* 4aba124 Roll Flutter Engine from 9c3c233e2639 to f0c3829e90ce (1 revision) (flutter/flutter#109536)

* 2bce108 Roll Plugins from 9fb7654 to 094f1c3 (7 revisions) (flutter/flutter#109543)

* 97d9a2f Roll Flutter Engine from f0c3829e90ce to 8c019cdd446f (2 revisions) (flutter/flutter#109548)

* 458d618 Roll Flutter Engine from 8c019cdd446f to 198b0051a5a2 (1 revision) (flutter/flutter#109552)

* c873c21 Roll Flutter Engine from 198b0051a5a2 to 33fccf564973 (1 revision) (flutter/flutter#109557)
@danagbemava-nc danagbemava-nc mentioned this pull request Sep 16, 2022
Closed
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from a0f1c67 to c873c21 (27 revisions) (flutter#6275)
29585ff 
* 7d1323c Updating expiring cirrus key. (flutter/flutter#109461)

* a85902a Roll Flutter Engine from de118a55ade0 to c354e0e04cea (2 revisions) (flutter/flutter#109462)

* 28de3d4 Roll Flutter Engine from c354e0e04cea to d1b18b5d6811 (1 revision) (flutter/flutter#109466)

* a624cb7 Keep `dirty` manipulations private to `Element` base class (flutter/flutter#109401)

* dce82f7 Remove deprecated Ruby File.exists? in helper script (flutter/flutter#109428)

* 7887ca5 Revert "Keep `dirty` manipulations private to `Element` base class (#109401)" (flutter/flutter#109481)

* 237a298 Roll Flutter Engine from d1b18b5d6811 to a2f3bd58ce73 (1 revision) (flutter/flutter#109472)

* fe2fc8d Single tap on the previous selection should toggle the toolbar on iOS… (flutter/flutter#108913)

* 696c6fb Roll Flutter Engine from a2f3bd58ce73 to fb19700742c3 (6 revisions) (flutter/flutter#109482)

* 17bc0ce Roll Flutter Engine from fb19700742c3 to 2180e62f6c7e (1 revision) (flutter/flutter#109483)

* 4265015 Roll Flutter Engine from 2180e62f6c7e to cd1a1cb757f5 (1 revision) (flutter/flutter#109488)

* c142dd3 Roll Flutter Engine from cd1a1cb757f5 to 5cc5c5f04f0a (1 revision) (flutter/flutter#109490)

* 8a55c36 Roll Flutter Engine from 5cc5c5f04f0a to 18dca3de7496 (2 revisions) (flutter/flutter#109493)

* d50c5b1 Roll Flutter Engine from 18dca3de7496 to 83771593cb55 (1 revision) (flutter/flutter#109505)

* 97901da Cleaner test.dart output. (flutter/flutter#109206)

* fb3c8ea Roll Flutter Engine from 83771593cb55 to f49a617535af (1 revision) (flutter/flutter#109509)

* 5fcd9c2 Update README.md (flutter/flutter#109506)

* 4dd7065 Add onOpened callback to PopupMenuButton (flutter/flutter#103753)

* ed3238e Roll Flutter Engine from f49a617535af to cc9f4c63b7e5 (1 revision) (flutter/flutter#109518)

* 8b1ca3f Roll Flutter Engine from cc9f4c63b7e5 to 4656c2f46cad (1 revision) (flutter/flutter#109524)

* 20ffb32 Roll Flutter Engine from 4656c2f46cad to 16fb19e72f88 (1 revision) (flutter/flutter#109526)

* 087750f Roll Flutter Engine from 16fb19e72f88 to 9c3c233e2639 (1 revision) (flutter/flutter#109532)

* 4aba124 Roll Flutter Engine from 9c3c233e2639 to f0c3829e90ce (1 revision) (flutter/flutter#109536)

* 2bce108 Roll Plugins from 9fb7654 to 094f1c3 (7 revisions) (flutter/flutter#109543)

* 97d9a2f Roll Flutter Engine from f0c3829e90ce to 8c019cdd446f (2 revisions) (flutter/flutter#109548)

* 458d618 Roll Flutter Engine from 8c019cdd446f to 198b0051a5a2 (1 revision) (flutter/flutter#109552)

* c873c21 Roll Flutter Engine from 198b0051a5a2 to 33fccf564973 (1 revision) (flutter/flutter#109557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support onShowPopupMenu on PopupMenuButton
4 participants
@limonadev @gspencergoog @goderbauer @CaseyHillers