fixes FadeInImage for an edge case #111035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
framework
werainkhatri
force-pushed
the
fix-fadeinimage-edgecase
branch
from
7da5c71
to
5b95b91
Compare
chunhtai
reviewed
Sep 6, 2022
werainkhatri
force-pushed
the
fix-fadeinimage-edgecase
branch
from
5b95b91
to
f0af5b0
Compare
chunhtai
reviewed
Sep 6, 2022
…y loaded but second isn't
werainkhatri
force-pushed
the
fix-fadeinimage-edgecase
branch
from
f0af5b0
to
0c2af87
Compare
|
cc @dnfield for secondary review |
dnfield
approved these changes
Sep 7, 2022
Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
werainkhatri
added
the
autosubmit
This was referenced Sep 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 8, 2022
|
Sorry, but is it known when this will get released on stable? On Flutter 3.3.3 this is still a problem and I was wondering how to work around that. |
|
Can we have this in stable please? We had to downgrade to 3.0.0 to avoid this issue. |
|
requesting cp. See the original issue |
chunhtai
pushed a commit
to chunhtai/flutter
that referenced
this pull request
Oct 6, 2022
godofredoc
pushed a commit
that referenced
this pull request
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where first image was synchronously loaded but second isn't.
when first image is precached and then the image is changed to an uncached one, placeholder's opacity animation was never initialized but the code assumed it'll be if the image is not synchronously loaded.
adds regression test for it.
fixes #111011
caused by #94601
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.