Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Fix kIsWeb for Dart2wasm. #112122

Merged
merged 2 commits into from Oct 4, 2022
Merged

Conversation

joshualitt
Copy link
Contributor

No description provided.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems. framework flutter/packages/flutter repository. See also f: labels. labels Sep 21, 2022
@joshualitt joshualitt force-pushed the upstream-2 branch 2 times, most recently from 92e1f38 to cc03c29 Compare September 21, 2022 23:08
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest in peace, my hacky friend.

LGTM

packages/flutter/lib/src/foundation/constants.dart Outdated Show resolved Hide resolved
@justinmc justinmc requested review from justinmc and removed request for justinmc September 22, 2022 21:53
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I'm somehow sad to see this go!

@joshualitt
Copy link
Contributor Author

Just a heads up, this CL is waiting for an analyzer roll, and will probably fail until those changes land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: text input Entering text in a text field or keyboard related problems. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants