Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated ProgressIndicator to M3 #112139

Merged
merged 3 commits into from Sep 23, 2022
Merged

Updated ProgressIndicator to M3 #112139

merged 3 commits into from Sep 23, 2022

Conversation

QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Sep 22, 2022 •
edited

Part of: #91605

Updated the CircularProgressIndicator widget and LinearProgressIndicator widget with support for Material Design 3.

Screen Shot 2022-09-21 at 7 01 55 PM

Screen Shot 2022-09-21 at 7 02 32 PM

In order to use the ProgressIndicator with the new Material 3 defaults, turn on the useMaterial3 flag in the ThemeData:

  return MaterialApp(
    theme: ThemeData(useMaterial3: true),
    // ...
  );

Fixes #111449

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Sep 22, 2022
@QuncCccccc QuncCccccc changed the title Updated CircularProgressIndicator and LinearProgressIndicator to M3 Updated ProgressIndicator to M3 Sep 22, 2022
@QuncCccccc QuncCccccc force-pushed the update_progress_indicator_to_m3 branch from 8a550d3 to daf91bd Compare September 22, 2022 19:18
@QuncCccccc QuncCccccc marked this pull request as ready for review September 22, 2022 21:12
HansMuller
HansMuller approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/lib/src/material/progress_indicator.dart Show resolved Hide resolved
@QuncCccccc QuncCccccc merged commit e167162 into flutter:master Sep 23, 2022
121 checks passed
This was referenced Sep 24, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 24, 2022
@engine-flutter-autoroll
e16716283 Updated ProgressIndicator to M3 (flutter/flutter#112139)
113bb4c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 24, 2022
@engine-flutter-autoroll
e167162 Updated ProgressIndicator to M3 (flutter/flutter#112139)
1b2d97a
akshdeep-singh
akshdeep-singh reviewed Sep 24, 2022
View reviewed changes
packages/flutter/lib/src/material/progress_indicator.dart

if (Theme.of(context).useMaterial3) {
progressIndicator = SizedBox(
height: _CircularProgressIndicatorDefaultsM3.circularProgressIndicatorSize,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes it impossible to make the circular indicator larger than this size!

@akshdeep-singh
Copy link
Contributor

@QuncCccccc I am not able to make CircularProgressIndicator larger than its default size.

@QuncCccccc QuncCccccc mentioned this pull request Sep 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshdeep-singh akshdeep-singh akshdeep-singh left review comments

@HansMuller HansMuller HansMuller approved these changes

@guidezpl guidezpl guidezpl approved these changes

@darrenaustin darrenaustin Awaiting requested review from darrenaustin

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ProgressIndicator to support Material 3
4 participants
@QuncCccccc @akshdeep-singh @HansMuller @guidezpl