Support Material 3 in bottom sheet #112466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
d: api docs
hangyujin
force-pushed
the
M3-BottomSheets
branch
from
9a027ae
to
c90f531
Compare
darrenaustin
suggested changes
Sep 30, 2022
There was a problem hiding this comment.
Nice work @hangyujin. Just have a few suggestions and a question about the M2 defaults. Thx.
| @@ -177,6 +177,12 @@ abstract class TokenTemplate { | |||
| if (topLeft == topRight && topLeft == bottomLeft && topLeft == bottomRight) { | |||
| return '${prefix}RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular($topLeft)))'; | |||
| } | |||
| if (topLeft == topRight && bottomLeft == bottomRight) { | |||
| class MyApp extends StatelessWidget { | ||
| const MyApp({super.key}); | ||
|
|
||
| static const String _title = 'Flutter Code Sample'; |
There was a problem hiding this comment.
I would just inline this and make it something like: 'Bottom Sheet Sample'.
| @@ -526,10 +529,11 @@ class _ModalBottomSheetRoute<T> extends PopupRoute<T> { | |||
| child: Builder( | |||
| builder: (BuildContext context) { | |||
| final BottomSheetThemeData sheetTheme = Theme.of(context).bottomSheetTheme; | |||
| final BottomSheetThemeData defaults = Theme.of(context).useMaterial3 ? _BottomSheetDefaultsM3(context) : const BottomSheetThemeData(); | |||
There was a problem hiding this comment.
Are the M2 defaults really just an empty BottomSheetThemeData? I am surprised we didn't have some static constants for some of these.
There was a problem hiding this comment.
Yeah I didn't find any default value for M2
| : super( | ||
| elevation: 1.0, | ||
| modalElevation: 1.0, | ||
| shape: const RoundedRectangleBorder(borderRadius: BorderRadius.vertical(top: Radius.circular(28.0),)), |
There was a problem hiding this comment.
The generated extra comma here would be nice to get rid of. Kind of a pain to do with the template code, but it would look better here.
Co-authored-by: Darren Austin <darren@darrenaustin.org>
hangyujin
force-pushed
the
M3-BottomSheets
branch
from
6363149
to
cc18ec9
Compare
hangyujin
added
the
autosubmit
This was referenced Oct 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 11, 2022
Oleh-Sv
pushed a commit
to Oleh-Sv/flutter
that referenced
this pull request
Oct 13, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
issue: #111448, #111688
fixes #111448
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.