Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Material 3 Divider and VerticalDivider #112655

Merged
merged 1 commit into from Sep 29, 2022
Merged

Add support for Material 3 Divider and VerticalDivider #112655

merged 1 commit into from Sep 29, 2022

Conversation

darrenaustin
Copy link
Contributor

@darrenaustin darrenaustin commented Sep 29, 2022 •
edited

This is a reland of #112378 which had to be reverted due to some golden tests that failed.

Those have been resolved, but wanted to add a few changes to @TahaTesser's PR.

In addition to adding M3 Divider support, this also adds M3 support for the Divider.createBorderSide function.

Thanks @TahaTesser for the original work on this!

Fixes: #112169

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added d: api docs https://docs.flutter.dev/ d: examples Sample code and demos. documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Sep 29, 2022
@darrenaustin darrenaustin marked this pull request as ready for review September 29, 2022 17:50
@darrenaustin darrenaustin mentioned this pull request Sep 29, 2022
Merged
HansMuller
HansMuller approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TahaTesser
TahaTesser approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darrenaustin darrenaustin merged commit 2bf83dd into flutter:master Sep 29, 2022
120 checks passed
@darrenaustin darrenaustin deleted the m3_divider branch September 29, 2022 18:30
This was referenced Sep 30, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2022
@engine-flutter-autoroll
2bf83dd86 Add support for Material 3 Divider and VerticalDivider (flu…
20106e1 
…tter/flutter#112655)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 30, 2022
@engine-flutter-autoroll
2bf83dd Add support for Material 3 Divider and VerticalDivider (flutt…
9bcefa1 
…er/flutter#112655)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

@TahaTesser TahaTesser TahaTesser approved these changes

@guidezpl guidezpl

Assignees
No one assigned
Labels
d: api docs https://docs.flutter.dev/ d: examples Sample code and demos. documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Divider to support Material 3
3 participants
@darrenaustin @HansMuller @TahaTesser