Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AnimatedIcons previews and examples #113700

Merged
merged 1 commit into from Oct 19, 2022

Conversation

TahaTesser
Copy link
Member

fixes #113075

This PR does the following:

  1. Add AnimatedIcons previews (using assets added in Add AnimatedIcons diagrams assets-for-api-docs#202)

  2. Update the basic AnimatedIcon example from the snippet to the Dartpad example.

Screen.Recording.2022-10-19.at.16.32.57.mov
  1. Add an example that shows all AnimatedIcons (inspired by the Widget of the week video for AnimatedIcon)
Screen.Recording.2022-10-19.at.16.31.39.mov
  1. Link AnimatedIcons in Icons and vice versa.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added d: api docs https://docs.flutter.dev/ d: examples Sample code and demos. documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Oct 19, 2022
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 19, 2022
@auto-submit auto-submit bot merged commit 8815f60 into flutter:master Oct 19, 2022
64 checks passed
@TahaTesser TahaTesser deleted the animated_icons_docs branch October 19, 2022 17:15
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 20, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 20, 2022
/// {@tool dartpad}
/// This example showcases all the available [AnimatedIcons] in a [GridView].
/// The icons are animated forward and reverse in a loop.
///
/// ** See code in examples/api/lib/material/animated_icon/animated_icon.1.dart **
/// {@end-tool}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TahaTesser I think this should be on the AnimatedIcons page, WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App d: api docs https://docs.flutter.dev/ d: examples Sample code and demos. documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnimatedIcons API doc should include icon images
3 participants