Remove RouteSetting.copyWith #113860
Merged
Remove RouteSetting.copyWith #113860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: routes
|
Is this used in google3? |
|
yes it is used internally, they are used in onGenerateRoute which is probably easy to migrate. I still think we should remove it so that we don't create a foot gun for page subclasses. I will prepare for an internal migration |
chunhtai
added a commit
to flutter/website
that referenced
this pull request
Oct 26, 2022
needs to wait for pr to land flutter/flutter#113860
3 tasks
chunhtai
added
the
autosubmit
|
upstream migration https://critique.corp.google.com/cl/484006186 |
This was referenced Oct 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 28, 2022
liangxianzhe
pushed a commit
to liangxianzhe/flutter
that referenced
this pull request
Nov 1, 2022
sfshaza2
added a commit
to flutter/website
that referenced
this pull request
Nov 1, 2022
* Create migration guide for RouteSettings.copywith needs to wait for pr to land flutter/flutter#113860 * Update routesettings-copywith-migration.md * Update routesettings-copywith-migration.md * Update routesettings-copywith-migration.md * Update routesettings-copywith-migration.md * Update src/release/breaking-changes/routesettings-copywith-migration.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com> * Update src/release/breaking-changes/routesettings-copywith-migration.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com> * Update src/release/breaking-changes/routesettings-copywith-migration.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com> * Update src/release/breaking-changes/routesettings-copywith-migration.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com> * add to index Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com> Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
leighajarett
pushed a commit
to vandadnp/flutter-website
that referenced
this pull request
Nov 8, 2022
* Create migration guide for RouteSettings.copywith needs to wait for pr to land flutter/flutter#113860 * Update routesettings-copywith-migration.md * Update routesettings-copywith-migration.md * Update routesettings-copywith-migration.md * Update routesettings-copywith-migration.md * Update src/release/breaking-changes/routesettings-copywith-migration.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com> * Update src/release/breaking-changes/routesettings-copywith-migration.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com> * Update src/release/breaking-changes/routesettings-copywith-migration.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com> * Update src/release/breaking-changes/routesettings-copywith-migration.md Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com> * add to index Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com> Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I am not sure how this can be useful, it is probably a relic that was forgotten during the nav refactoring. This also didn't work well since we introduced page class. Removing it and see if we will run into any breaking change
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.