Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change some required nullable parameters in tool to non-null #114115

Merged
merged 1 commit into from Nov 4, 2022
Merged

Change some required nullable parameters in tool to non-null #114115

merged 1 commit into from Nov 4, 2022

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Oct 26, 2022 •
edited

Make some nullable required parameters non-null where possible.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Oct 26, 2022
@flutter-dashboard flutter-dashboard bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Oct 26, 2022
@Hixie
Copy link
Contributor

Hixie commented Oct 26, 2022

In various places, we've used required nullable parameters to make it clear that a parameter is expected, even if in some cases it might be null. When reviewing this PR, it would be valuable to make sure that none of the cases here are examples of that kind of intentional API.

@jmagman
Copy link
Member Author

jmagman commented Oct 27, 2022

When reviewing this PR, it would be valuable to make sure that none of the cases here are examples of that kind of intentional API.

+1. A few of these should have been non-null, not required nullable.

@jmagman jmagman changed the title Make nullable parameters in tool not required Change some required nullable parameters in tool to non-null Oct 27, 2022
@jmagman jmagman marked this pull request as ready for review November 4, 2022 17:33
christopherfujino
christopherfujino approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 4, 2022
@auto-submit auto-submit bot merged commit c1d2b85 into flutter:master Nov 4, 2022
@jmagman jmagman deleted the required-null branch November 4, 2022 18:31
This was referenced Nov 5, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2022
@engine-flutter-autoroll
c1d2b854e Change some required nullable parameters in tool to non-null (
a68ff03 
flutter/flutter#114115)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 5, 2022
@engine-flutter-autoroll
c1d2b85 Change some required nullable parameters in tool to non-null (f…
201e4a3 
…lutter/flutter#114115)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 5, 2022
@engine-flutter-autoroll
Roll Flutter from 55e8cd178621 to e0e7027b6263 (20 revisions) (#2782)
bf3328c 
* 77d6ecb83 805b145d7 [web] Improve line breaker test exceptions (flutter/engine#37244) (flutter/flutter#114688)

* 5233fd922 Roll Plugins from 5c11747 to a279b9d (6 revisions) (flutter/flutter#114689)

* e1166e43f 287a3ab59 Roll Skia from c901cb6ae66f to 1272b520c082 (1 revision) (flutter/engine#37314) (flutter/flutter#114691)

* 48457d736 WidgetController.startGesture trackpad support (flutter/flutter#114631)

* c1d2b854e Change some required nullable parameters in tool to non-null (flutter/flutter#114115)

* cfb2f158d Roll Flutter Engine from 287a3ab59269 to e947833ceb5b (2 revisions) (flutter/flutter#114696)

* 80bf35519 Support keyboard selection in SelectabledRegion (flutter/flutter#112584)

* be83c98ed 5117e858e Fix typo in overlay platform view iOS test (flutter/engine#37262) (flutter/flutter#114705)

* 6ea01e6ae Roll Flutter Engine from 5117e858ed1e to 6950689ed775 (3 revisions) (flutter/flutter#114710)

* b187bc474 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114637)

* 01507bab5 Revert "Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (#114637)" (flutter/flutter#114715)

* 91a56cf15 roll packages (flutter/flutter#114366)

* d68af26ae Roll Flutter Engine from 6950689ed775 to 0933ca485a07 (3 revisions) (flutter/flutter#114714)

* 4fd0a9253 Remove auto_cleanup of xcode caches. (flutter/flutter#114719)

* 96f9ca830 Roll Flutter Engine from 0933ca485a07 to 28e1ea0cc5b1 (4 revisions) (flutter/flutter#114720)

* 1aada6fc5 [New Feature]Support mouse wheel event on the scrollbar widget (flutter/flutter#109659)

* 6265610b0 Roll Flutter Engine from 28e1ea0cc5b1 to ba390f2a7b7d (3 revisions) (flutter/flutter#114728)

* 140a57e96 Roll Flutter Engine from ba390f2a7b7d to 223a485ceb02 (3 revisions) (flutter/flutter#114732)

* 06ded49f7 Roll Flutter Engine from 223a485ceb02 to cf56eb5565e2 (3 revisions) (flutter/flutter#114735)

* e0e7027b6 9c45b0ebe Roll Fuchsia Mac SDK from jAKH68TYoKUA5HNS2... to Ua8Jtf8Zka9uxIVdl... (flutter/engine#37345) (flutter/flutter#114746)
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Nov 5, 2022
@engine-flutter-autoroll
Roll Flutter from 55e8cd1 to e0e7027 (20 revisions) (#6673)
f04ef73 
* 77d6ecb 805b145d7 [web] Improve line breaker test exceptions (flutter/engine#37244) (flutter/flutter#114688)

* 5233fd9 Roll Plugins from 5c11747 to a279b9d (6 revisions) (flutter/flutter#114689)

* e1166e4 287a3ab59 Roll Skia from c901cb6ae66f to 1272b520c082 (1 revision) (flutter/engine#37314) (flutter/flutter#114691)

* 48457d7 WidgetController.startGesture trackpad support (flutter/flutter#114631)

* c1d2b85 Change some required nullable parameters in tool to non-null (flutter/flutter#114115)

* cfb2f15 Roll Flutter Engine from 287a3ab59269 to e947833ceb5b (2 revisions) (flutter/flutter#114696)

* 80bf355 Support keyboard selection in SelectabledRegion (flutter/flutter#112584)

* be83c98 5117e858e Fix typo in overlay platform view iOS test (flutter/engine#37262) (flutter/flutter#114705)

* 6ea01e6 Roll Flutter Engine from 5117e858ed1e to 6950689ed775 (3 revisions) (flutter/flutter#114710)

* b187bc4 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114637)

* 01507ba Revert "Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (#114637)" (flutter/flutter#114715)

* 91a56cf roll packages (flutter/flutter#114366)

* d68af26 Roll Flutter Engine from 6950689ed775 to 0933ca485a07 (3 revisions) (flutter/flutter#114714)

* 4fd0a92 Remove auto_cleanup of xcode caches. (flutter/flutter#114719)

* 96f9ca8 Roll Flutter Engine from 0933ca485a07 to 28e1ea0cc5b1 (4 revisions) (flutter/flutter#114720)

* 1aada6f [New Feature]Support mouse wheel event on the scrollbar widget (flutter/flutter#109659)

* 6265610 Roll Flutter Engine from 28e1ea0cc5b1 to ba390f2a7b7d (3 revisions) (flutter/flutter#114728)

* 140a57e Roll Flutter Engine from ba390f2a7b7d to 223a485ceb02 (3 revisions) (flutter/flutter#114732)

* 06ded49 Roll Flutter Engine from 223a485ceb02 to cf56eb5565e2 (3 revisions) (flutter/flutter#114735)

* e0e7027 9c45b0ebe Roll Fuchsia Mac SDK from jAKH68TYoKUA5HNS2... to Ua8Jtf8Zka9uxIVdl... (flutter/engine#37345) (flutter/flutter#114746)
IVLIVS-III pushed a commit to IVLIVS-III/flutter_plugins_fork that referenced this pull request Nov 11, 2022
@engine-flutter-autoroll @IVLIVS-III
Roll Flutter from 55e8cd1 to e0e7027 (20 revisions) (flutter#6673)
ad466d6 
* 77d6ecb 805b145d7 [web] Improve line breaker test exceptions (flutter/engine#37244) (flutter/flutter#114688)

* 5233fd9 Roll Plugins from 5c11747 to a279b9d (6 revisions) (flutter/flutter#114689)

* e1166e4 287a3ab59 Roll Skia from c901cb6ae66f to 1272b520c082 (1 revision) (flutter/engine#37314) (flutter/flutter#114691)

* 48457d7 WidgetController.startGesture trackpad support (flutter/flutter#114631)

* c1d2b85 Change some required nullable parameters in tool to non-null (flutter/flutter#114115)

* cfb2f15 Roll Flutter Engine from 287a3ab59269 to e947833ceb5b (2 revisions) (flutter/flutter#114696)

* 80bf355 Support keyboard selection in SelectabledRegion (flutter/flutter#112584)

* be83c98 5117e858e Fix typo in overlay platform view iOS test (flutter/engine#37262) (flutter/flutter#114705)

* 6ea01e6 Roll Flutter Engine from 5117e858ed1e to 6950689ed775 (3 revisions) (flutter/flutter#114710)

* b187bc4 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114637)

* 01507ba Revert "Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (#114637)" (flutter/flutter#114715)

* 91a56cf roll packages (flutter/flutter#114366)

* d68af26 Roll Flutter Engine from 6950689ed775 to 0933ca485a07 (3 revisions) (flutter/flutter#114714)

* 4fd0a92 Remove auto_cleanup of xcode caches. (flutter/flutter#114719)

* 96f9ca8 Roll Flutter Engine from 0933ca485a07 to 28e1ea0cc5b1 (4 revisions) (flutter/flutter#114720)

* 1aada6f [New Feature]Support mouse wheel event on the scrollbar widget (flutter/flutter#109659)

* 6265610 Roll Flutter Engine from 28e1ea0cc5b1 to ba390f2a7b7d (3 revisions) (flutter/flutter#114728)

* 140a57e Roll Flutter Engine from ba390f2a7b7d to 223a485ceb02 (3 revisions) (flutter/flutter#114732)

* 06ded49 Roll Flutter Engine from 223a485ceb02 to cf56eb5565e2 (3 revisions) (flutter/flutter#114735)

* e0e7027 9c45b0ebe Roll Fuchsia Mac SDK from jAKH68TYoKUA5HNS2... to Ua8Jtf8Zka9uxIVdl... (flutter/engine#37345) (flutter/flutter#114746)
percula pushed a commit to percula/packages that referenced this pull request Nov 17, 2022
@engine-flutter-autoroll @percula
Roll Flutter from 55e8cd178621 to e0e7027b6263 (20 revisions) (flutte…
0e341bc 
…r#2782)

* 77d6ecb83 805b145d7 [web] Improve line breaker test exceptions (flutter/engine#37244) (flutter/flutter#114688)

* 5233fd922 Roll Plugins from 5c11747 to a279b9d (6 revisions) (flutter/flutter#114689)

* e1166e43f 287a3ab59 Roll Skia from c901cb6ae66f to 1272b520c082 (1 revision) (flutter/engine#37314) (flutter/flutter#114691)

* 48457d736 WidgetController.startGesture trackpad support (flutter/flutter#114631)

* c1d2b854e Change some required nullable parameters in tool to non-null (flutter/flutter#114115)

* cfb2f158d Roll Flutter Engine from 287a3ab59269 to e947833ceb5b (2 revisions) (flutter/flutter#114696)

* 80bf35519 Support keyboard selection in SelectabledRegion (flutter/flutter#112584)

* be83c98ed 5117e858e Fix typo in overlay platform view iOS test (flutter/engine#37262) (flutter/flutter#114705)

* 6ea01e6ae Roll Flutter Engine from 5117e858ed1e to 6950689ed775 (3 revisions) (flutter/flutter#114710)

* b187bc474 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114637)

* 01507bab5 Revert "Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (#114637)" (flutter/flutter#114715)

* 91a56cf15 roll packages (flutter/flutter#114366)

* d68af26ae Roll Flutter Engine from 6950689ed775 to 0933ca485a07 (3 revisions) (flutter/flutter#114714)

* 4fd0a9253 Remove auto_cleanup of xcode caches. (flutter/flutter#114719)

* 96f9ca830 Roll Flutter Engine from 0933ca485a07 to 28e1ea0cc5b1 (4 revisions) (flutter/flutter#114720)

* 1aada6fc5 [New Feature]Support mouse wheel event on the scrollbar widget (flutter/flutter#109659)

* 6265610b0 Roll Flutter Engine from 28e1ea0cc5b1 to ba390f2a7b7d (3 revisions) (flutter/flutter#114728)

* 140a57e96 Roll Flutter Engine from ba390f2a7b7d to 223a485ceb02 (3 revisions) (flutter/flutter#114732)

* 06ded49f7 Roll Flutter Engine from 223a485ceb02 to cf56eb5565e2 (3 revisions) (flutter/flutter#114735)

* e0e7027b6 9c45b0ebe Roll Fuchsia Mac SDK from jAKH68TYoKUA5HNS2... to Ua8Jtf8Zka9uxIVdl... (flutter/engine#37345) (flutter/flutter#114746)
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 21, 2022
@engine-flutter-autoroll @adam-harwood
Roll Flutter from 55e8cd1 to e0e7027 (20 revisions) (flutter#6673)
854dd32 
* 77d6ecb 805b145d7 [web] Improve line breaker test exceptions (flutter/engine#37244) (flutter/flutter#114688)

* 5233fd9 Roll Plugins from 5c11747 to a279b9d (6 revisions) (flutter/flutter#114689)

* e1166e4 287a3ab59 Roll Skia from c901cb6ae66f to 1272b520c082 (1 revision) (flutter/engine#37314) (flutter/flutter#114691)

* 48457d7 WidgetController.startGesture trackpad support (flutter/flutter#114631)

* c1d2b85 Change some required nullable parameters in tool to non-null (flutter/flutter#114115)

* cfb2f15 Roll Flutter Engine from 287a3ab59269 to e947833ceb5b (2 revisions) (flutter/flutter#114696)

* 80bf355 Support keyboard selection in SelectabledRegion (flutter/flutter#112584)

* be83c98 5117e858e Fix typo in overlay platform view iOS test (flutter/engine#37262) (flutter/flutter#114705)

* 6ea01e6 Roll Flutter Engine from 5117e858ed1e to 6950689ed775 (3 revisions) (flutter/flutter#114710)

* b187bc4 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114637)

* 01507ba Revert "Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (#114637)" (flutter/flutter#114715)

* 91a56cf roll packages (flutter/flutter#114366)

* d68af26 Roll Flutter Engine from 6950689ed775 to 0933ca485a07 (3 revisions) (flutter/flutter#114714)

* 4fd0a92 Remove auto_cleanup of xcode caches. (flutter/flutter#114719)

* 96f9ca8 Roll Flutter Engine from 0933ca485a07 to 28e1ea0cc5b1 (4 revisions) (flutter/flutter#114720)

* 1aada6f [New Feature]Support mouse wheel event on the scrollbar widget (flutter/flutter#109659)

* 6265610 Roll Flutter Engine from 28e1ea0cc5b1 to ba390f2a7b7d (3 revisions) (flutter/flutter#114728)

* 140a57e Roll Flutter Engine from ba390f2a7b7d to 223a485ceb02 (3 revisions) (flutter/flutter#114732)

* 06ded49 Roll Flutter Engine from 223a485ceb02 to cf56eb5565e2 (3 revisions) (flutter/flutter#114735)

* e0e7027 9c45b0ebe Roll Fuchsia Mac SDK from jAKH68TYoKUA5HNS2... to Ua8Jtf8Zka9uxIVdl... (flutter/engine#37345) (flutter/flutter#114746)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@jmagman @shogohida
Change some required nullable parameters in tool to non-null (flutter…
b0abe13 
…#114115)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@jmagman @gspencergoog
Change some required nullable parameters in tool to non-null (flutter…
8736e72 
…#114115)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from 55e8cd1 to e0e7027 (20 revisions) (flutter#6673)
252434f 
* 77d6ecb 805b145d7 [web] Improve line breaker test exceptions (flutter/engine#37244) (flutter/flutter#114688)

* 5233fd9 Roll Plugins from 5c11747 to a279b9d (6 revisions) (flutter/flutter#114689)

* e1166e4 287a3ab59 Roll Skia from c901cb6ae66f to 1272b520c082 (1 revision) (flutter/engine#37314) (flutter/flutter#114691)

* 48457d7 WidgetController.startGesture trackpad support (flutter/flutter#114631)

* c1d2b85 Change some required nullable parameters in tool to non-null (flutter/flutter#114115)

* cfb2f15 Roll Flutter Engine from 287a3ab59269 to e947833ceb5b (2 revisions) (flutter/flutter#114696)

* 80bf355 Support keyboard selection in SelectabledRegion (flutter/flutter#112584)

* be83c98 5117e858e Fix typo in overlay platform view iOS test (flutter/engine#37262) (flutter/flutter#114705)

* 6ea01e6 Roll Flutter Engine from 5117e858ed1e to 6950689ed775 (3 revisions) (flutter/flutter#114710)

* b187bc4 Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (flutter/flutter#114637)

* 01507ba Revert "Switch the way we retrieve the vm_service_port from /hub to iquery, on device. (#114637)" (flutter/flutter#114715)

* 91a56cf roll packages (flutter/flutter#114366)

* d68af26 Roll Flutter Engine from 6950689ed775 to 0933ca485a07 (3 revisions) (flutter/flutter#114714)

* 4fd0a92 Remove auto_cleanup of xcode caches. (flutter/flutter#114719)

* 96f9ca8 Roll Flutter Engine from 0933ca485a07 to 28e1ea0cc5b1 (4 revisions) (flutter/flutter#114720)

* 1aada6f [New Feature]Support mouse wheel event on the scrollbar widget (flutter/flutter#109659)

* 6265610 Roll Flutter Engine from 28e1ea0cc5b1 to ba390f2a7b7d (3 revisions) (flutter/flutter#114728)

* 140a57e Roll Flutter Engine from ba390f2a7b7d to 223a485ceb02 (3 revisions) (flutter/flutter#114732)

* 06ded49 Roll Flutter Engine from 223a485ceb02 to cf56eb5565e2 (3 revisions) (flutter/flutter#114735)

* e0e7027 9c45b0ebe Roll Fuchsia Mac SDK from jAKH68TYoKUA5HNS2... to Ua8Jtf8Zka9uxIVdl... (flutter/engine#37345) (flutter/flutter#114746)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees

@jmagman jmagman

Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmagman @Hixie @christopherfujino