Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[tools]validation basic Xcode settings for build ipa" #114615

Merged
merged 1 commit into from Nov 3, 2022
Merged

Revert "[tools]validation basic Xcode settings for build ipa" #114615

merged 1 commit into from Nov 3, 2022

Conversation

zanderso
Copy link
Member

@zanderso zanderso commented Nov 3, 2022

@flutter-dashboard flutter-dashboard bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Nov 3, 2022
@zanderso zanderso added revert Label used to revert changes in a closed and merged pull request. autosubmit Merge PR when tree becomes green via auto submit App warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label. labels Nov 3, 2022
@auto-submit auto-submit bot merged commit 0943693 into master Nov 3, 2022
@auto-submit auto-submit bot deleted the revert-113412-tools_build_ipa_validate_basic_xcode_settings branch November 3, 2022 15:23
@auto-submit auto-submit bot mentioned this pull request Nov 3, 2022
Closed
This was referenced Nov 4, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2022
@engine-flutter-autoroll
0943693e8 Revert "[tools]validation basic Xcode settings for build ip…
805a873 
…a (#113412)" (flutter/flutter#114615)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 4, 2022
@engine-flutter-autoroll
0943693 Revert "[tools]validation basic Xcode settings for build ipa …
7553704 
…(#113412)" (flutter/flutter#114615)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 4, 2022
@engine-flutter-autoroll
Roll Flutter from e6300da2c39f to 55e8cd178621 (17 revisions) (#2780)
be60374 
* 0943693e8 Revert "[tools]validation basic Xcode settings for build ipa (#113412)" (flutter/flutter#114615)

* a440c4689 Do not assume that pub is the first command run by "flutter create" (flutter/flutter#114621)

* 33b81ed95 fixes for incoming linter (flutter/flutter#113794)

* 0186b1496 Fix the path where footer is written. (flutter/flutter#114469)

* 44ecbbcc5 Roll Flutter Engine from 840a7b346216 to 66b244d9fa0a (25 revisions) (flutter/flutter#114640)

* 2ce62b3a0 Roll Flutter Engine from 66b244d9fa0a to e3c51631a9b5 (2 revisions) (flutter/flutter#114643)

* 8a9ddade9 [tools]validation basic Xcode settings for build ipa (#113412) (flutter/flutter#114634)

* 009fa69f3 Revert "Scribble mixin (#104128)" (flutter/flutter#114647)

* 125b9a769 Roll Flutter Engine from e3c51631a9b5 to ed31c3d76df5 (2 revisions) (flutter/flutter#114648)

* 9f6090c9a Revert "Fix text field label animation duration and curve" (flutter/flutter#114646)

* 44b6cd2ec Roll Flutter Engine from ed31c3d76df5 to fb7cde697062 (2 revisions) (flutter/flutter#114651)

* fca260a15 Roll Flutter Engine from fb7cde697062 to 69a275300a28 (7 revisions) (flutter/flutter#114667)

* 7bee6e8af 4b970fca0 Roll Dart SDK from c6e0307f3849 to 35b0cc8ac48b (2 revisions) (flutter/engine#37308) (flutter/flutter#114668)

* 43606d136 0a2d451b3 Roll Skia from b8209dce9a48 to 7eac7e7547e7 (1 revision) (flutter/engine#37309) (flutter/flutter#114670)

* 55fac571b 2f90bda40 Merge AccessibilityBridge and AccessibilityBridgeDelegate (flutter/engine#36597) (flutter/flutter#114674)

* 4b7106c5b c5cc559db Roll Fuchsia Linux SDK from -0Xq1c-TncmWBWzqg... to 7e3H7isxOF6vqMDTT... (flutter/engine#37311) (flutter/flutter#114678)

* 55e8cd178 449fcc8b8 Roll Skia from 7eac7e7547e7 to c901cb6ae66f (1 revision) (flutter/engine#37313) (flutter/flutter#114683)
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Nov 4, 2022
@engine-flutter-autoroll
Roll Flutter from e6300da to 55e8cd1 (17 revisions) (#6670)
a279b9d 
* 0943693 Revert "[tools]validation basic Xcode settings for build ipa (#113412)" (flutter/flutter#114615)

* a440c46 Do not assume that pub is the first command run by "flutter create" (flutter/flutter#114621)

* 33b81ed fixes for incoming linter (flutter/flutter#113794)

* 0186b14 Fix the path where footer is written. (flutter/flutter#114469)

* 44ecbbc Roll Flutter Engine from 840a7b346216 to 66b244d9fa0a (25 revisions) (flutter/flutter#114640)

* 2ce62b3 Roll Flutter Engine from 66b244d9fa0a to e3c51631a9b5 (2 revisions) (flutter/flutter#114643)

* 8a9ddad [tools]validation basic Xcode settings for build ipa (#113412) (flutter/flutter#114634)

* 009fa69 Revert "Scribble mixin (#104128)" (flutter/flutter#114647)

* 125b9a7 Roll Flutter Engine from e3c51631a9b5 to ed31c3d76df5 (2 revisions) (flutter/flutter#114648)

* 9f6090c Revert "Fix text field label animation duration and curve" (flutter/flutter#114646)

* 44b6cd2 Roll Flutter Engine from ed31c3d76df5 to fb7cde697062 (2 revisions) (flutter/flutter#114651)

* fca260a Roll Flutter Engine from fb7cde697062 to 69a275300a28 (7 revisions) (flutter/flutter#114667)

* 7bee6e8 4b970fca0 Roll Dart SDK from c6e0307f3849 to 35b0cc8ac48b (2 revisions) (flutter/engine#37308) (flutter/flutter#114668)

* 43606d1 0a2d451b3 Roll Skia from b8209dce9a48 to 7eac7e7547e7 (1 revision) (flutter/engine#37309) (flutter/flutter#114670)

* 55fac57 2f90bda40 Merge AccessibilityBridge and AccessibilityBridgeDelegate (flutter/engine#36597) (flutter/flutter#114674)

* 4b7106c c5cc559db Roll Fuchsia Linux SDK from -0Xq1c-TncmWBWzqg... to 7e3H7isxOF6vqMDTT... (flutter/engine#37311) (flutter/flutter#114678)

* 55e8cd1 449fcc8b8 Roll Skia from 7eac7e7547e7 to c901cb6ae66f (1 revision) (flutter/engine#37313) (flutter/flutter#114683)
jason-simmons
jason-simmons reviewed Nov 4, 2022
View reviewed changes
Copy link
Member

@jason-simmons jason-simmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GaryQian
GaryQian reviewed Nov 4, 2022
View reviewed changes
Copy link
Contributor

@GaryQian GaryQian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

IVLIVS-III pushed a commit to IVLIVS-III/flutter_plugins_fork that referenced this pull request Nov 11, 2022
@engine-flutter-autoroll @IVLIVS-III
Roll Flutter from e6300da to 55e8cd1 (17 revisions) (flutter#6670)
36dbe9d 
* 0943693 Revert "[tools]validation basic Xcode settings for build ipa (#113412)" (flutter/flutter#114615)

* a440c46 Do not assume that pub is the first command run by "flutter create" (flutter/flutter#114621)

* 33b81ed fixes for incoming linter (flutter/flutter#113794)

* 0186b14 Fix the path where footer is written. (flutter/flutter#114469)

* 44ecbbc Roll Flutter Engine from 840a7b346216 to 66b244d9fa0a (25 revisions) (flutter/flutter#114640)

* 2ce62b3 Roll Flutter Engine from 66b244d9fa0a to e3c51631a9b5 (2 revisions) (flutter/flutter#114643)

* 8a9ddad [tools]validation basic Xcode settings for build ipa (#113412) (flutter/flutter#114634)

* 009fa69 Revert "Scribble mixin (#104128)" (flutter/flutter#114647)

* 125b9a7 Roll Flutter Engine from e3c51631a9b5 to ed31c3d76df5 (2 revisions) (flutter/flutter#114648)

* 9f6090c Revert "Fix text field label animation duration and curve" (flutter/flutter#114646)

* 44b6cd2 Roll Flutter Engine from ed31c3d76df5 to fb7cde697062 (2 revisions) (flutter/flutter#114651)

* fca260a Roll Flutter Engine from fb7cde697062 to 69a275300a28 (7 revisions) (flutter/flutter#114667)

* 7bee6e8 4b970fca0 Roll Dart SDK from c6e0307f3849 to 35b0cc8ac48b (2 revisions) (flutter/engine#37308) (flutter/flutter#114668)

* 43606d1 0a2d451b3 Roll Skia from b8209dce9a48 to 7eac7e7547e7 (1 revision) (flutter/engine#37309) (flutter/flutter#114670)

* 55fac57 2f90bda40 Merge AccessibilityBridge and AccessibilityBridgeDelegate (flutter/engine#36597) (flutter/flutter#114674)

* 4b7106c c5cc559db Roll Fuchsia Linux SDK from -0Xq1c-TncmWBWzqg... to 7e3H7isxOF6vqMDTT... (flutter/engine#37311) (flutter/flutter#114678)

* 55e8cd1 449fcc8b8 Roll Skia from 7eac7e7547e7 to c901cb6ae66f (1 revision) (flutter/engine#37313) (flutter/flutter#114683)
percula pushed a commit to percula/packages that referenced this pull request Nov 17, 2022
@engine-flutter-autoroll @percula
Roll Flutter from e6300da2c39f to 55e8cd178621 (17 revisions) (flutte…
59f0229 
…r#2780)

* 0943693e8 Revert "[tools]validation basic Xcode settings for build ipa (#113412)" (flutter/flutter#114615)

* a440c4689 Do not assume that pub is the first command run by "flutter create" (flutter/flutter#114621)

* 33b81ed95 fixes for incoming linter (flutter/flutter#113794)

* 0186b1496 Fix the path where footer is written. (flutter/flutter#114469)

* 44ecbbcc5 Roll Flutter Engine from 840a7b346216 to 66b244d9fa0a (25 revisions) (flutter/flutter#114640)

* 2ce62b3a0 Roll Flutter Engine from 66b244d9fa0a to e3c51631a9b5 (2 revisions) (flutter/flutter#114643)

* 8a9ddade9 [tools]validation basic Xcode settings for build ipa (#113412) (flutter/flutter#114634)

* 009fa69f3 Revert "Scribble mixin (#104128)" (flutter/flutter#114647)

* 125b9a769 Roll Flutter Engine from e3c51631a9b5 to ed31c3d76df5 (2 revisions) (flutter/flutter#114648)

* 9f6090c9a Revert "Fix text field label animation duration and curve" (flutter/flutter#114646)

* 44b6cd2ec Roll Flutter Engine from ed31c3d76df5 to fb7cde697062 (2 revisions) (flutter/flutter#114651)

* fca260a15 Roll Flutter Engine from fb7cde697062 to 69a275300a28 (7 revisions) (flutter/flutter#114667)

* 7bee6e8af 4b970fca0 Roll Dart SDK from c6e0307f3849 to 35b0cc8ac48b (2 revisions) (flutter/engine#37308) (flutter/flutter#114668)

* 43606d136 0a2d451b3 Roll Skia from b8209dce9a48 to 7eac7e7547e7 (1 revision) (flutter/engine#37309) (flutter/flutter#114670)

* 55fac571b 2f90bda40 Merge AccessibilityBridge and AccessibilityBridgeDelegate (flutter/engine#36597) (flutter/flutter#114674)

* 4b7106c5b c5cc559db Roll Fuchsia Linux SDK from -0Xq1c-TncmWBWzqg... to 7e3H7isxOF6vqMDTT... (flutter/engine#37311) (flutter/flutter#114678)

* 55e8cd178 449fcc8b8 Roll Skia from 7eac7e7547e7 to c901cb6ae66f (1 revision) (flutter/engine#37313) (flutter/flutter#114683)
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 21, 2022
@engine-flutter-autoroll @adam-harwood
Roll Flutter from e6300da to 55e8cd1 (17 revisions) (flutter#6670)
5ee6847 
* 0943693 Revert "[tools]validation basic Xcode settings for build ipa (#113412)" (flutter/flutter#114615)

* a440c46 Do not assume that pub is the first command run by "flutter create" (flutter/flutter#114621)

* 33b81ed fixes for incoming linter (flutter/flutter#113794)

* 0186b14 Fix the path where footer is written. (flutter/flutter#114469)

* 44ecbbc Roll Flutter Engine from 840a7b346216 to 66b244d9fa0a (25 revisions) (flutter/flutter#114640)

* 2ce62b3 Roll Flutter Engine from 66b244d9fa0a to e3c51631a9b5 (2 revisions) (flutter/flutter#114643)

* 8a9ddad [tools]validation basic Xcode settings for build ipa (#113412) (flutter/flutter#114634)

* 009fa69 Revert "Scribble mixin (#104128)" (flutter/flutter#114647)

* 125b9a7 Roll Flutter Engine from e3c51631a9b5 to ed31c3d76df5 (2 revisions) (flutter/flutter#114648)

* 9f6090c Revert "Fix text field label animation duration and curve" (flutter/flutter#114646)

* 44b6cd2 Roll Flutter Engine from ed31c3d76df5 to fb7cde697062 (2 revisions) (flutter/flutter#114651)

* fca260a Roll Flutter Engine from fb7cde697062 to 69a275300a28 (7 revisions) (flutter/flutter#114667)

* 7bee6e8 4b970fca0 Roll Dart SDK from c6e0307f3849 to 35b0cc8ac48b (2 revisions) (flutter/engine#37308) (flutter/flutter#114668)

* 43606d1 0a2d451b3 Roll Skia from b8209dce9a48 to 7eac7e7547e7 (1 revision) (flutter/engine#37309) (flutter/flutter#114670)

* 55fac57 2f90bda40 Merge AccessibilityBridge and AccessibilityBridgeDelegate (flutter/engine#36597) (flutter/flutter#114674)

* 4b7106c c5cc559db Roll Fuchsia Linux SDK from -0Xq1c-TncmWBWzqg... to 7e3H7isxOF6vqMDTT... (flutter/engine#37311) (flutter/flutter#114678)

* 55e8cd1 449fcc8b8 Roll Skia from 7eac7e7547e7 to c901cb6ae66f (1 revision) (flutter/engine#37313) (flutter/flutter#114683)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@zanderso @shogohida
Revert "[tools]validation basic Xcode settings for build ipa (flutter…
e4e31ae 
…#113412)" (flutter#114615)

This reverts commit e6300da.
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from e6300da to 55e8cd1 (17 revisions) (flutter#6670)
e4e071f 
* 0943693 Revert "[tools]validation basic Xcode settings for build ipa (#113412)" (flutter/flutter#114615)

* a440c46 Do not assume that pub is the first command run by "flutter create" (flutter/flutter#114621)

* 33b81ed fixes for incoming linter (flutter/flutter#113794)

* 0186b14 Fix the path where footer is written. (flutter/flutter#114469)

* 44ecbbc Roll Flutter Engine from 840a7b346216 to 66b244d9fa0a (25 revisions) (flutter/flutter#114640)

* 2ce62b3 Roll Flutter Engine from 66b244d9fa0a to e3c51631a9b5 (2 revisions) (flutter/flutter#114643)

* 8a9ddad [tools]validation basic Xcode settings for build ipa (#113412) (flutter/flutter#114634)

* 009fa69 Revert "Scribble mixin (#104128)" (flutter/flutter#114647)

* 125b9a7 Roll Flutter Engine from e3c51631a9b5 to ed31c3d76df5 (2 revisions) (flutter/flutter#114648)

* 9f6090c Revert "Fix text field label animation duration and curve" (flutter/flutter#114646)

* 44b6cd2 Roll Flutter Engine from ed31c3d76df5 to fb7cde697062 (2 revisions) (flutter/flutter#114651)

* fca260a Roll Flutter Engine from fb7cde697062 to 69a275300a28 (7 revisions) (flutter/flutter#114667)

* 7bee6e8 4b970fca0 Roll Dart SDK from c6e0307f3849 to 35b0cc8ac48b (2 revisions) (flutter/engine#37308) (flutter/flutter#114668)

* 43606d1 0a2d451b3 Roll Skia from b8209dce9a48 to 7eac7e7547e7 (1 revision) (flutter/engine#37309) (flutter/flutter#114670)

* 55fac57 2f90bda40 Merge AccessibilityBridge and AccessibilityBridgeDelegate (flutter/engine#36597) (flutter/flutter#114674)

* 4b7106c c5cc559db Roll Fuchsia Linux SDK from -0Xq1c-TncmWBWzqg... to 7e3H7isxOF6vqMDTT... (flutter/engine#37311) (flutter/flutter#114678)

* 55e8cd1 449fcc8b8 Roll Skia from 7eac7e7547e7 to c901cb6ae66f (1 revision) (flutter/engine#37313) (flutter/flutter#114683)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaryQian GaryQian GaryQian left review comments

@jason-simmons jason-simmons jason-simmons left review comments

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

@hellohuanlin hellohuanlin Awaiting requested review from hellohuanlin

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-ios iOS applications specifically revert Label used to revert changes in a closed and merged pull request. tool Affects the "flutter" command-line tool. See also t: labels. warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zanderso @GaryQian @jason-simmons @fluttergithubbot