Implement url support for RouteInformation and didPushRouteInformation #119968

chunhtai · 2023-02-03T22:39:01Z

The goal is to make sure the engine can send a location string in either the existing format or a complete uri string to the framework, and the framework will still work as usual.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

goderbauer · 2023-02-04T01:26:52Z

packages/flutter/lib/src/widgets/router.dart

-  const RouteInformation({this.location, this.state});
+  const RouteInformation({
+    @Deprecated(
+      'Passes Uri.parse(location) to uri parameter instead. '


Suggested change

'Passes Uri.parse(location) to uri parameter instead. '

'Pass Uri.parse(location) to uri parameter instead. '

goderbauer · 2023-02-04T01:27:08Z

packages/flutter/lib/src/widgets/router.dart

+  const RouteInformation({
+    @Deprecated(
+      'Passes Uri.parse(location) to uri parameter instead. '
+      'MaterialApp never introduces its own MediaQuery; the View widget takes care of that. '


Update this?

packages/flutter/lib/src/widgets/router.dart

goderbauer · 2023-02-04T01:30:33Z

packages/flutter/lib/src/widgets/router.dart

+  /// The string is usually in the format of multiple string identifiers with
+  /// slashes in between. ex: `/`, `/path`, `/path/to/the/app`.


Does this still make sense now that the type is Uri and not String?

goderbauer · 2023-02-04T01:35:46Z

packages/flutter/lib/src/widgets/binding.dart

@@ -647,7 +647,7 @@ mixin WidgetsBinding on BindingBase, ServicesBinding, SchedulerBinding, GestureB
      if (
        await observer.didPushRouteInformation(
          RouteInformation(
-            location: routeArguments['location'] as String,
+            uri: Uri.parse(routeArguments['location'] as String),


What is the purpose of this PR? It seems like all it effectively does is parse the string here into an URI, only to convert it back to a string above in line 91. It never does anything useful with the URI representation?

(Or is this just meant as a check that location has proper URI format? In that case, should we just do the parsing in an assert? Or is this user-provided input and we need to always verify this even in release mode?)

The purpose is to prepare this api so that engine can start sending full uri like http://www.mywebsite.com/mypath. This is important for apps that want to handle deeplinks from different web domains.

The line 91 is for backward compatibility that does not use router API.

OK, but before and after this change the engine is always just sending a string. The only difference is that with this change the string is parsed into an URI representation on the framework side. And just from looking at this PR its not clear why we need to do this parsing. All I see is strings getting parsed into URIs and turned back into strings. We never do anything interesting with the URI representation. So, why this change? What does this enable that we couldn't do before? Or do we just want to ensure that what the engine sends over MUST be URI-parsable?

This pr also add new getter RouteInformation.uri.

It lets developer to query RouteInformation.uri.scheme or RouteInformation.uri.host when they write their routing code.

goderbauer · 2023-02-04T01:36:51Z

packages/flutter/lib/src/widgets/router.dart

@@ -42,15 +42,51 @@ class RouteInformation {
  /// Creates a route information object.
  ///
  /// The arguments may be null.


This is no longer true, either uri or location must be non-null.

chunhtai · 2023-02-08T20:19:18Z

The linux flutter_plugins ci is blocked on flutter/plugins#7133, please ignore

goderbauer · 2023-02-08T22:44:50Z

packages/flutter/lib/src/widgets/binding.dart

-    return didPushRoute(routeInformation.location!);
+    final Uri uri = routeInformation.uri;
+    return didPushRoute(
+        Uri.decodeComponent(


Why does this need to be decoded? Doesn't Uri.toString below already produce something that is "decoded"?

Uri.parse will encode the string, so if you do http://host.com/my path The path will be /my%20path which will break the existing code

goderbauer · 2023-02-08T22:47:15Z

packages/flutter/lib/src/widgets/binding.dart

@@ -647,7 +656,7 @@ mixin WidgetsBinding on BindingBase, ServicesBinding, SchedulerBinding, GestureB
      if (
        await observer.didPushRouteInformation(
          RouteInformation(
-            location: routeArguments['location'] as String,
+            uri: Uri.parse(routeArguments['location'] as String),


Move the parsing above the for loop so it only happens once instead of over and over again for every observer?

goderbauer · 2023-02-08T22:51:21Z

packages/flutter/lib/src/widgets/binding.dart

@@ -647,7 +647,7 @@ mixin WidgetsBinding on BindingBase, ServicesBinding, SchedulerBinding, GestureB
      if (
        await observer.didPushRouteInformation(
          RouteInformation(
-            location: routeArguments['location'] as String,
+            uri: Uri.parse(routeArguments['location'] as String),


OK, but before and after this change the engine is always just sending a string. The only difference is that with this change the string is parsed into an URI representation on the framework side. And just from looking at this PR its not clear why we need to do this parsing. All I see is strings getting parsed into URIs and turned back into strings. We never do anything interesting with the URI representation. So, why this change? What does this enable that we couldn't do before? Or do we just want to ensure that what the engine sends over MUST be URI-parsable?

goderbauer · 2023-02-08T22:53:39Z

packages/flutter/lib/src/widgets/binding.dart

+        Uri.decodeComponent(
+          Uri(
+            path: uri.path.isEmpty ? '/' : uri.path,
+            queryParameters: uri.queryParametersAll.isEmpty ? null : uri.queryParametersAll,
+            fragment: uri.fragment.isEmpty ? null : uri.fragment,
+          ).toString(),
+        ),


Actually, what is the purpose of all of this? Why is this not just didPushRoute(routeInformation.uri.toString())?

The goal is that Android and iOS can start sending
http://mydomain.com/mypath instead of just /mypath when it is deeplinked without breaking the existing code.

goderbauer · 2023-02-08T22:55:59Z

packages/flutter/lib/src/widgets/router.dart

+  const RouteInformation({
+    @Deprecated(
+      'Pass Uri.parse(location) to uri parameter instead. '
+      'This parameter is superseded by the uri parameter. '


maybe just remove the second line? It just repeats what the first line is already saying. Ideally, the second line should give a short explanation of why uri is replacing location.

goderbauer · 2023-02-08T22:56:11Z

packages/flutter/lib/src/widgets/router.dart


  /// The location of the application.
  ///
  /// The string is usually in the format of multiple string identifiers with
  /// slashes in between. ex: `/`, `/path`, `/path/to/the/app`.
+  @Deprecated(
+    'Use uri instead. '
+    'This getter is superseded by the uri getter. '


goderbauer · 2023-02-08T23:00:36Z

packages/flutter/lib/src/widgets/router.dart

+    return Uri.decodeComponent(
+      Uri(
+        path: uri.path.isEmpty ? '/' : uri.path,
+        queryParameters: uri.queryParametersAll.isEmpty ? null : uri.queryParametersAll,
+        fragment: uri.fragment.isEmpty ? null : uri.fragment,
+      ).toString(),
+    );


same question as above.

goderbauer · 2023-02-08T23:45:23Z

This seems just hack-y. On the one hand, it tries to pretend that everything is an URI now. On the other hand, it very much still relies on the fact that sometimes it isn't (_getLocationFromUri). This is just weird and seems super-hard to properly reason about.

chunhtai · 2023-02-09T00:25:16Z

Let's define location = _getLocationFromUri(uri);

Only didpushRoute and RouteInformation.location use location, and RouteInformation.location is about to be deprecated, so basically only didpushRoute uses it. everything else should be uri otherwise.

The engine may send both location and uri, but they would be parse as if they are both uri, and I think location is just an uri without scheme and host.

What's other alternative? We can introduce a new RouteUri class and have a set of new method for didPushRouteUri, but I think that is redundent since RouteInformation is a class and can be extends to carry more data already.

jjoelson · 2023-03-01T16:35:08Z

Hi @chunhtai! I have a use-case in a mobile app where we're using a NavigatorObserver to report analytics whenever navigation changes, and the analytics team would like us to report if a particular navigation change was triggered by a deep link and if so then what was the full URL of the deep link. Currently we have to use a plugin like uni_links to gain access to the full URL. Do you think this change would enable us to access the full URL in our RouteInformationParser and switch to Flutter's built-in deep link handling?

chunhtai · 2023-03-02T22:58:28Z

@jjoelson yes that should be supported once the github issue is supported

flutter-dashboard · 2023-03-22T23:01:02Z

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

chunhtai · 2023-03-28T21:29:13Z

will write a migration guide once this is approved

goderbauer · 2023-03-29T23:39:01Z

packages/flutter/lib/src/widgets/binding.dart

@@ -647,7 +656,7 @@ mixin WidgetsBinding on BindingBase, ServicesBinding, SchedulerBinding, GestureB
      if (
        await observer.didPushRouteInformation(
          RouteInformation(
-            location: routeArguments['location'] as String,
+            uri: Uri.parse(routeArguments['location'] as String),


goderbauer · 2023-03-29T23:43:32Z

packages/flutter/lib/src/widgets/app.dart

@@ -1496,7 +1496,16 @@ class _WidgetsAppState extends State<WidgetsApp> with WidgetsBindingObserver {
    if (navigator == null) {
      return false;
    }
-    navigator.pushNamed(route);
+    final Uri uri = routeInformation.uri;
+    navigator.pushNamed(


Why can we just ignore all other pieces of the URI here? Should we assert that those are empty?

Navigator.pushNamed only handles path after the hostname. The host can be non-empty here, but Navigator API doesn't care about host.

goderbauer · 2023-03-29T23:44:10Z

packages/flutter/lib/src/widgets/binding.dart

+      if (
+        await observer.didPushRouteInformation(
+          RouteInformation(
+            uri: Uri.parse(route),


Parse this once outside of the for loop?

goderbauer

LGTM

Migration guide for flutter/flutter#119968 ## Presubmit checklist - [ ] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [ ] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [ ] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/master/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

…3763) migrating test for flutter/flutter#119968

chunhtai · 2023-04-20T16:20:04Z

g3fix cl/525552584

…Information (flutter/flutter#119968)

Roll Flutter from c9004ff822cf to 66fa4c5d301c (68 revisions) flutter/flutter@c9004ff...66fa4c5 2023-04-26 zanderso@users.noreply.github.com Remove web compile benchmarks that specify an attached device (flutter/flutter#125559) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from f75908135e10 to f125a54f5a57 (1 revision) (flutter/flutter#125560) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from c9db1587f207 to f75908135e10 (1 revision) (flutter/flutter#125558) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 58a5a1e3f2c1 to c9db1587f207 (1 revision) (flutter/flutter#125555) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 321f8015b9c2 to 58a5a1e3f2c1 (1 revision) (flutter/flutter#125552) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 87f5f4e939cf to 321f8015b9c2 (1 revision) (flutter/flutter#125549) 2023-04-26 goderbauer@google.com Update prefer_final_parameters comment (flutter/flutter#125465) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 706c023df44b to 87f5f4e939cf (1 revision) (flutter/flutter#125539) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7b385abd18a2 to 706c023df44b (1 revision) (flutter/flutter#125536) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 610c57781b47 to 7b385abd18a2 (1 revision) (flutter/flutter#125533) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from b3cbf0678487 to 610c57781b47 (1 revision) (flutter/flutter#125531) 2023-04-26 zanderso@users.noreply.github.com Add hostonly web compile size benchmarks (flutter/flutter#125518) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 34ece7a4abac to b3cbf0678487 (6 revisions) (flutter/flutter#125529) 2023-04-25 thkim1011@users.noreply.github.com Handle dollar signs properly when generating localizations (flutter/flutter#125514) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6d798393a15a to 34ece7a4abac (1 revision) (flutter/flutter#125516) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 469e5b409686 to 6d798393a15a (2 revisions) (flutter/flutter#125513) 2023-04-25 47866232+chunhtai@users.noreply.github.com Adds selected semantics flag to radio button for Apple devices (flutter/flutter#125499) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0e236982086b to 469e5b409686 (1 revision) (flutter/flutter#125510) 2023-04-25 58529443+srujzs@users.noreply.github.com Relabel JSFunction as JSExportedDartFunction (flutter/flutter#125453) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 60c4e61416cd to 0e236982086b (2 revisions) (flutter/flutter#125504) 2023-04-25 jmccandless@google.com iOS TextField spell check style (flutter/flutter#125432) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 308bce499087 to 60c4e61416cd (1 revision) (flutter/flutter#125490) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 54ddef68b124 to 308bce499087 (1 revision) (flutter/flutter#125485) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 307416f43b5a to 54ddef68b124 (1 revision) (flutter/flutter#125481) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 232810b36671 to 307416f43b5a (1 revision) (flutter/flutter#125475) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1c4b6c0cb862 to 232810b36671 (2 revisions) (flutter/flutter#125472) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from a26a479e86b3 to 1c4b6c0cb862 (1 revision) (flutter/flutter#125463) 2023-04-25 tessertaha@gmail.com Fix `SliverAppBar.medium` & `SliverAppBar.large` text scale (flutter/flutter#125038) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3f4116c225e8 to a26a479e86b3 (1 revision) (flutter/flutter#125459) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 64882f4b7371 to 3f4116c225e8 (2 revisions) (flutter/flutter#125458) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8fe8e94c02fc to 64882f4b7371 (1 revision) (flutter/flutter#125454) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5fbde6c0fc57 to 8fe8e94c02fc (10 revisions) (flutter/flutter#125452) 2023-04-24 tessertaha@gmail.com Add Sliders to `macrobenchmarks` (flutter/flutter#125296) 2023-04-24 pateltirth454@gmail.com [date_picker] [date_range_picker] add properties to change switch-to icons (flutter/flutter#124881) 2023-04-24 thkim1011@users.noreply.github.com Sliver Constrained Cross Axis (flutter/flutter#125239) 2023-04-24 kevmoo@users.noreply.github.com tool: Move cdKey to CustomDimensionsEnum (flutter/flutter#125335) 2023-04-24 bernaferrari2@gmail.com Add `borderRadius` to LinearProgressIndicator (flutter/flutter#123517) 2023-04-24 58529443+srujzs@users.noreply.github.com Fix JS types in _test_http_request.dart (flutter/flutter#125220) 2023-04-24 tessertaha@gmail.com Fix `OutlinedButton`, `TextButton`, and `IconButton` throw exception when passing only one cursor to `styleFrom` (flutter/flutter#125204) 2023-04-24 magder@google.com Swap some iOS TESTOWNERS (flutter/flutter#125340) 2023-04-24 rmolivares@renzo-olivares.dev Fix iOS touch drag behavior (flutter/flutter#125169) 2023-04-24 54558023+keyonghan@users.noreply.github.com Mark module_test_ios flaky (flutter/flutter#125426) 2023-04-24 47866232+chunhtai@users.noreply.github.com Implement url support for RouteInformation and didPushRouteInformation (flutter/flutter#119968) 2023-04-24 kevmoo@users.noreply.github.com [tool,web] Include more info URI on Wasm init failure (flutter/flutter#125312) 2023-04-24 magder@google.com Do not run `windows_home_scroll_perf__timeline_summary` benchmark in presubmit (flutter/flutter#125343) 2023-04-24 5236035+fzyzcjy@users.noreply.github.com Tiny fix doc pointing to incorrect widget confusing the readers (flutter/flutter#125394) ...

…lutter#3763) migrating test for flutter/flutter#119968

…r#3830) Roll Flutter from c9004ff822cf to 66fa4c5d301c (68 revisions) flutter/flutter@c9004ff...66fa4c5 2023-04-26 zanderso@users.noreply.github.com Remove web compile benchmarks that specify an attached device (flutter/flutter#125559) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from f75908135e10 to f125a54f5a57 (1 revision) (flutter/flutter#125560) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from c9db1587f207 to f75908135e10 (1 revision) (flutter/flutter#125558) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 58a5a1e3f2c1 to c9db1587f207 (1 revision) (flutter/flutter#125555) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 321f8015b9c2 to 58a5a1e3f2c1 (1 revision) (flutter/flutter#125552) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 87f5f4e939cf to 321f8015b9c2 (1 revision) (flutter/flutter#125549) 2023-04-26 goderbauer@google.com Update prefer_final_parameters comment (flutter/flutter#125465) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 706c023df44b to 87f5f4e939cf (1 revision) (flutter/flutter#125539) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7b385abd18a2 to 706c023df44b (1 revision) (flutter/flutter#125536) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 610c57781b47 to 7b385abd18a2 (1 revision) (flutter/flutter#125533) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from b3cbf0678487 to 610c57781b47 (1 revision) (flutter/flutter#125531) 2023-04-26 zanderso@users.noreply.github.com Add hostonly web compile size benchmarks (flutter/flutter#125518) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 34ece7a4abac to b3cbf0678487 (6 revisions) (flutter/flutter#125529) 2023-04-25 thkim1011@users.noreply.github.com Handle dollar signs properly when generating localizations (flutter/flutter#125514) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6d798393a15a to 34ece7a4abac (1 revision) (flutter/flutter#125516) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 469e5b409686 to 6d798393a15a (2 revisions) (flutter/flutter#125513) 2023-04-25 47866232+chunhtai@users.noreply.github.com Adds selected semantics flag to radio button for Apple devices (flutter/flutter#125499) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0e236982086b to 469e5b409686 (1 revision) (flutter/flutter#125510) 2023-04-25 58529443+srujzs@users.noreply.github.com Relabel JSFunction as JSExportedDartFunction (flutter/flutter#125453) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 60c4e61416cd to 0e236982086b (2 revisions) (flutter/flutter#125504) 2023-04-25 jmccandless@google.com iOS TextField spell check style (flutter/flutter#125432) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 308bce499087 to 60c4e61416cd (1 revision) (flutter/flutter#125490) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 54ddef68b124 to 308bce499087 (1 revision) (flutter/flutter#125485) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 307416f43b5a to 54ddef68b124 (1 revision) (flutter/flutter#125481) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 232810b36671 to 307416f43b5a (1 revision) (flutter/flutter#125475) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1c4b6c0cb862 to 232810b36671 (2 revisions) (flutter/flutter#125472) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from a26a479e86b3 to 1c4b6c0cb862 (1 revision) (flutter/flutter#125463) 2023-04-25 tessertaha@gmail.com Fix `SliverAppBar.medium` & `SliverAppBar.large` text scale (flutter/flutter#125038) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3f4116c225e8 to a26a479e86b3 (1 revision) (flutter/flutter#125459) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 64882f4b7371 to 3f4116c225e8 (2 revisions) (flutter/flutter#125458) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8fe8e94c02fc to 64882f4b7371 (1 revision) (flutter/flutter#125454) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5fbde6c0fc57 to 8fe8e94c02fc (10 revisions) (flutter/flutter#125452) 2023-04-24 tessertaha@gmail.com Add Sliders to `macrobenchmarks` (flutter/flutter#125296) 2023-04-24 pateltirth454@gmail.com [date_picker] [date_range_picker] add properties to change switch-to icons (flutter/flutter#124881) 2023-04-24 thkim1011@users.noreply.github.com Sliver Constrained Cross Axis (flutter/flutter#125239) 2023-04-24 kevmoo@users.noreply.github.com tool: Move cdKey to CustomDimensionsEnum (flutter/flutter#125335) 2023-04-24 bernaferrari2@gmail.com Add `borderRadius` to LinearProgressIndicator (flutter/flutter#123517) 2023-04-24 58529443+srujzs@users.noreply.github.com Fix JS types in _test_http_request.dart (flutter/flutter#125220) 2023-04-24 tessertaha@gmail.com Fix `OutlinedButton`, `TextButton`, and `IconButton` throw exception when passing only one cursor to `styleFrom` (flutter/flutter#125204) 2023-04-24 magder@google.com Swap some iOS TESTOWNERS (flutter/flutter#125340) 2023-04-24 rmolivares@renzo-olivares.dev Fix iOS touch drag behavior (flutter/flutter#125169) 2023-04-24 54558023+keyonghan@users.noreply.github.com Mark module_test_ios flaky (flutter/flutter#125426) 2023-04-24 47866232+chunhtai@users.noreply.github.com Implement url support for RouteInformation and didPushRouteInformation (flutter/flutter#119968) 2023-04-24 kevmoo@users.noreply.github.com [tool,web] Include more info URI on Wasm init failure (flutter/flutter#125312) 2023-04-24 magder@google.com Do not run `windows_home_scroll_perf__timeline_summary` benchmark in presubmit (flutter/flutter#125343) 2023-04-24 5236035+fzyzcjy@users.noreply.github.com Tiny fix doc pointing to incorrect widget confusing the readers (flutter/flutter#125394) ...

flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. labels Feb 3, 2023

chunhtai requested a review from goderbauer February 3, 2023 22:39

chunhtai mentioned this pull request Feb 3, 2023

Deeplink URL scheme should also include domain name (iOS and Android) #100624

Closed

3 tasks

chunhtai force-pushed the issues/100624 branch from 7c3ea56 to 77f6b10 Compare February 3, 2023 22:40

goderbauer reviewed Feb 4, 2023

View reviewed changes

chunhtai force-pushed the issues/100624 branch from 77f6b10 to c11d16d Compare February 7, 2023 18:29

chunhtai requested a review from goderbauer February 7, 2023 22:55

chunhtai mentioned this pull request Feb 8, 2023

[url_launcher] Adds lint ignores to the usage of RouteInformation.location flutter/plugins#7133

Closed

11 tasks

goderbauer reviewed Feb 8, 2023

View reviewed changes

chunhtai force-pushed the issues/100624 branch from eb4e4a0 to 82718f7 Compare February 22, 2023 19:57

chunhtai force-pushed the issues/100624 branch from 82718f7 to 2b940ad Compare March 1, 2023 22:47

chunhtai mentioned this pull request Mar 13, 2023

Added additional uri field to routeInformationUpdated to accept entir… flutter/engine#40250

Merged

8 tasks

chunhtai force-pushed the issues/100624 branch from 2b940ad to e47c086 Compare March 28, 2023 20:22

chunhtai force-pushed the issues/100624 branch from d62bd5e to e47c086 Compare March 28, 2023 22:12

chunhtai requested a review from goderbauer March 28, 2023 22:15

goderbauer reviewed Mar 29, 2023

View reviewed changes

goderbauer approved these changes Mar 30, 2023

View reviewed changes

chunhtai mentioned this pull request Mar 30, 2023

Add route info migration guide flutter/website#8467

Merged

3 tasks

chunhtai force-pushed the issues/100624 branch from f84e293 to f9095ef Compare March 31, 2023 20:19

auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 19, 2023

[go_router] migrates test for route information.location deprecation (#…

8d3bf84

…3763) migrating test for flutter/flutter#119968

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 24, 2023

auto-submit bot merged commit 3b4ac4d into flutter:master Apr 24, 2023
71 checks passed

engine-flutter-autoroll mentioned this pull request Apr 24, 2023

Roll Flutter from 3476b966524f to 3b4ac4d5cc59 (73 revisions) flutter/packages#3810

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023

3b4ac4d5c Implement url support for RouteInformation and didPushRoute…

74d0ef5

…Information (flutter/flutter#119968)

engine-flutter-autoroll mentioned this pull request Apr 24, 2023

Roll Flutter from 3476b966524f to 624bdd38b08b (74 revisions) flutter/packages#3811

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023

3b4ac4d5c Implement url support for RouteInformation and didPushRoute…

bbb2451

…Information (flutter/flutter#119968)

engine-flutter-autoroll mentioned this pull request Apr 25, 2023

Roll Flutter from 3476b966524f to 932faedce2f8 (93 revisions) flutter/packages#3813

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023

3b4ac4d5c Implement url support for RouteInformation and didPushRoute…

5962755

…Information (flutter/flutter#119968)

engine-flutter-autoroll mentioned this pull request Apr 25, 2023

Roll Flutter from 3476b966524f to 8cd11e91fb7d (94 revisions) flutter/packages#3815

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023

3b4ac4d5c Implement url support for RouteInformation and didPushRoute…

39df3c8

…Information (flutter/flutter#119968)

engine-flutter-autoroll mentioned this pull request Apr 25, 2023

Roll Flutter from c9004ff822cf to 8cd11e91fb7d (47 revisions) flutter/packages#3817

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023

3b4ac4d5c Implement url support for RouteInformation and didPushRoute…

06ed1d4

…Information (flutter/flutter#119968)

engine-flutter-autoroll mentioned this pull request Apr 26, 2023

Roll Flutter from c9004ff822cf to b0ae2e81bab5 (66 revisions) flutter/packages#3827

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023

3b4ac4d5c Implement url support for RouteInformation and didPushRoute…

d58337c

…Information (flutter/flutter#119968)

engine-flutter-autoroll mentioned this pull request Apr 26, 2023

Roll Flutter from c9004ff822cf to c9d7bed4216b (67 revisions) flutter/packages#3829

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023

3b4ac4d5c Implement url support for RouteInformation and didPushRoute…

2ca6ae3

…Information (flutter/flutter#119968)

engine-flutter-autoroll mentioned this pull request Apr 26, 2023

Roll Flutter from c9004ff822cf to 66fa4c5d301c (68 revisions) flutter/packages#3830

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023

3b4ac4d5c Implement url support for RouteInformation and didPushRoute…

1b44c26

…Information (flutter/flutter#119968)

HansMuller mentioned this pull request Apr 28, 2023

Flutter Framework Team: Notable Commits #121415

Open

This was referenced May 17, 2023

Make iOS embedding to send full uri for deeplinks flutter/engine#41992

Merged

Makes android embedding to send full uri flutter/engine#41836

Merged

nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023

[go_router] migrates test for route information.location deprecation (f…

aea5059

…lutter#3763) migrating test for flutter/flutter#119968

darshankawar mentioned this pull request Sep 26, 2023

[iOS] Wrong routing in the new flutter version (3.13.1) #135418

Closed

2 tasks

huycozy mentioned this pull request Nov 7, 2023

RouteSettings encoded name is automatically decoded in Flutter 3.13 #137929

Open

2 tasks

ChopinDavid mentioned this pull request Jan 20, 2024

[go_router] Expose full Uri on GoRouterState in GoRouterRedirect flutter/packages#5742

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement url support for RouteInformation and didPushRouteInformation #119968

Implement url support for RouteInformation and didPushRouteInformation #119968

chunhtai commented Feb 3, 2023

goderbauer Feb 4, 2023

goderbauer Feb 4, 2023

goderbauer Feb 4, 2023

goderbauer Feb 4, 2023

chunhtai Feb 6, 2023 •

edited

goderbauer Feb 8, 2023

chunhtai Feb 8, 2023

goderbauer Feb 4, 2023

chunhtai commented Feb 8, 2023

goderbauer Feb 8, 2023

chunhtai Feb 8, 2023

goderbauer Feb 8, 2023

goderbauer Mar 29, 2023

goderbauer Feb 8, 2023

goderbauer Feb 8, 2023

chunhtai Feb 8, 2023

goderbauer Feb 8, 2023

goderbauer Feb 8, 2023

goderbauer Feb 8, 2023

goderbauer commented Feb 8, 2023

chunhtai commented Feb 9, 2023

jjoelson commented Mar 1, 2023

chunhtai commented Mar 2, 2023

flutter-dashboard bot commented Mar 22, 2023

chunhtai commented Mar 28, 2023

goderbauer Mar 29, 2023

goderbauer Mar 29, 2023

chunhtai Mar 30, 2023

goderbauer Mar 29, 2023

goderbauer left a comment

chunhtai commented Apr 20, 2023

	'Passes Uri.parse(location) to uri parameter instead. '
	'Pass Uri.parse(location) to uri parameter instead. '

		/// The string is usually in the format of multiple string identifiers with
		/// slashes in between. ex: `/`, `/path`, `/path/to/the/app`.

Implement url support for RouteInformation and didPushRouteInformation #119968

Implement url support for RouteInformation and didPushRouteInformation #119968

Conversation

chunhtai commented Feb 3, 2023

Pre-launch Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chunhtai Feb 6, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chunhtai commented Feb 8, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

goderbauer commented Feb 8, 2023

chunhtai commented Feb 9, 2023

jjoelson commented Mar 1, 2023

chunhtai commented Mar 2, 2023

flutter-dashboard bot commented Mar 22, 2023

chunhtai commented Mar 28, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

goderbauer left a comment

Choose a reason for hiding this comment

chunhtai commented Apr 20, 2023

chunhtai Feb 6, 2023 •

edited