flutter_view_ios__start_up: move all test logic into TaskFunction #14088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
approved these changes
Jan 13, 2018
|
|
|
Thanks! Will land on green. |
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
engine-flutter-autoroll
added a commit
that referenced
this pull request
Dec 4, 2019
git@github.com:flutter/engine.git/compare/1a96087747ac...6179380 git log 1a96087..6179380 --first-parent --oneline 2019-12-03 caseyhillers@gmail.com Update fallback to Roboto url to be HTTPS (#14086) 2019-12-03 iska.kaushik@gmail.com Revert "Fix fml_unittests (#14062)" (#14087) 2019-12-03 liyuqian@google.com Revert PRs to unblock David and Jim's work (#14088) 2019-12-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from 6QxEZ... to OSk8h... (#14085) 2019-12-03 bkonyi@google.com Roll src/third_party/dart e4344a568f..a4d799c402 (7 commits) (#14083) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task attempted to run
pod installoutside the test function, causing the task runner to time out trying to connect to the task process. This may fix the test. If not, it should at least provide much better logging.