Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll engine to 7f7634fa172e730daf20ff979ea6e65fd3dfe0a3 #15250

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@goderbauer
Copy link
Member

commented Mar 7, 2018

No description provided.

@googlebot googlebot added the cla: yes label Mar 7, 2018

@cbracken

This comment has been minimized.

Copy link
Member

commented Mar 7, 2018

lgtm

@tvolkert

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2018

nack. This would pick up flutter/engine#4751...

  • which @jason-simmons is trying to roll...
  • but first attempting to land #15213 within Google...
  • which is causing failures due to picking up flutter/engine#4742...
  • which may require rolling back flutter/engine#4751 in order to commit a fix in the engine and roll that into flutter/flutter first.

So we should hold off on any engine rolls until that's all resolved.

@goderbauer

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2018

😞

@goderbauer goderbauer closed this Mar 7, 2018

@goderbauer goderbauer deleted the goderbauer:roll4 branch Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.