Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the gallery text fields demo #15362

Merged
merged 3 commits into from Mar 14, 2018

Conversation

Projects
None yet
3 participants
@HansMuller
Copy link
Contributor

commented Mar 10, 2018

Uses the new InputDecorator features for filled/underlined and outlined text fields.

textfield_demo

@googlebot googlebot added the cla: yes label Mar 10, 2018

@HansMuller HansMuller force-pushed the HansMuller:gallery_text_field_demo branch from 08da1da to 3e97d28 Mar 12, 2018

@HansMuller HansMuller requested a review from gspencergoog Mar 14, 2018

new PasswordField(
fieldKey: _passwordFieldKey,
helperText: 'No more than 8 characters.',
labelText: 'Password *',

This comment has been minimized.

Copy link
@gspencergoog

gspencergoog Mar 14, 2018

Contributor

Don't you want to add "* required" to the helperText? Either that, or take away the asterisk, I think.

],
const SizedBox(height: 24.0),
new Text(
'* indicates required field',

This comment has been minimized.

Copy link
@gspencergoog

gspencergoog Mar 14, 2018

Contributor

Oh, I see, you put it here. I think I would just eliminate the "*required" helper texts and just have this one notice, so that all the fields can be consistent.

This comment has been minimized.

Copy link
@HansMuller

HansMuller Mar 14, 2018

Author Contributor

Good point, I've done that.

@gspencergoog

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2018

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@HansMuller HansMuller force-pushed the HansMuller:gallery_text_field_demo branch from 3e97d28 to 2acb55e Mar 14, 2018

@HansMuller HansMuller merged commit b6cca39 into flutter:master Mar 14, 2018

4 checks passed

cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
flutter-build

@HansMuller HansMuller deleted the HansMuller:gallery_text_field_demo branch Mar 14, 2018

DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.