Skip to content

Conversation

@camsim99
Copy link
Contributor

@camsim99 camsim99 commented Oct 9, 2025

Sets engine.version to release build from 3eead6b. Part of #176744

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@camsim99 camsim99 requested a review from jtmcdole as a code owner October 9, 2025 16:56
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@camsim99 camsim99 requested a review from justinmc October 9, 2025 16:57
@camsim99
Copy link
Contributor Author

camsim99 commented Oct 9, 2025

Hmm the release builder ran on this commit so I thought the test would pass?

@camsim99
Copy link
Contributor Author

camsim99 commented Oct 9, 2025

In the meantime, running postsubmits on the previous commit. I did this by accident but there are actual errors, e.g. https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64%20verify_binaries_codesigned/628/overview and https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Production%20Engine%20Drone/1305670/overview

I may need to dig into this first.

@jtmcdole
Copy link
Member

jtmcdole commented Oct 9, 2025

Release builder is required to build all the binaries? I can't see the results, but 3eead6b0480ba4aacab8f0e0d058ac77f550bc1d Is the correct hash

@jtmcdole
Copy link
Member

jtmcdole commented Oct 9, 2025

59c4900 is not a valid githash... 404: 59c4900

curl --head https://storage.googleapis.com/flutter_infra_release/flutter/59c4900ce5d1ecf691330e7e6abc7d5821feffd2/flutter-web-sdk.zip
HTTP/2 404
content-type: application/xml; charset=UTF-8
x-guploader-uploadid: AAwnv3J44F-ZcuoS1vzDq4kYfDbpL8z_h0f3gCl3XGNlYS9YkiOKn9mGRrmaKnKym7xiyo4gL6V94AI
content-length: 252
access-control-allow-origin: *
access-control-expose-headers: Content-Type
date: Thu, 09 Oct 2025 19:54:10 GMT
expires: Thu, 09 Oct 2025 19:54:10 GMT
cache-control: private, max-age=0
server: UploadServer
alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000

@camsim99
Copy link
Contributor Author

camsim99 commented Oct 9, 2025

59c4900 is not a valid githash... 404: 59c4900

Looks like you're talking about https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Production%20Engine%20Drone/1305670/overview. Do you know where that commit is even coming from?

Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is out of date as of the cherry pick #176883. I will update this PR or create a new PR after that build succeeds.

Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to push a commit to update the hash 👍

@justinmc justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 16, 2025
@auto-submit auto-submit bot merged commit 2d15161 into flutter:flutter-3.38-candidate.0 Oct 16, 2025
5 checks passed
auto-submit bot pushed a commit that referenced this pull request Oct 17, 2025
The version I set in #176799 was incorrect so the release build failed. This updates it to the correct engine version.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants