[ Tool ] Ignore invalid UTF-8 from ADB's stdout #178170
Conversation
This was incorrectly updated as part of #177470
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request corrects an issue in AdbLogReader where invalid UTF-8 characters from adb's stdout could cause a crash. The change aligns the stdout stream processing with that of the stderr stream by applying a Utf8Decoder configured to ignore errors. This is a good fix that improves the robustness of log parsing and prevents potential crashes from malformed logcat output.
reidbaker
added
autosubmit
|
Non blocking: is it possible to add a regression test for this case? |
It doesn't look like it'll be trivial without some refactoring of our |
flutter-dashboard
bot
removed
the
autosubmit
This was incorrectly updated as part of #177470
This was incorrectly updated as part of #177470