-
Notifications
You must be signed in to change notification settings - Fork 29.5k
fix #178045: update expansible documentation for default maintainSta… #178203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #178045: update expansible documentation for default maintainSta… #178203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the documentation for the maintainState property in the Expansible widget. The documentation previously stated that the default value was false, while the code's default is true. This change aligns the documentation with the implementation, which is a good and necessary fix.
victorsanni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change. Sorry I missed this when writing the API docs.
hannah-hyj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR updates the
ExpansiblemaintainStatedocumentation in the code, current maintainState default value is set to true while the documentation shows '/// Defaults to false.Update
Fixes issues/178045
Pre-launch Checklist
///).