Allow dynamic patches without a patch number. #25796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unique patch numbers are mainly useful for canary and A-B testing, but otherwise complicate things and can now be omitted.
zoechi
added
tool
amirh
approved these changes
Dec 27, 2018
| }; | ||
|
|
||
| if (buildInfo.patchNumber != null) { | ||
| manifest.addAll(<String, dynamic>{ |
There was a problem hiding this comment.
nit: manifest['patchNumber'] = ... might be more clear since we're adding just one key-value.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unique patch numbers are mainly useful for canary and A-B testing, but otherwise complicate things and can now be omitted.
Also see flutter/engine#7309.