Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async execution for xcodebuild commands #29048

Merged
merged 5 commits into from Mar 19, 2019
Merged

Use async execution for xcodebuild commands #29048

merged 5 commits into from Mar 19, 2019

Conversation

@priitlatt
Copy link
Contributor

@priitlatt priitlatt commented Mar 8, 2019

Description

Sometimes Flutter never receives the output of xcodebuild -list and xcodebuild -showBuildSettings commands while they have actually been completed underneath (no alive processes for xcodebuild are present). For unknown reasons, the issue does not reproduce when the commands are invoked with runCheckedAsync instead of runCheckedSync.

Related Issues

#28415

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

@googlebot
Copy link

@googlebot googlebot commented Mar 8, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Mar 8, 2019

I'm ready to LGTM once the CLA is signed and the test is fixed

jonahwilliams and others added 2 commits Mar 8, 2019
Co-Authored-By: priitlatt <lattpriit@gmail.com>
Co-Authored-By: priitlatt <lattpriit@gmail.com>
@jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Mar 11, 2019

@priitlatt are you able to continue working on it or should we continue ourselves?

@priitlatt
Copy link
Contributor Author

@priitlatt priitlatt commented Mar 12, 2019

@jonahwilliams We were observing how this fix behaves in the production over the weekend and yesterday. At first it was very promising, but now it seems that it still occasionally gets stuck on /usr/bin/xcodebuild -project /paht/to/Runner.xcodeproj -target Runner -showBuildSettings.

Also, making XcodeProjectInterpreter#getBuildSettings async has proven to be a bit more involved than I initially thought it would be (this also causes the tests and some functionality to break). And on top of the complications, it doesn't even give the desired result.

But async version of XcodeProjectInterpreter#getInfo seems to solve at least half of the problem for now. So I'll revert changes related to getBuildSettings and perhaps we could move on with getInfo being async for now?

@jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Mar 12, 2019

That sounds reasonable to me

@jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Mar 19, 2019

cc @priitlatt what are your plans with this CL? If this improves the situation I would prefer to land it and continue addressing other forms of flakiness separately

@priitlatt
Copy link
Contributor Author

@priitlatt priitlatt commented Mar 19, 2019

@jonahwilliams Last I checked the Flutter build was failing and hence the delays, sorry about that. I'm good to go on with this and continue with showBuildSettings getting stuck separately. Also, I've signed the CLA in the meantime.

@priitlatt priitlatt marked this pull request as ready for review Mar 19, 2019
Copy link
Member

@jonahwilliams jonahwilliams left a comment

LGTM,

Thank you for the contribution!

@priitlatt
Copy link
Contributor Author

@priitlatt priitlatt commented Mar 19, 2019

I signed it!

@googlebot
Copy link

@googlebot googlebot commented Mar 19, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jonahwilliams jonahwilliams merged commit cdbd0f9 into flutter:master Mar 19, 2019
33 checks passed
@jonsamwell
Copy link

@jonsamwell jonsamwell commented Aug 16, 2019

Is this in the stable branch yet?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants