Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaterialButton shape should override ButtonTheme shape #29189

Merged
merged 1 commit into from Mar 12, 2019

Conversation

Projects
None yet
4 participants
@HansMuller
Copy link
Contributor

HansMuller commented Mar 12, 2019

This fix was originally contributed by @HeavenOSK in #29090.

Fixes #29146

MaterialButton now uses its shape parameter if it's non null.

@googlebot googlebot added the cla: yes label Mar 12, 2019

@HansMuller HansMuller referenced this pull request Mar 12, 2019

Closed

Fix: MaterialButton's shape #29090

9 of 10 tasks complete
@dnfield
Copy link
Member

dnfield left a comment

LGTM

@HansMuller HansMuller merged commit d9096a4 into flutter:master Mar 12, 2019

17 checks passed

add2app-macos
Details
analyze
Details
build_tests-linux
Details
build_tests-macos
Details
build_tests-windows
Details
cla/google All necessary CLAs are signed
docs
Details
flutter-build
integration_tests-linux
Details
integration_tests-macos
Details
integration_tests-windows
Details
tests-linux
Details
tests-macos
Details
tests-windows
Details
tool_tests-linux
Details
tool_tests-macos
Details
tool_tests-windows
Details

@HansMuller HansMuller deleted the HansMuller:material_button_shape_reprise branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.