Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor core uses of FlutterError. #30983
Make FlutterError objects more structured so they can be displayed better in debugging tools such as Dart DevTools.
Most tests pass as is as the text output does not change as the refactor does not break existing text based error displays.
New test cases are added in flutter_test to verify the structure is maintained and new tests are added to diagnostics_test.dart to verify that the additional text formatting logic works as expected.
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
Does your PR require Flutter developers to manually update their apps to accommodate your change?
Apr 12, 2019
This CL has only the core changes for the FlutterError refactor. Follow up CLs apply the refactor to more places. The diff is still large but take heart that a lot of the additions are just the text rendering logic and golden style tests in diagnosticable.dart.
Two follow up CLs will apply the refactor to more places.