Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xcode build script for macOS target #31329

Merged

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Apr 19, 2019

Description

Removes indirection by moving the macOS build script to flutter_tools. This still uses the FDE asset syncing. This uses almost the same scheme/flag passing setup as the existing iOS build.

Currently the track-widget-creation flag is still broken though, it seems like some part of the process is using the regular .dill instead of the .track.dill - still investigating.

Fixed

See also: google/flutter-desktop-embedding#336

Related Issues

Fixes #31274

#30707
#30706

Tests

I added the following tests:

Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@jonahwilliams jonahwilliams added e: desktop tool Affects the "flutter" command-line tool. See also t: labels. platform-mac Building on or for macOS specifically labels Apr 19, 2019
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had a chance to try this out locally yet (will do that tomorrow, and then re-review) but looks generally good so far.

@jonahwilliams jonahwilliams merged commit 7f959d8 into flutter:master Apr 22, 2019
@jonahwilliams jonahwilliams deleted the move_macos_build_script_to_tool branch April 22, 2019 20:51
@stuartmorgan stuartmorgan added the a: desktop Running on desktop label Jul 26, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: desktop Running on desktop platform-mac Building on or for macOS specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashing during hot reload when --track-widget-creation is enabled
3 participants