add ignorable track-widget-creation flag to build aot #31399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
added
the
tool
jacob314
reviewed
Apr 22, 2019
| @@ -38,6 +38,10 @@ class BuildAotCommand extends BuildSubCommand with TargetPlatformBasedDevelopmen | |||
| defaultsTo: false, | |||
| help: 'Report timing information about build steps in machine readable form,', | |||
| ) | |||
| ..addFlag('track-widget-creation', | |||
There was a problem hiding this comment.
We should comment somewhere that the flag is only exposed for simplicity writing build scripts and not because we ever plan on supporting this flag on AOT. We could support on AOT but that would be bad as it would bloat AOT code output size without a benefit.
jacob314
approved these changes
Apr 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Xcode:
It is possible for the track-widget-creation flag to leak through to a release build if that build is executed from Xcode after running flutter with
--track-widget-creation. This is because the flutter run generates aGenerated.xcconfigfile that is imported by both the debug, profile, and release configurations. If this file is not regenerated after debugging, it may still containtrack-widget-creation=true, causing the build to fail.Gradle:
Unclear, but similar error.
Related Issues
Fixes #24655
Fixes #24239
Tests
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?