Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CupertinoPicker fidelity revision #31464

Merged
merged 11 commits into from Apr 25, 2019

Conversation

@xster
Copy link
Contributor

commented Apr 23, 2019

Description

Revised the cupertino picker and date time picker

  • Add a new squeeze argument to RenderListWheelViewport to customize angular density on the cylinder
  • Add text theming support to pickers
  • Add today label for date time picker
  • Small tweaks on various picker/date time picker parameters
  • Add a check to make sure enough horizontal space is available to show the picker

Before:
Screen Shot 2019-04-22 at 5 23 37 PM

After:
Screen Shot 2019-04-22 at 6 58 59 PM
Screen Shot 2019-04-22 at 6 16 27 PM

Tests

I added the following tests:

  • squeeze test in list_wheel_scroll_view_test
  • font test in picker_test

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@xster xster requested a review from LongCatIsLooong Apr 23, 2019

@googlebot googlebot added the cla: yes label Apr 23, 2019

xster added a commit to xster/goldens that referenced this pull request Apr 23, 2019

xster added a commit to flutter/goldens that referenced this pull request Apr 24, 2019

@xster

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

Sorry for the spammy commits. Ready for a look now.

dnfield added a commit to flutter/goldens that referenced this pull request Apr 24, 2019

dnfield added a commit to flutter/goldens that referenced this pull request Apr 24, 2019

xster added a commit to xster/goldens that referenced this pull request Apr 25, 2019

xster added a commit to flutter/goldens that referenced this pull request Apr 25, 2019

xster added some commits Apr 23, 2019

a lot of the tests weren't right. Using a sizedbox directly doesn't c…
…hange the size without positioning it somewhere

@xster xster force-pushed the xster:picker-fidelity branch from c3fb44d to bd03cfd Apr 25, 2019

@xster xster merged commit 8cfc924 into flutter:master Apr 25, 2019

35 checks passed

WIP Ready for review
Details
add2app-macos Task Summary
Details
add2app-macos
Details
analyze Task Summary
Details
analyze
Details
build_tests-linux Task Summary
Details
build_tests-linux
Details
build_tests-macos Task Summary
Details
build_tests-macos
Details
build_tests-windows Task Summary
Details
build_tests-windows
Details
cla/google All necessary CLAs are signed
deploy_gallery Task Summary
Details
deploy_gallery
Details
deploy_gallery-macos Task Summary
Details
deploy_gallery-macos
Details
docs Task Summary
Details
docs
Details
flutter-build
Details
integration_tests-linux Task Summary
Details
integration_tests-linux
Details
integration_tests-windows Task Summary
Details
integration_tests-windows
Details
tests-linux Task Summary
Details
tests-linux
Details
tests-macos Task Summary
Details
tests-macos
Details
tests-windows Task Summary
Details
tests-windows
Details
tool_tests-linux Task Summary
Details
tool_tests-linux
Details
tool_tests-macos Task Summary
Details
tool_tests-macos
Details
tool_tests-windows Task Summary
Details
tool_tests-windows
Details

@xster xster deleted the xster:picker-fidelity branch Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.