Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll engine to 3e47b4bb39bb4993f03a278ea7b1c11ee6459b06 #31569

Merged
merged 9 commits into from Apr 25, 2019

Conversation

Projects
None yet
4 participants
@dnfield
Copy link
Member

commented Apr 24, 2019

Fixes #27320

Flutter engine c63d1cf9c9ba8c7d8546f24c1248433bdf827153..3e47b4bb39bb4993f03a278ea7b1c11ee6459b06 to:

flutter/engine@3e47b4b Reland const Rect/RRect (flutter/engine#8695)
flutter/engine@098ada5 Convert animated unpremul images to premul during decode (flutter/engine#8698)

This roll temporarily disables the prefer const constructor lint. We have over 800 callsites that need to be updated, but want to give custom embedders a cushion here to get a chance to have dart:ui rolled to them.

There's a chance that this could break tests in google3 because of precision changes. The semantics traversal test is an example of this. A previous PR added a rectMoreOrLessEquals to help with that.

dnfield added some commits Apr 24, 2019

@googlebot googlebot added the cla: yes label Apr 24, 2019

@dnfield

This comment has been minimized.

Copy link
Member Author

commented Apr 24, 2019

Once the custom embedders have caught up, I will re-enable the lint and fix the callsites.

@liyuqian

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

@dnfield there's a golden test failure

final double dx = math.cos(angle) * 5.0;
final double dy = math.sin(angle) * 5.0;
// These values should be truncated so that double precision rounding
// issues won't impact the heights/widths and throw off the

This comment has been minimized.

Copy link
@krisgiesing

krisgiesing Apr 24, 2019

Contributor

Missing end of sentence?

This comment has been minimized.

Copy link
@dnfield

dnfield Apr 24, 2019

Author Member

Thanks, fixed

dnfield added some commits Apr 24, 2019

@dnfield dnfield merged commit 06e1f8f into flutter:master Apr 25, 2019

35 checks passed

WIP Ready for review
Details
add2app-macos Task Summary
Details
add2app-macos
Details
analyze Task Summary
Details
analyze
Details
build_tests-linux Task Summary
Details
build_tests-linux
Details
build_tests-macos Task Summary
Details
build_tests-macos
Details
build_tests-windows Task Summary
Details
build_tests-windows
Details
cla/google All necessary CLAs are signed
deploy_gallery Task Summary
Details
deploy_gallery
Details
deploy_gallery-macos Task Summary
Details
deploy_gallery-macos
Details
docs Task Summary
Details
docs
Details
flutter-build
Details
integration_tests-linux Task Summary
Details
integration_tests-linux
Details
integration_tests-windows Task Summary
Details
integration_tests-windows
Details
tests-linux Task Summary
Details
tests-linux
Details
tests-macos Task Summary
Details
tests-macos
Details
tests-windows Task Summary
Details
tests-windows
Details
tool_tests-linux Task Summary
Details
tool_tests-linux
Details
tool_tests-macos Task Summary
Details
tool_tests-macos
Details
tool_tests-windows Task Summary
Details
tool_tests-windows
Details

@dnfield dnfield deleted the dnfield:manual_rect_roll branch Apr 25, 2019

@dnfield dnfield referenced this pull request Apr 25, 2019

Merged

Re-enable const #31600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.