Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll engine to 3e47b4bb39bb4993f03a278ea7b1c11ee6459b06 #31569

Merged
merged 9 commits into from Apr 25, 2019

Conversation

@dnfield
Copy link
Member

@dnfield dnfield commented Apr 24, 2019

Fixes #27320

Flutter engine c63d1cf..3e47b4b to:

flutter/engine@3e47b4b Reland const Rect/RRect (flutter/engine#8695)
flutter/engine@098ada5 Convert animated unpremul images to premul during decode (flutter/engine#8698)

This roll temporarily disables the prefer const constructor lint. We have over 800 callsites that need to be updated, but want to give custom embedders a cushion here to get a chance to have dart:ui rolled to them.

There's a chance that this could break tests in google3 because of precision changes. The semantics traversal test is an example of this. A previous PR added a rectMoreOrLessEquals to help with that.

@dnfield
Copy link
Member Author

@dnfield dnfield commented Apr 24, 2019

Once the custom embedders have caught up, I will re-enable the lint and fix the callsites.

@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Apr 24, 2019

@dnfield there's a golden test failure

final double dx = math.cos(angle) * 5.0;
final double dy = math.sin(angle) * 5.0;
// These values should be truncated so that double precision rounding
// issues won't impact the heights/widths and throw off the
Copy link
Contributor

@krisgiesing krisgiesing Apr 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing end of sentence?

Copy link
Member Author

@dnfield dnfield Apr 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed

@dnfield dnfield merged commit 06e1f8f into flutter:master Apr 25, 2019
35 checks passed
@dnfield dnfield deleted the manual_rect_roll branch Apr 25, 2019
@dnfield dnfield mentioned this pull request Apr 25, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants